tests: do snd_hda_intel unbind before unload in module reload test
PATCH 1/1 tests: do snd_hda_intel unbind before unload in module reload test
Try to make sure the snd_hda_intel module is not in use, and can be unloaded.
---
Keqiao, Libin, here's the script this patch is against:
https://cgit.freedesktop.org/drm/igt-gpu-tools/tree/tests/drv_module_reload_basic
--- tests/drv_module_reload_basic | 3 +++ 1 file changed, 3 insertions(+)
tests/drv_module_reload_basic +3 -0
@@ -33,6 +33,9 @@ function reload() { pkill alsactl snd_hda_intel_unloaded=0 if mod_loaded snd_hda_intel; then + if [ -e /sys/bus/pci/drivers/snd_hda_intel/unbind ]; then + echo "0000:00:03.0" > /sys/bus/pci/drivers/snd_hda_intel/unbind + fi if rmmod snd_hda_intel; then snd_hda_intel_unloaded=1 else
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/1 tests: add more debugs on failure to unload snd_hda_intel
List open files under sound devices.
--- tests/drv_module_reload_basic | 1 + 1 file changed, 1 insertion(+)
tests/drv_module_reload_basic +1 -0
@@ -40,6 +40,7 @@ function reload() { snd_hda_intel_unloaded=1 else lsmod >&2 + lsof /dev/snd/* >&2 fi fi
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 32 lines
-----Original Message-----
From: Nikula, Jani
Sent: Monday, October 31, 2016 4:40 PM
To: [email protected]
Cc: Nikula, Jani <[email protected]>; Zhang, Keqiao <[email protected]>; Yang, Libin <[email protected]>
Subject: [i-g-t PATCH] tests: dosnd_hda_intelunbind before unload in module reload testTry to make sure the
snd_hda_intelmodule is not in use, and can be unloaded.Cc Keqiao Zhang <[email protected]>Cc Libin Yang <[email protected]>Signed-off-by Jani Nikula <[email protected]>---
Keqiao, Libin, here's the script this patch is against:
https://cgit.freedesktop.org/drm/igt-gpu-
tools/tree/tests/drv_module_reload_basic--- tests/drv_module_reload_basic | 3 +++ 1 file changed, 3 insertions(+)tests/drv_module_reload_basic +0
-0
tests/drv_module_reload_basic function reload() { · line 37
Quoted 5 lines
tests/drv_module_reload_basic +2
-0@@ -33,6 +33,9 @@ function reload() { pkill alsactl snd_hda_intel_unloaded=0 if mod_loaded snd_hda_intel; then + if [ -e /sys/bus/pci/drivers/snd_hda_intel/unbind ]; then + echo "0000:00:03.0" >
"0000:00:03.0" is platform related.
We should check lspci -vvv |grep Audio to get the number.
Or we can check /sys/bus/pci/drivers/snd_hda_intel/ folder to get the number. And sometimes there are 2 sound cards to unbind.
Regards,
Libin
Quoted 7 lines
/sys/bus/pci/drivers/snd_hda_intel/unbindtests/drv_module_reload_basic +1
-1+ fi if rmmod snd_hda_intel; then snd_hda_intel_unloaded=1 else --2.1.4
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 26 lines · Libin
Quoted 26 lines
-----Original Message-----
From: Nikula, Jani
Sent: Monday, October 31, 2016 4:40 PM
To: [email protected]
Cc: Nikula, Jani <[email protected]>; Zhang, Keqiao <[email protected]>; Yang, Libin <[email protected]>
Subject: [i-g-t PATCH] tests: dosnd_hda_intelunbind before unload in module reload testTry to make sure the
snd_hda_intelmodule is not in use, and can be unloaded.Cc Keqiao Zhang <[email protected]>Cc Libin Yang <[email protected]>Signed-off-by Jani Nikula <[email protected]>---
Keqiao, Libin, here's the script this patch is against:
https://cgit.freedesktop.org/drm/igt-gpu-
tools/tree/tests/drv_module_reload_basic--- tests/drv_module_reload_basic | 3 +++ 1 file changed, 3 insertions(+)
Quoted 15 lines
tests/drv_module_reload_basic function reload() { · line 37
Quoted 10 lines
tests/drv_module_reload_basic +2
-0@@ -33,6 +33,9 @@ function reload() { pkill alsactl snd_hda_intel_unloaded=0 if mod_loaded snd_hda_intel; then + if [ -e /sys/bus/pci/drivers/snd_hda_intel/unbind ]; then + echo "0000:00:03.0" >"0000:00:03.0" is platform related.
We should check lspci -vvv |grep Audio to get the number.
Or we can check/sys/bus/pci/drivers/snd_hda_intel/folder to get the number. And sometimes there are 2 sound cards to unbind.
How about this?
for f in $(find /sys/bus/pci/drivers/snd_hda_intel -name "0000:*" -printf %f); do
echo $f > /sys/bus/pci/drivers/snd_hda_intel/unbind
done
BR,
Jani.
Quoted 12 lines
Regards,
LibinQuoted 7 lines
/sys/bus/pci/drivers/snd_hda_intel/unbindtests/drv_module_reload_basic +1
-1+ fi if rmmod snd_hda_intel; then snd_hda_intel_unloaded=1 else --2.1.4
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 1/1 tests: do snd_hda_intel unbind before unload in module reload test
In reply to Jani NikulaTry to make sure the snd_hda_intel module is not in use, and can be unloaded.
v2: unbind all cards (Libin)
---
Keqiao, Libin, here's the script this patch is against:
https://cgit.freedesktop.org/drm/igt-gpu-tools/tree/tests/drv_module_reload_basic
--- tests/drv_module_reload_basic | 5 +++++ 1 file changed, 5 insertions(+)
tests/drv_module_reload_basic +5 -0
@@ -33,6 +33,11 @@ function reload() { pkill alsactl snd_hda_intel_unloaded=0 if mod_loaded snd_hda_intel; then + # unbind sound cards + for card in $(find /sys/bus/pci/drivers/snd_hda_intel -name "0000:*" -printf "%f\n"); do + echo $card > /sys/bus/pci/drivers/snd_hda_intel/unbind + done + if rmmod snd_hda_intel; then snd_hda_intel_unloaded=1 else
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Regards,
Libin
Quoted 47 lines
-----Original Message-----
From: Nikula, Jani
Sent: Monday, October 31, 2016 7:00 PM
To: Nikula, Jani <[email protected]>; [email protected]
Cc: Zhang, Keqiao <[email protected]>; Yang, Libin <[email protected]>
Subject: [i-g-t PATCH v2] tests: dosnd_hda_intelunbind before unload in module reload testTry to make sure the
snd_hda_intelmodule is not in use, and can be unloaded.v2: unbind all cards (Libin)
Cc Keqiao Zhang <[email protected]>Cc Libin Yang <[email protected]>Signed-off-by Jani Nikula <[email protected]>---
Keqiao, Libin, here's the script this patch is against:
https://cgit.freedesktop.org/drm/igt-gpu-
tools/tree/tests/drv_module_reload_basic--- tests/drv_module_reload_basic | 5 +++++ 1 file changed, 5 insertions(+)tests/drv_module_reload_basic +2
-0@@ -33,6 +33,11 @@ function reload() { pkill alsactl snd_hda_intel_unloaded=0 if mod_loaded snd_hda_intel; then + # unbind sound cards + for card in $(find /sys/bus/pci/drivers/snd_hda_intel -name"0000:*" -printf "%f\n"); do
tests/drv_module_reload_basic +1
-0+ echo $card >
/sys/bus/pci/drivers/snd_hda_intel/unbindtests/drv_module_reload_basic +2
-1+ done + if rmmod snd_hda_intel; then snd_hda_intel_unloaded=1 else --
Quoted 1 line
2.1.4
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 1 line · Libin
Reviewed-by Libin Yang <[email protected]>
Pushed both patches to igt, thanks for the review.
BR,
Jani.
Quoted 54 lines
Regards,
LibinQuoted 48 lines
-----Original Message-----
From: Nikula, Jani
Sent: Monday, October 31, 2016 7:00 PM
To: Nikula, Jani <[email protected]>; [email protected]
Cc: Zhang, Keqiao <[email protected]>; Yang, Libin <[email protected]>
Subject: [i-g-t PATCH v2] tests: dosnd_hda_intelunbind before unload in module reload testTry to make sure the
snd_hda_intelmodule is not in use, and can be unloaded.v2: unbind all cards (Libin)
Cc Keqiao Zhang <[email protected]>Cc Libin Yang <[email protected]>Signed-off-by Jani Nikula <[email protected]>---
Keqiao, Libin, here's the script this patch is against:
https://cgit.freedesktop.org/drm/igt-gpu-
tools/tree/tests/drv_module_reload_basic--- tests/drv_module_reload_basic | 5 +++++ 1 file changed, 5 insertions(+)tests/drv_module_reload_basic +2
-0@@ -33,6 +33,11 @@ function reload() { pkill alsactl snd_hda_intel_unloaded=0 if mod_loaded snd_hda_intel; then + # unbind sound cards + for card in $(find /sys/bus/pci/drivers/snd_hda_intel -name"0000:*" -printf "%f\n"); do
tests/drv_module_reload_basic +1
-0+ echo $card >
/sys/bus/pci/drivers/snd_hda_intel/unbindtests/drv_module_reload_basic +2
-1+ done + if rmmod snd_hda_intel; then snd_hda_intel_unloaded=1 else --2.1.4
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx