pwm: fix device reference leak
PATCH 1/1 pwm: fix device reference leak
Make sure to drop the reference to the parent device taken by class_find_device() after "unexporting" any children when deregistering a pwm chip.
Fixes 0733424c9ba9 ("pwm: Unexport children before chip removal")
Signed-off-by Johan Hovold <[email protected]>
--- drivers/pwm/sysfs.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/pwm/sysfs.c +2 -0
@@ -425,6 +425,8 @@ void pwmchip_sysfs_unexport_children(struct pwm_chip *chip)if (test_bit (PWMF_EXPORTED , &pwm->flags))pwm_unexport_child (parent, pwm); } + +put_device (parent); }static int __init pwm_sysfs_init (void )
Signature · 1 line
2.7.3
Quoted 15 lines · Johan Hovold
Make sure to drop the reference to the parent device taken by
class_find_device()after "unexporting" any children when deregistering a pwm chip.Fixes 0733424c9ba9 ("pwm: Unexport children before chip removal")Signed-off-by Johan Hovold <[email protected]>--- drivers/pwm/sysfs.c | 2 ++ 1 file changed, 2 insertions(+)drivers/pwm/sysfs.c +0
-0
drivers/pwm/sysfs.c void pwmchip_sysfs_unexport_children(struct pwm_chip *chip) · line 432
Quoted 8 lines
drivers/pwm/sysfs.c +2
-0@@ -425,6 +425,8 @@ void pwmchip_sysfs_unexport_children(struct pwm_chip *chip)if (test_bit (PWMF_EXPORTED , &pwm->flags))pwm_unexport_child (parent, pwm); } + +put_device (parent); }static int __init pwm_sysfs_init (void )
Thought I'd send a gentle reminder about this one. Is it still in your queue, Thierry?
Thanks,
Johan
Thierry Reding
AppliedQuoted 9 lines · Johan Hovold
Make sure to drop the reference to the parent device taken by
class_find_device()after "unexporting" any children when deregistering a pwm chip.Fixes 0733424c9ba9 ("pwm: Unexport children before chip removal")Signed-off-by Johan Hovold <[email protected]>--- drivers/pwm/sysfs.c | 2 ++ 1 file changed, 2 insertions(+)
Applied, thanks.
Thierry