PM / sleep: fix device reference leak in test_suspend
Subsystems (2)
PATCH 1/1 PM / sleep: fix device reference leak in test_suspend
Make sure to drop the reference taken by class_find_device() after opening the rtc device.
Fixes 77437fd4e61f ("pm: boot time suspend selftest")
Signed-off-by Johan Hovold <[email protected]>
--- kernel/power/suspend_test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
kernel/power/suspend_test.c +3 -1
@@ -203,8 +203,10 @@ static int __init test_suspend(void)/* RTCs have initialized by now too ... can we use one? */ dev =class_find_device (rtc_class,NULL ,NULL , has_wakealarm); -if (dev) +if (dev) { rtc =rtc_class_open (dev_name (dev)); +put_device (dev); + }if (!rtc) {printk (warn_no_rtc);return 0 ;
Signature · 1 line
2.7.3
Quoted 5 lines · Johan Hovold
Make sure to drop the reference taken by
class_find_device()after opening the rtc device.Fixes 77437fd4e61f ("pm: boot time suspend selftest")Signed-off-by Johan Hovold <[email protected]>
Acked-by Pavel Machek <[email protected]>
Quoted 20 lines
--- kernel/power/suspend_test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)kernel/power/suspend_test.c +3
-1@@ -203,8 +203,10 @@ static int __init test_suspend(void)/* RTCs have initialized by now too ... can we use one? */ dev =class_find_device (rtc_class,NULL ,NULL , has_wakealarm); -if (dev) +if (dev) { rtc =rtc_class_open (dev_name (dev)); +put_device (dev); + }if (!rtc) {printk (warn_no_rtc);return 0 ;
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html