Skip to contentSkip to conversation

igb: Workaround for igb i210 firmware issue.

PATCH In review Chris J Arges 2 participants 2 messages Nov 2, 2016 – Nov 7, 2016

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 igb: Workaround for igb i210 firmware issue.

Sometimes firmware may not properly initialize I347AT4_PAGE_SELECT causing the probe of an igb i210 NIC to fail. This patch adds an addition zeroing of this register during igb_get_phy_id to workaround this issue.

Thanks for Jochen Henneberg for the idea and original patch.

---
 drivers/net/ethernet/intel/igb/e1000_phy.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/ethernet/intel/igb/e1000_phy.c +4 -0
index 5b54254..93ec2d0 100644
@@ -77,6 +77,10 @@ s32 igb_get_phy_id(struct e1000_hw *hw)
 	s32 ret_val = 0;
 	u16 phy_id;
 
+	/* ensure phy page selection to fix misconfigured i210 */
+	if (hw->mac.type == e1000_i210)
+		phy->ops.write_reg(hw, I347AT4_PAGE_SELECT, 0);
+
 	ret_val = phy->ops.read_reg(hw, PHY_ID1, &phy_id);
 	if (ret_val)
 		goto out;
Signature · 1 line
2.7.4
Tested-by on v1 1/1
#1 lore raw
Quoted 15 lines

From: netdev-owner at vger.kernel.org [mailto:netdev- owner at vger.kernel.org] On Behalf Of Chris J Arges
Sent: Wednesday, November 2, 2016 7:14 AM
To: jh at henneberg-systemdesign.com
Cc: intel-wired-lan at lists.osuosl.org; Chris J Arges <[email protected]>; Kirsher, Jeffrey T <[email protected]>; netdev at vger.kernel.org; linux- kernel at vger.kernel.org
Subject: [PATCH] igb: Workaround for igb i210 firmware issue.

Sometimes firmware may not properly initialize I347AT4_PAGE_SELECT causing
the probe of an igb i210 NIC to fail. This patch adds an addition zeroing of this register during igb_get_phy_id to workaround this issue.

Quoted 6 lines

Thanks for Jochen Henneberg for the idea and original patch.

---
 drivers/net/ethernet/intel/igb/e1000_phy.c | 4 ++++
 1 file changed, 4 insertions(+)