virtio-gpu: fix vblank events
Subsystems (3)
Gerd Hoffmann
maintainerPATCH 1/1 virtio-gpu: fix vblank events
virtio-gpu sends vblank events in virtio_gpu_crtc_atomic_flush, and because of that it must be called for disabled planes too. Ask drm_atomic_helper_commit_planes to do that.
--- drivers/gpu/drm/virtio/virtgpu_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/virtio/virtgpu_display.c +1 -1
@@ -338,7 +338,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state *state)drm_atomic_helper_commit_modeset_disables (dev, state);drm_atomic_helper_commit_modeset_enables (dev, state); -drm_atomic_helper_commit_planes (dev, state, true); +drm_atomic_helper_commit_planes (dev, state, false);drm_atomic_helper_commit_hw_done (state);
Signature · 6 lines
1.8.3.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 1/1 virtio-gpu: fix vblank events
From: Gustavo Padovan <[email protected]>
virtio-gpu sends vblank events in virtio_gpu_crtc_atomic_flush, and because of that it must be called for disabled planes too. Ask drm_atomic_helper_commit_planes to do that.
v2: update to use new drm_atomic_helper_commit_planes() API.
--- drivers/gpu/drm/virtio/virtgpu_display.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/virtio/virtgpu_display.c +1 -2
@@ -340,8 +340,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state *state)drm_atomic_helper_commit_modeset_disables (dev, state);drm_atomic_helper_commit_modeset_enables (dev, state); -drm_atomic_helper_commit_planes (dev, state, -DRM_PLANE_COMMIT_ACTIVE_ONLY ); +drm_atomic_helper_commit_planes (dev, state,0 );drm_atomic_helper_commit_hw_done (state);
Signature · 6 lines
2.5.5 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
2016-10-18 Gustavo Padovan <[email protected]>:
Quoted 1 line
From: Gustavo Padovan <[email protected]>
Author info is wrong. It should be Gerd, I'll send another patch.
Quoted 30 lines
virtio-gpu sends vblank events in
virtio_gpu_crtc_atomic_flush, and because of that it must be called for disabled planes too. Askdrm_atomic_helper_commit_planesto do that.v2: update to use new
drm_atomic_helper_commit_planes()API.Signed-off-by Gerd Hoffmann <[email protected]>Signed-off-by Gustavo Padovan <[email protected]>--- drivers/gpu/drm/virtio/virtgpu_display.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/gpu/drm/virtio/virtgpu_display.c +1
-2@@ -340,8 +340,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state *state)drm_atomic_helper_commit_modeset_disables (dev, state);drm_atomic_helper_commit_modeset_enables (dev, state); -drm_atomic_helper_commit_planes (dev, state, -DRM_PLANE_COMMIT_ACTIVE_ONLY ); +drm_atomic_helper_commit_planes (dev, state,0 );drm_atomic_helper_commit_hw_done (state);Signature · 1 line
2.5.5
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 1/1 virtio-gpu: fix vblank events
In reply to Gerd HoffmannFrom: Gerd Hoffmann <[email protected]>
virtio-gpu sends vblank events in virtio_gpu_crtc_atomic_flush, and because of that it must be called for disabled planes too. Ask drm_atomic_helper_commit_planes to do that.
v2: update to use new drm_atomic_helper_commit_planes() API.
--- drivers/gpu/drm/virtio/virtgpu_display.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/virtio/virtgpu_display.c +1 -2
@@ -340,8 +340,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state *state)drm_atomic_helper_commit_modeset_disables (dev, state);drm_atomic_helper_commit_modeset_enables (dev, state); -drm_atomic_helper_commit_planes (dev, state, -DRM_PLANE_COMMIT_ACTIVE_ONLY ); +drm_atomic_helper_commit_planes (dev, state,0 );drm_atomic_helper_commit_hw_done (state);
Signature · 6 lines
2.5.5 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 1/1 virtio-gpu: fix vblank events
In reply to Gerd HoffmannFrom: Gerd Hoffmann <[email protected]>
virtio-gpu sends vblank events in virtio_gpu_crtc_atomic_flush, and because of that it must be called for disabled planes too. Ask drm_atomic_helper_commit_planes to do that.
v2: update to use new drm_atomic_helper_commit_planes() API.
--- drivers/gpu/drm/virtio/virtgpu_display.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/virtio/virtgpu_display.c +1 -2
@@ -340,8 +340,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state *state)drm_atomic_helper_commit_modeset_disables (dev, state);drm_atomic_helper_commit_modeset_enables (dev, state); -drm_atomic_helper_commit_planes (dev, state, -DRM_PLANE_COMMIT_ACTIVE_ONLY ); +drm_atomic_helper_commit_planes (dev, state,0 );drm_atomic_helper_commit_hw_done (state);
Signature · 6 lines
2.5.5 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
ping
2016-10-18 Gustavo Padovan <[email protected]>:
Quoted 31 lines
From: Gerd Hoffmann <[email protected]>
virtio-gpu sends vblank events in
virtio_gpu_crtc_atomic_flush, and because of that it must be called for disabled planes too. Askdrm_atomic_helper_commit_planesto do that.v2: update to use new
drm_atomic_helper_commit_planes()API.Signed-off-by Gerd Hoffmann <[email protected]>Signed-off-by Gustavo Padovan <[email protected]>--- drivers/gpu/drm/virtio/virtgpu_display.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/gpu/drm/virtio/virtgpu_display.c +1
-2@@ -340,8 +340,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state *state)drm_atomic_helper_commit_modeset_disables (dev, state);drm_atomic_helper_commit_modeset_enables (dev, state); -drm_atomic_helper_commit_planes (dev, state, -DRM_PLANE_COMMIT_ACTIVE_ONLY ); +drm_atomic_helper_commit_planes (dev, state,0 );drm_atomic_helper_commit_hw_done (state);Signature · 1 line
2.5.5
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Gerd Hoffmann
maintainerHi,
Dave, that is the only fix needed for for 4.9, can you pick it up directly? Otherwise I can prepare a single-patch pull request with it ...
thanks,
Gerd
Quoted 30 lines · Gustavo Padovan
ping
2016-10-18 Gustavo Padovan <[email protected]>:
Quoted 26 lines
From: Gerd Hoffmann <[email protected]>
virtio-gpu sends vblank events in
virtio_gpu_crtc_atomic_flush, and because of that it must be called for disabled planes too. Askdrm_atomic_helper_commit_planesto do that.v2: update to use new
drm_atomic_helper_commit_planes()API.Signed-off-by Gerd Hoffmann <[email protected]>Signed-off-by Gustavo Padovan <[email protected]>--- drivers/gpu/drm/virtio/virtgpu_display.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/gpu/drm/virtio/virtgpu_display.c +1
-2@@ -340,8 +340,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state *state)drm_atomic_helper_commit_modeset_disables (dev, state);drm_atomic_helper_commit_modeset_enables (dev, state); -drm_atomic_helper_commit_planes (dev, state, -DRM_PLANE_COMMIT_ACTIVE_ONLY ); +drm_atomic_helper_commit_planes (dev, state,0 );
Quoted 5 lines
Quoted 5 lines
drivers/gpu/drm/virtio/virtgpu_display.c +0
-0drm_atomic_helper_commit_hw_done (state);Signature · 1 line
2.5.5
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Gerd Hoffmann
maintainerQuoted 5 lines · Gerd Hoffmann
Hi,
Dave, that is the only fix needed for for 4.9, can you pick it up directly? Otherwise I can prepare a single-patch pull request with it ...
ok, scratch that, just saw this already is in the -rc4 fixes pull req.
cheers,
Gerd
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel