Skip to contentSkip to conversation

openvpn version line: remove [IPv6], add [AEAD] if available

PATCH In review Gert Doering 2 participants 3 messages Nov 7, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 openvpn version line: remove [IPv6], add [AEAD] if available

Printing [IPv6] is no longer relevant information, as IPv6 support is always build in. So, "2.4 = has IPv6, always".

[AEAD] is relevant information, as the underlying SSL library might be too old to have support for it (OpenSSL 0.9.x) and this eases figuring out why NCP is not upgrading a connection to AES-256-GCM.

Trac #762

---
 src/openvpn/options.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
src/openvpn/options.c +3 -1
index 552bf5a..5a5e7ef 100644
@@ -103,7 +103,9 @@ const char title_string[] =
   " [MH/RECVDA]"
 # endif
 #endif
-  " [IPv6]"
+#ifdef HAVE_AEAD_CIPHER_MODES
+  " [AEAD]"
+#endif
   " built on " __DATE__
 ;
 
Signature · 1 line
2.7.3
#1 lore raw
Quoted 19 lines · Gert Doering

Printing [IPv6] is no longer relevant information, as IPv6 support is always build in. So, "2.4 = has IPv6, always".

[AEAD] is relevant information, as the underlying SSL library might be too old to have support for it (OpenSSL 0.9.x) and this eases figuring out why NCP is not upgrading a connection to AES-256-GCM.

Trac #762

---
 src/openvpn/options.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
src/openvpn/options.c +0 -0
index 552bf5a..5a5e7ef 100644

src/openvpn/options.c const char title_string[] = · line 110

Quoted 9 lines
src/openvpn/options.c +3 -1
@@ -103,7 +103,9 @@ const char title_string[] =
   " [MH/RECVDA]"
 # endif
 #endif
-  " [IPv6]"
+#ifdef HAVE_AEAD_CIPHER_MODES
+  " [AEAD]"
+#endif
   " built on " __DATE__
 ;

ACK

-Steffan

#2 lore raw
In reply to Gert Doering

Patch has been applied to the master branch.

commit 2391a3ab08227a061a7f561e26b9688f6ba80e70

Author: Gert Doering
Date:   Mon Nov 7 11:50:52 2016 +0100
     openvpn version line: remove [IPv6], add [AEAD] if available

     Signed-off-by: Gert Doering <[email protected]...>
     Acked-by: Steffan Karger <[email protected]...>
     Message-Id: <[email protected]...>
     URL: http://www.mail-archive.com/search?l=mid&[email protected]...
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering