Skip to contentSkip to conversation

Patch "ovl: fsync after copy-up" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Nov 8, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ovl: fsync after copy-up

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ovl-fsync-after-copy-up.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 641089c1549d8d3df0b047b5de7e9a111362cdce Mon Sep 17 00:00:00 2001

From: Miklos Szeredi <[email protected]>
Date: Mon, 31 Oct 2016 14:42:14 +0100
Subject: ovl: fsync after copy-up

From: Miklos Szeredi <[email protected]>

commit 641089c1549d8d3df0b047b5de7e9a111362cdce upstream.

Make sure the copied up file hits the disk before renaming to the final destination. If this is not done then the copy-up may corrupt the data in the file in case of a crash.

---
 fs/overlayfs/copy_up.c |    2 ++
 1 file changed, 2 insertions(+)
fs/overlayfs/copy_up.c +2 -0
@@ -139,6 +139,8 @@ static int ovl_copy_up_data(struct path
 		len -= bytes;
 	}
 
+	if (!error)
+		error = vfs_fsync(new_file, 0);
 	fput(new_file);
 out_fput:
 	fput(old_file);

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/ovl-fsync-after-copy-up.patch