Patch "drm: Release reference from blob lookup after replacing property" has been added to the 4.8-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
drm: Release reference from blob lookup after replacing property
to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drm-release-reference-from-blob-lookup-after-replacing-property.patch
and it can be found in the queue-4.8 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
cac5fcedaabdadf150c8a9be9fee76defc8ba444Mon Sep 17 00:00:00 2001
From: Felix Monninger <[email protected]>
Date: Tue, 25 Oct 2016 22:28:08 +0100
Subject: drm: Release reference from blob lookup after replacing property
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Felix Monninger <[email protected]>
commit cac5fcedaabdadf150c8a9be9fee76defc8ba444 upstream.
drm_property_lookup_blob() returns a reference to the returned blob, and drm_atomic_replace_property_blob() takes a references to the blob it stores, so afterwards we are left owning a reference to the new_blob that we never release, and thus leak memory every time we update a property such as during drm_atomic_helper_legacy_gamma_set().
v2: update credentials, drm_property_unreference_blob() is NULL safe and NULL is passed consistently to it throughout drm_atomic.c so do so here.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98420
--- drivers/gpu/drm/drm_atomic.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_atomic.c +6 -3
@@ -420,18 +420,21 @@ drm_atomic_replace_property_blob_from_idssize_t expected_size, bool *replaced) { - struct drm_device *dev = crtc->dev; struct drm_property_blob *new_blob = NULL;if (blob_id !=0 ) { - new_blob =drm_property_lookup_blob (dev, blob_id); + new_blob =drm_property_lookup_blob (crtc->dev, blob_id);if (new_blob ==NULL )return -EINVAL ; -if (expected_size >0 && expected_size != new_blob->length) + +if (expected_size >0 && expected_size != new_blob->length) { +drm_property_unreference_blob (new_blob);return -EINVAL ; + } }drm_atomic_replace_property_blob (blob, new_blob, replaced); +drm_property_unreference_blob (new_blob);return 0 ; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.8/drm-release-reference-from-blob-lookup-after-replacing-property.patch