Skip to contentSkip to conversation

Fix a logic problem in handling of --up scripts in t_client.sh

PATCH In review [email protected]... 2 participants 2 messages Nov 9, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix a logic problem in handling of --up scripts in t_client.sh

From: Samuli Seppänen <[email protected]...>

Previously the $up variable was never reset after being set. This mean that "--up update_t_client_ips.sh" was appended to all subsequent openvpn command-lines, even if cached IPs existed.

---
 tests/t_client.sh.in | 2 ++
 1 file changed, 2 insertions(+)
tests/t_client.sh.in +2 -0
index 076f6bd..b92cb65 100755
@@ -276,6 +276,8 @@ do
     # script to generate them dynamically.
     if [ -z "$expect_ifconfig4" ] || [ -z "$expect_ifconfig6" ]; then
         up="--setenv TESTNUM $SUF --setenv TOP_BUILDDIR ${top_builddir} --script-security 2 --up ${srcdir}/update_t_client_ips.sh"
+    else
+        up=""
     fi
 
     echo -e "\n### test run $SUF: '$test_run_title' ###\n"
Signature · 1 line
2.1.4
#1 lore raw

ACK :-)

Your patch has been applied to the master branch.

commit dd9a4f0ecf06e907c57f4fa7ab035b897268d54a

Author: Samuli Seppänen
Date:   Wed Nov 9 14:42:05 2016 +0200
     Fix a logic problem in handling of --up scripts in t_client.sh

     Signed-off-by: Samuli Seppänen <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg12979.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering