ASoC: samsung: Remove unselectable smdk_wm8580pcm
Subsystems (3)
PATCH 1/1 ASoC: samsung: Remove unselectable smdk_wm8580pcm
The SND_SOC_SMDK_WM8580_PCM Kconfig entry depends on either MACH_SMDKV210 or MACH_SMDKC110. Both of which were removed in commit 28c8331d386a ("ARM:
S5PV210: Remove support for board files") over two years ago. The driver has been unselectable ever since.
Considering the lack of complaints about this it can be concluded that the driver is unused and can be removed.
--- sound/soc/samsung/Kconfig | 9 -- sound/soc/samsung/Makefile | 2 - sound/soc/samsung/smdk_wm8580pcm.c | 175 ------------------------------------- 3 files changed, 186 deletions(-) delete mode 100644 sound/soc/samsung/smdk_wm8580pcm.c
sound/soc/samsung/Kconfig +0 -9
@@ -119,15 +119,6 @@ config SND_SOC_SAMSUNG_SMDK_SPDIF help Say Y if you want to add support for SoC S/PDIF audio on the SMDK. -config SND_SOC_SMDK_WM8580_PCM - tristate "SoC PCM Audio support for WM8580 on SMDK" - depends on MACH_SMDKV210 || MACH_SMDKC110 - depends on I2C - select SND_SOC_WM8580 - select SND_SAMSUNG_PCM - help - Say Y if you want to add support for SoC audio on the SMDK. - config SND_SOC_SMDK_WM8994_PCM tristate "SoC PCM Audio support for WM8994 on SMDK" depends on I2C=y
sound/soc/samsung/Makefile +0 -2
@@ -34,7 +34,6 @@ snd-soc-snow-objs := snow.o snd-soc-smdk-wm9713-objs := smdk_wm9713.o snd-soc-s3c64xx-smartq-wm8987-objs := smartq_wm8987.o snd-soc-smdk-spdif-objs := smdk_spdif.o -snd-soc-smdk-wm8580pcm-objs := smdk_wm8580pcm.o snd-soc-smdk-wm8994pcm-objs := smdk_wm8994pcm.o snd-soc-speyside-objs := speyside.o snd-soc-tobermory-objs := tobermory.o
@@ -59,7 +58,6 @@ obj-$(CONFIG_SND_SOC_SNOW) += snd-soc-snow.o obj-$(CONFIG_SND_SOC_SAMSUNG_SMDK_WM9713) += snd-soc-smdk-wm9713.o obj-$(CONFIG_SND_SOC_SMARTQ) += snd-soc-s3c64xx-smartq-wm8987.o obj-$(CONFIG_SND_SOC_SAMSUNG_SMDK_SPDIF) += snd-soc-smdk-spdif.o -obj-$(CONFIG_SND_SOC_SMDK_WM8580_PCM) += snd-soc-smdk-wm8580pcm.o obj-$(CONFIG_SND_SOC_SMDK_WM8994_PCM) += snd-soc-smdk-wm8994pcm.o obj-$(CONFIG_SND_SOC_SPEYSIDE) += snd-soc-speyside.o obj-$(CONFIG_SND_SOC_TOBERMORY) += snd-soc-tobermory.o
sound/soc/samsung/smdk_wm8580pcm.c deleted +0 -175
175 lines not on this page · raw message
Signature · 1 line
2.1.4
Quoted 4 lines · Lars-Peter Clausen
The
SND_SOC_SMDK_WM8580_PCMKconfigentry depends on eitherMACH_SMDKV210orMACH_SMDKC110. Both of which were removed in commit28c8331d386a("ARM:
S5PV210: Remove support for board files") over two years ago. The driver has been unselectable ever since.
The boards were converted to DT-only thus there are no MACH_xxx symbols. They are still supporter... but actually it does not matter because the machine_is_smdkc110() calls will return false on DT-based platform.
I see there is even more to cleanup of these old MACH symbols.
Anyway:
Best regards,
Krzysztof
Quoted 9 lines · Lars-Peter Clausen
The
SND_SOC_SMDK_WM8580_PCMKconfigentry depends on eitherMACH_SMDKV210orMACH_SMDKC110. Both of which were removed in commit28c8331d386a("ARM:
S5PV210: Remove support for board files") over two years ago. The driver has been unselectable ever since.Considering the lack of complaints about this it can be concluded that the driver is unused and can be removed.
Signed-off-by Lars-Peter Clausen <[email protected]>
This driver should be converted to work in DT mode, but there seem to have been no interest indeed in having it working properly in mainline for a quite long time so I think it's a good idea to just drop this code now.