IB/IPoIB: Remove can't use GFP_NOIO warning

PATCH In review Leon Romanovsky 4 participants 4 messages Nov 10, 2016 – Nov 18, 2016 2 messages not in the archive InfiniBand

lore

Share & tools

lore

Leon Romanovsky

author

2016-11-10 08:16 UTC #0 lore raw

PATCH 1/1 IB/IPoIB: Remove can't use GFP_NOIO warning

From: Kamal Heib <kamalh-VPRAkNaXOzVWk0Htik3J/[email protected]>

Remove the warning print of "can't use of GFP_NOIO" to avoid prints in each QP creation when devices aren't supporting IB_QP_CREATE_USE_GFP_NOIO.

This print become more annoying when the IPoIB interface is configured to work in connected mode.

Fixes 09b93088d750 ('IB: Add a QP creation flag to use GFP_NOIO allocations')

Signed-off-by Kamal Heib <kamalh-VPRAkNaXOzVWk0Htik3J/[email protected]>

Signed-off-by Leon Romanovsky <[email protected]>

---
 drivers/infiniband/ulp/ipoib/ipoib_cm.c | 2 --
 1 file changed, 2 deletions(-)

drivers/infiniband/ulp/ipoib/ipoib_cm.c +0 -2

index 4ad297d..50c9772 100644
@@ -1053,8 +1053,6 @@ static struct ib_qp *ipoib_cm_create_tx_qp(struct net_device *dev, struct ipoib_
 
 	tx_qp = ib_create_qp(priv->pd, &attr);
 	if (PTR_ERR(tx_qp) == -EINVAL) {
-		ipoib_warn(priv, "can't use GFP_NOIO for QPs on device %s, using GFP_KERNEL\n",
-			   priv->ca->name);
 		attr.create_flags &= ~IB_QP_CREATE_USE_GFP_NOIO;
 		tx_qp = ib_create_qp(priv->pd, &attr);
 	}

Signature · 6 lines

2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 1478765808-12517-1-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org

Yuval Shaia

Reviewed-by

2016-11-10 08:33 UTC #2 lore raw

Reviewed-by Yuval Shaia <[email protected]>

Quoted 35 lines · Leon Romanovsky

From: Kamal Heib <kamalh-VPRAkNaXOzVWk0Htik3J/[email protected]>
Remove the warning print of "can't use of GFP_NOIO" to avoid prints in each QP creation when devices aren't supporting IB_QP_CREATE_USE_GFP_NOIO.
This print become more annoying when the IPoIB interface is configured to work in connected mode.
Fixes 09b93088d750 ('IB: Add a QP creation flag to use GFP_NOIO allocations')
Signed-off-by Kamal Heib <kamalh-VPRAkNaXOzVWk0Htik3J/[email protected]>
Signed-off-by Leon Romanovsky <[email protected]>
---
 drivers/infiniband/ulp/ipoib/ipoib_cm.c | 2 --
 1 file changed, 2 deletions(-)
drivers/infiniband/ulp/ipoib/ipoib_cm.c +0 -2
index 4ad297d..50c9772 100644
@@ -1053,8 +1053,6 @@ static struct ib_qp *ipoib_cm_create_tx_qp(struct net_device *dev, struct ipoib_
 
 	tx_qp = ib_create_qp(priv->pd, &attr);
 	if (PTR_ERR(tx_qp) == -EINVAL) {
-		ipoib_warn(priv, "can't use GFP_NOIO for QPs on device %s, using GFP_KERNEL\n",
-			   priv->ca->name);
 		attr.create_flags &= ~IB_QP_CREATE_USE_GFP_NOIO;
 		tx_qp = ib_create_qp(priv->pd, &attr);
 	}
Signature · 6 lines
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Or Gerlitz

2016-11-17 22:30 UTC #3 lore raw

In reply to a message not in the archive

Quoted 9 lines · Leon Romanovsky

From: Kamal Heib <kamalh-VPRAkNaXOzVWk0Htik3J/[email protected]>
Remove the warning print of "can't use of GFP_NOIO" to avoid prints in each QP creation when devices aren't supporting IB_QP_CREATE_USE_GFP_NOIO.
This print become more annoying when the IPoIB interface is configured to work in connected mode.
Fixes 09b93088d750 ('IB: Add a QP creation flag to use GFP_NOIO allocations')

Hi Kamal,

I don't think you're fixing a bug in this commit... you find the print annoying and you remove it, okay, maybe we can do that. Why not leave it in rate-limited manner? can you elaborate what was that deeply annoying with getting the warning?

drivers/infiniband/ulp/ipoib/ipoib_cm.c static struct ib_qp *ipoib_cm_create_tx_qp(struct net_device *dev, struct ipoib_ · line 1058

Quoted 11 lines

drivers/infiniband/ulp/ipoib/ipoib_cm.c +0 -2

@@ -1053,8 +1053,6 @@ static struct ib_qp *ipoib_cm_create_tx_qp(struct net_device *dev, struct ipoib_
 
        tx_qp = ib_create_qp(priv->pd, &attr);
        if (PTR_ERR(tx_qp) == -EINVAL) {
-               ipoib_warn(priv, "can't use GFP_NOIO for QPs on device %s, using GFP_KERNEL\n",
-                          priv->ca->name);
                attr.create_flags &= ~IB_QP_CREATE_USE_GFP_NOIO;
                tx_qp = ib_create_qp(priv->pd, &attr);
        }

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): CAJ3xEMgCFmSMA5F-7D89n248K2HovvwHnnMgke7-FSDbROFA4Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

Kamal Heib

2016-11-18 10:34 UTC #5 lore raw

Quoted 6 lines · Or Gerlitz

Quoted 5 lines · Leon Romanovsky
From: Kamal Heib <kamalh-VPRAkNaXOzVWk0Htik3J/[email protected]>
Remove the warning print of "can't use of GFP_NOIO" to avoid prints in each QP creation when devices aren't supporting IB_QP_CREATE_USE_GFP_NOIO.

Quoted 6 lines

Quoted 4 lines
This print become more annoying when the IPoIB interface is configured to work in connected mode.
Fixes 09b93088d750 ('IB: Add a QP creation flag to use GFP_NOIO allocations')
Hi Kamal,

Hi Or :)

Quoted 6 lines

I don't think you're fixing a bug in this commit... you find the print annoying and you remove it, okay, maybe we can do that. Why not leave it in rate-limited manner? can you elaborate what was that deeply annoying with getting the warning?

It's really annoying when you have multiple ipoib interfaces and pkeys, so the dmesg will look like the following:

[933236.858739] mlx5_ib0: can't use GFP_NOIO for QPs on device mlx5_0,
using GFP_KERNEL
[933407.571911] mlx5_ib0.8002: can't use GFP_NOIO for QPs on device
mlx5_0, using GFP_KERNEL
[933634.121955] mlx5_ib0.8006: can't use GFP_NOIO for QPs on device
mlx5_0, using GFP_KERNEL
[934167.851164] mlx5_ib0.8004: can't use GFP_NOIO for QPs on device
mlx5_0, using GFP_KERNEL
[934936.645002] mlx5_ib0.8002: can't use GFP_NOIO for QPs on device

mlx5_0, using GFP_KERNEL

Quoted 4 lines

Quoted 4 lines
drivers/infiniband/ulp/ipoib/ipoib_cm.c +0 -0
@@ -1053,8 +1053,6 @@ static struct ib_qp *ipoib_cm_create_tx_qp(struct net_device *dev, struct ipoib_
 

Quoted 11 lines

drivers/infiniband/ulp/ipoib/ipoib_cm.c static struct ib_qp *ipoib_cm_create_tx_qp(struct net_device *dev, struct ipoib_ · line 1058
Quoted 7 lines
drivers/infiniband/ulp/ipoib/ipoib_cm.c +0 -2
        tx_qp = ib_create_qp(priv->pd, &attr);
        if (PTR_ERR(tx_qp) == -EINVAL) {
-               ipoib_warn(priv, "can't use GFP_NOIO for QPs on device %s, using GFP_KERNEL\n",
-                          priv->ca->name);
                attr.create_flags &= ~IB_QP_CREATE_USE_GFP_NOIO;
                tx_qp = ib_create_qp(priv->pd, &attr);
        }
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html