Skip to contentSkip to conversation

ARM: dts: add board dts file for Exynos4412 based SMDK board

PATCH New Thomas Abraham 4 participants 10 messages Nov 3, 2012 – Nov 16, 2012

Subsystems (3)
Device tree bindings Arm Samsung Exynos Arm and arm64 SoC sub-architectures (common parts)
lore
Share & tools
lore

Thomas Abraham

author
#0 lore raw

PATCH 1/1 ARM: dts: add board dts file for Exynos4412 based SMDK board

Add a minimal board dts file for Samsung Exynos4412 based SMDK board.

Signed-off-by Thomas Abraham <[email protected]>

---
This patch depends the on the following patch posted by Tomasz Figa. "ARM: dts: exynos4: Add support for Exynos4x12 SoCs"

 arch/arm/boot/dts/Makefile                |    1 +
 arch/arm/boot/dts/exynos4412-smdk4412.dts |   45 +++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos4412-smdk4412.dts
arch/arm/boot/dts/Makefile +1 -0
index f37cf9f..36488a5 100644
@@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_DOVE) += dove-cm-a510.dtb \
 dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
 	exynos4210-smdkv310.dtb \
 	exynos4210-trats.dtb \
+	exynos4412-smdk4412.dtb \
 	exynos5250-smdk5250.dtb
 dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb
 dtb-$(CONFIG_ARCH_INTEGRATOR) += integratorap.dtb \
arch/arm/boot/dts/exynos4412-smdk4412.dts new file +45 -0

45 lines not on this page · raw message

Signature · 1 line
1.6.6.rc2
#1 lore raw

PATCH 1/1 ARM: dts: add board dts file for Exynos4412 based SMDK board

Quoted 80 lines · Thomas Abraham

Add a minimal board dts file for Samsung Exynos4412 based SMDK board.

Signed-off-by Thomas Abraham <[email protected]>

---
This patch depends the on the following patch posted by Tomasz Figa. "ARM: dts: exynos4: Add support for Exynos4x12 SoCs"

 arch/arm/boot/dts/Makefile                |    1 +
 arch/arm/boot/dts/exynos4412-smdk4412.dts |   45
+++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos4412-smdk4412.dts
arch/arm/boot/dts/Makefile +1 -0
index f37cf9f..36488a5 100644
@@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_DOVE) += dove-cm-a510.dtb \
 dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
 	exynos4210-smdkv310.dtb \
 	exynos4210-trats.dtb \
+	exynos4412-smdk4412.dtb \
 	exynos5250-smdk5250.dtb
 dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb
 dtb-$(CONFIG_ARCH_INTEGRATOR) += integratorap.dtb \
arch/arm/boot/dts/exynos4412-smdk4412.dts new file +27 -0
new file mode 100644
index 0000000..f05bf57
@@ -0,0 +1,45 @@
+/*
+ * Samsung's Exynos4412 based SMDK board device tree source
+ *
+ * Copyright (c) 2012-2013 Samsung Electronics Co., Ltd.
+ *		http://www.samsung.com
+ *
+ * Device tree source file for Samsung's SMDK4412 board which is based on
+ * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+/dts-v1/;
+/include/ "exynos4412.dtsi"
+
+/ {
+	model = "Samsung SMDK evaluation board based on Exynos4412";
+	compatible = "samsung,smdk4412", "samsung,exynos4412";
+
+	memory {
+		reg = <0x40000000 0x40000000>;
+	};
+
+	chosen {
+		bootargs ="root=/dev/ram0 rw ramdisk=8192

initrd=0x41000000,8M console=ttySAC1,115200 init=/linuxrc";

arch/arm/boot/dts/exynos4412-smdk4412.dts new file +18 -1
+	};
+
+	serial at 13800000 {
+		status = "okay";
+	};
+
+	serial at 13810000 {
+		status = "okay";
+	};
+
+	serial at 13820000 {
+		status = "okay";
+	};
+
+	serial at 13830000 {
+		status = "okay";
+	};
+};
--
Quoted 1 line

1.6.6.rc2

Looks good to me, will apply.

BTW, its default console is ttySAC1 not ttySAC2?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

author
#2 lore raw

PATCH 1/1 ARM: dts: add board dts file for Exynos4412 based SMDK board

Quoted 85 lines · Kukjin Kim
Quoted 80 lines · Thomas Abraham

Add a minimal board dts file for Samsung Exynos4412 based SMDK board.

Signed-off-by Thomas Abraham <[email protected]>

---
This patch depends the on the following patch posted by Tomasz Figa. "ARM: dts: exynos4: Add support for Exynos4x12 SoCs"

 arch/arm/boot/dts/Makefile                |    1 +
 arch/arm/boot/dts/exynos4412-smdk4412.dts |   45
+++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos4412-smdk4412.dts
arch/arm/boot/dts/Makefile +1 -0
index f37cf9f..36488a5 100644
@@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_DOVE) += dove-cm-a510.dtb \
 dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
      exynos4210-smdkv310.dtb \
      exynos4210-trats.dtb \
+     exynos4412-smdk4412.dtb \
      exynos5250-smdk5250.dtb
 dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb
 dtb-$(CONFIG_ARCH_INTEGRATOR) += integratorap.dtb \
arch/arm/boot/dts/exynos4412-smdk4412.dts new file +27 -0
new file mode 100644
index 0000000..f05bf57
@@ -0,0 +1,45 @@
+/*
+ * Samsung's Exynos4412 based SMDK board device tree source
+ *
+ * Copyright (c) 2012-2013 Samsung Electronics Co., Ltd.
+ *           http://www.samsung.com
+ *
+ * Device tree source file for Samsung's SMDK4412 board which is based on
+ * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+/dts-v1/;
+/include/ "exynos4412.dtsi"
+
+/ {
+     model = "Samsung SMDK evaluation board based on Exynos4412";
+     compatible = "samsung,smdk4412", "samsung,exynos4412";
+
+     memory {
+             reg = <0x40000000 0x40000000>;
+     };
+
+     chosen {
+             bootargs ="root=/dev/ram0 rw ramdisk=8192

initrd=0x41000000,8M console=ttySAC1,115200 init=/linuxrc";

arch/arm/boot/dts/exynos4412-smdk4412.dts new file +18 -1
+     };
+
+     serial at 13800000 {
+             status = "okay";
+     };
+
+     serial at 13810000 {
+             status = "okay";
+     };
+
+     serial at 13820000 {
+             status = "okay";
+     };
+
+     serial at 13830000 {
+             status = "okay";
+     };
+};
--
Quoted 1 line

1.6.6.rc2

Looks good to me, will apply.

Quoted 1 line

BTW, its default console is ttySAC1 not ttySAC2?

Thanks Mr. Kim. There is support for both ttySAC1 and ttySAC2 as uart ports. There are corresponding switches on the board that have to be set. But the default setting is always to use ttySAC1.

Thanks,
Thomas.

#3 lore raw

PATCH 1/1 ARM: dts: add board dts file for Exynos4412 based SMDK board

In reply to Thomas Abraham

Hi Thomas,

Quoted 45 lines · On Saturday 03 of November 2012 20:19:32 Thomas Abraham wrote:

Add a minimal board dts file for Samsung Exynos4412 based SMDK board.

Signed-off-by Thomas Abraham <[email protected]>

---
This patch depends the on the following patch posted by Tomasz Figa. "ARM: dts: exynos4: Add support for Exynos4x12 SoCs"

 arch/arm/boot/dts/Makefile                |    1 +
 arch/arm/boot/dts/exynos4412-smdk4412.dts |   45
+++++++++++++++++++++++++++++ 2 files changed, 46 insertions(+), 0
deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos4412-smdk4412.dts
arch/arm/boot/dts/Makefile +1 -0
index f37cf9f..36488a5 100644
@@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_DOVE) += dove-cm-a510.dtb \
 dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
 	exynos4210-smdkv310.dtb \
 	exynos4210-trats.dtb \
+	exynos4412-smdk4412.dtb \
 	exynos5250-smdk5250.dtb
 dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb
 dtb-$(CONFIG_ARCH_INTEGRATOR) += integratorap.dtb \
(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos4412-smdk4412.dts new file mode 100644 index 0000000..f05bf57

arch/arm/boot/dts/exynos4412-smdk4412.dts new file +7 -0
@@ -0,0 +1,45 @@
+/*
+ * Samsung's Exynos4412 based SMDK board device tree source
+ *
+ * Copyright (c) 2012-2013 Samsung Electronics Co., Ltd.
+ *		http://www.samsung.com
+ *
+ * Device tree source file for Samsung's SMDK4412 board which is based

on + * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as +
* published by the Free Software Foundation.

arch/arm/boot/dts/exynos4412-smdk4412.dts new file +2 -0
+*/
+

arch/arm/boot/dts/exynos4412-smdk4412.dts line 24

Quoted 10 lines
arch/arm/boot/dts/exynos4412-smdk4412.dts new file +10 -0
+/dts-v1/;
+/include/ "exynos4412.dtsi"
+
+/ {
+	model = "Samsung SMDK evaluation board based on Exynos4412";
+	compatible = "samsung,smdk4412", "samsung,exynos4412";
+
+	memory {
+		reg = <0x40000000 0x40000000>;
+	};

This will not boot, because section size limit is set to 256 MiB.

It might work with CONFIG_ARM_ATAG_DTB_COMPAT enabled, because the memory configuration from DT is ignored and values from ATAGs are taken instead.

I suggest you to change it to 4 banks of 256 MiB.

Quoted 10 lines
arch/arm/boot/dts/exynos4412-smdk4412.dts new file +2 -0
+	chosen {
+		bootargs ="root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M

console=ttySAC1,115200 init=/linuxrc"; + };

arch/arm/boot/dts/exynos4412-smdk4412.dts new file +7 -0
+
+	serial at 13800000 {
+		status = "okay";
+	};
+
+	serial at 13810000 {
+		status = "okay";

arch/arm/boot/dts/exynos4412-smdk4412.dts line 45

Quoted 10 lines
arch/arm/boot/dts/exynos4412-smdk4412.dts new file +10 -0
+	};
+
+	serial at 13820000 {
+		status = "okay";
+	};
+
+	serial at 13830000 {
+		status = "okay";
+	};
+};

Otherwise looks fine.

Best regards,

Signature · 3 lines
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform
author
#4 lore raw

PATCH 1/1 ARM: dts: add board dts file for Exynos4412 based SMDK board

Hi Tomasz,

Thanks for your comments.

Quoted 61 lines · Tomasz Figa

Hi Thomas,

Quoted 45 lines · On Saturday 03 of November 2012 20:19:32 Thomas Abraham wrote:

Add a minimal board dts file for Samsung Exynos4412 based SMDK board.

Signed-off-by Thomas Abraham <[email protected]>

---
This patch depends the on the following patch posted by Tomasz Figa. "ARM: dts: exynos4: Add support for Exynos4x12 SoCs"

 arch/arm/boot/dts/Makefile                |    1 +
 arch/arm/boot/dts/exynos4412-smdk4412.dts |   45
+++++++++++++++++++++++++++++ 2 files changed, 46 insertions(+), 0
deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos4412-smdk4412.dts
arch/arm/boot/dts/Makefile +1 -0
index f37cf9f..36488a5 100644
@@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_DOVE) += dove-cm-a510.dtb \
 dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
      exynos4210-smdkv310.dtb \
      exynos4210-trats.dtb \
+     exynos4412-smdk4412.dtb \
      exynos5250-smdk5250.dtb
 dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb
 dtb-$(CONFIG_ARCH_INTEGRATOR) += integratorap.dtb \
(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos4412-smdk4412.dts new file mode 100644 index 0000000..f05bf57

arch/arm/boot/dts/exynos4412-smdk4412.dts new file +7 -0
@@ -0,0 +1,45 @@
+/*
+ * Samsung's Exynos4412 based SMDK board device tree source
+ *
+ * Copyright (c) 2012-2013 Samsung Electronics Co., Ltd.
+ *           http://www.samsung.com
+ *
+ * Device tree source file for Samsung's SMDK4412 board which is based

on + * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as +
* published by the Free Software Foundation.

arch/arm/boot/dts/exynos4412-smdk4412.dts new file +2 -0
+*/
+

arch/arm/boot/dts/exynos4412-smdk4412.dts line 24

Quoted 10 lines
arch/arm/boot/dts/exynos4412-smdk4412.dts new file +10 -0
+/dts-v1/;
+/include/ "exynos4412.dtsi"
+
+/ {
+     model = "Samsung SMDK evaluation board based on Exynos4412";
+     compatible = "samsung,smdk4412", "samsung,exynos4412";
+
+     memory {
+             reg = <0x40000000 0x40000000>;
+     };

This will not boot, because section size limit is set to 256 MiB.

Quoted 4 lines

It might work with CONFIG_ARM_ATAG_DTB_COMPAT enabled, because the memory configuration from DT is ignored and values from ATAGs are taken instead.

I suggest you to change it to 4 banks of 256 MiB.

Thanks for pointing this out. So are there any existing exynos based platforms that use sparse mem? If not, we should probably remove the section length configuration itself for mach-exynos. I suspect this setting might not help with the single kernel image support as well.

Thanks,
Thomas.

Quoted 30 lines
Quoted 11 lines
arch/arm/boot/dts/exynos4412-smdk4412.dts new file +2 -0
+     chosen {
+             bootargs ="root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M

console=ttySAC1,115200 init=/linuxrc"; + };

arch/arm/boot/dts/exynos4412-smdk4412.dts new file +7 -0
+
+     serial at 13800000 {
+             status = "okay";
+     };
+
+     serial at 13810000 {
+             status = "okay";

arch/arm/boot/dts/exynos4412-smdk4412.dts line 45

Quoted 10 lines
arch/arm/boot/dts/exynos4412-smdk4412.dts new file +10 -0
+     };
+
+     serial at 13820000 {
+             status = "okay";
+     };
+
+     serial at 13830000 {
+             status = "okay";
+     };
+};

Otherwise looks fine.

Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform

#5 lore raw

PATCH 1/1 ARM: dts: add board dts file for Exynos4412 based SMDK board

Quoted 79 lines · On Thursday 15 of November 2012 13:48:55 Thomas Abraham wrote:

Hi Tomasz,

Thanks for your comments.

Quoted 74 lines · Tomasz Figa

Hi Thomas,

Quoted 54 lines · On Saturday 03 of November 2012 20:19:32 Thomas Abraham wrote:

Add a minimal board dts file for Samsung Exynos4412 based SMDK board.

Signed-off-by Thomas Abraham <[email protected]>

---
This patch depends the on the following patch posted by Tomasz Figa. "ARM: dts: exynos4: Add support for Exynos4x12 SoCs"

 arch/arm/boot/dts/Makefile                |    1 +
 arch/arm/boot/dts/exynos4412-smdk4412.dts |   45

+++++++++++++++++++++++++++++ 2 files changed, 46 insertions(+), 0 deletions(-)

 create mode 100644 arch/arm/boot/dts/exynos4412-smdk4412.dts
arch/arm/boot/dts/Makefile +1 -0
index f37cf9f..36488a5 100644
@@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_DOVE) += dove-cm-a510.dtb \
 
 dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
 
      exynos4210-smdkv310.dtb \
      exynos4210-trats.dtb \
 
+     exynos4412-smdk4412.dtb \

      exynos5250-smdk5250.dtb

dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb dtb-$(CONFIG_ARCH_INTEGRATOR) += integratorap.dtb \

(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos4412-smdk4412.dts new file mode 100644 index 0000000..f05bf57

arch/arm/boot/dts/exynos4412-smdk4412.dts new file +7 -0
@@ -0,0 +1,45 @@
+/*
+ * Samsung's Exynos4412 based SMDK board device tree source
+ *
+ * Copyright (c) 2012-2013 Samsung Electronics Co., Ltd.
+ *           http://www.samsung.com
+ *
+ * Device tree source file for Samsung's SMDK4412 board which is

based
on + * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation.

arch/arm/boot/dts/exynos4412-smdk4412.dts new file +2 -0
+*/
+

arch/arm/boot/dts/exynos4412-smdk4412.dts line 24

Quoted 10 lines
arch/arm/boot/dts/exynos4412-smdk4412.dts new file +10 -0
+/dts-v1/;
+/include/ "exynos4412.dtsi"
+
+/ {
+     model = "Samsung SMDK evaluation board based on Exynos4412";
+     compatible = "samsung,smdk4412", "samsung,exynos4412";
+
+     memory {
+             reg = <0x40000000 0x40000000>;
+     };

This will not boot, because section size limit is set to 256 MiB.

It might work with CONFIG_ARM_ATAG_DTB_COMPAT enabled, because the memory configuration from DT is ignored and values from ATAGs are taken instead.

Quoted 6 lines
Quoted 1 line

I suggest you to change it to 4 banks of 256 MiB.

Thanks for pointing this out. So are there any existing exynos based platforms that use sparse mem? If not, we should probably remove the section length configuration itself for mach-exynos. I suspect this setting might not help with the single kernel image support as well.

Isn't sparse memory the only configuration available for ARCH_EXYNOS?

Best regards,

Signature · 3 lines
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform
author
#6 lore raw

PATCH 1/1 ARM: dts: add board dts file for Exynos4412 based SMDK board

Quoted 80 lines · Tomasz Figa
Quoted 79 lines · On Thursday 15 of November 2012 13:48:55 Thomas Abraham wrote:

Hi Tomasz,

Thanks for your comments.

Quoted 74 lines · Tomasz Figa

Hi Thomas,

Quoted 54 lines · On Saturday 03 of November 2012 20:19:32 Thomas Abraham wrote:

Add a minimal board dts file for Samsung Exynos4412 based SMDK board.

Signed-off-by Thomas Abraham <[email protected]>

---
This patch depends the on the following patch posted by Tomasz Figa. "ARM: dts: exynos4: Add support for Exynos4x12 SoCs"

 arch/arm/boot/dts/Makefile                |    1 +
 arch/arm/boot/dts/exynos4412-smdk4412.dts |   45

+++++++++++++++++++++++++++++ 2 files changed, 46 insertions(+), 0 deletions(-)

 create mode 100644 arch/arm/boot/dts/exynos4412-smdk4412.dts
arch/arm/boot/dts/Makefile +1 -0
index f37cf9f..36488a5 100644
@@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_DOVE) += dove-cm-a510.dtb \
 
 dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
 
      exynos4210-smdkv310.dtb \
      exynos4210-trats.dtb \
 
+     exynos4412-smdk4412.dtb \

      exynos5250-smdk5250.dtb

dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb dtb-$(CONFIG_ARCH_INTEGRATOR) += integratorap.dtb \

(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos4412-smdk4412.dts new file mode 100644 index 0000000..f05bf57

arch/arm/boot/dts/exynos4412-smdk4412.dts new file +7 -0
@@ -0,0 +1,45 @@
+/*
+ * Samsung's Exynos4412 based SMDK board device tree source
+ *
+ * Copyright (c) 2012-2013 Samsung Electronics Co., Ltd.
+ *           http://www.samsung.com
+ *
+ * Device tree source file for Samsung's SMDK4412 board which is

based
on + * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation.

arch/arm/boot/dts/exynos4412-smdk4412.dts new file +2 -0
+*/
+

arch/arm/boot/dts/exynos4412-smdk4412.dts line 24

Quoted 10 lines
arch/arm/boot/dts/exynos4412-smdk4412.dts new file +10 -0
+/dts-v1/;
+/include/ "exynos4412.dtsi"
+
+/ {
+     model = "Samsung SMDK evaluation board based on Exynos4412";
+     compatible = "samsung,smdk4412", "samsung,exynos4412";
+
+     memory {
+             reg = <0x40000000 0x40000000>;
+     };

This will not boot, because section size limit is set to 256 MiB.

It might work with CONFIG_ARM_ATAG_DTB_COMPAT enabled, because the memory configuration from DT is ignored and values from ATAGs are taken instead.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

I suggest you to change it to 4 banks of 256 MiB.

Thanks for pointing this out. So are there any existing exynos based platforms that use sparse mem? If not, we should probably remove the section length configuration itself for mach-exynos. I suspect this setting might not help with the single kernel image support as well.

Isn't sparse memory the only configuration available for ARCH_EXYNOS?

Yes, true. Since sparsemem is choosen as default for Exynos, flatmem option is not available. Theoretically, sparsemem could be used on Exynos platforms, but if all existing exynos4/5 based boards have no holes in memory, then why not use flatmem instead? If there are performance benefits of using flatmem over sparesmem on systems without any memory holes, then it is a compelling reason to stop using sparsemem on Exynos. But then, what if there is a new Exynos4/5 based board that comes up and that has a memory hole? Or, how about removing sparsemem as default option for ARCH_EXYNOS and enabling sparsemem for boards that need it.

Thanks,
Thomas.

Quoted 7 lines

Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform

#7 lore raw

PATCH 1/1 ARM: dts: add board dts file for Exynos4412 based SMDK board

Quoted 93 lines · On Friday 16 of November 2012 18:03:15 Thomas Abraham wrote:
Quoted 83 lines · Tomasz Figa
Quoted 82 lines · On Thursday 15 of November 2012 13:48:55 Thomas Abraham wrote:

Hi Tomasz,

Thanks for your comments.

Quoted 77 lines · Tomasz Figa

Hi Thomas,

Quoted 57 lines · On Saturday 03 of November 2012 20:19:32 Thomas Abraham wrote:

Add a minimal board dts file for Samsung Exynos4412 based SMDK board.

Signed-off-by Thomas Abraham <[email protected]>

---
This patch depends the on the following patch posted by Tomasz Figa.
"ARM: dts: exynos4: Add support for Exynos4x12 SoCs"

 arch/arm/boot/dts/Makefile                |    1 +
 arch/arm/boot/dts/exynos4412-smdk4412.dts |   45

+++++++++++++++++++++++++++++ 2 files changed, 46 insertions(+), 0 deletions(-)

 create mode 100644 arch/arm/boot/dts/exynos4412-smdk4412.dts
arch/arm/boot/dts/Makefile +1 -0
index f37cf9f..36488a5 100644
@@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_DOVE) += dove-cm-a510.dtb \
 
 dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
 
      exynos4210-smdkv310.dtb \
      exynos4210-trats.dtb \
 
+     exynos4412-smdk4412.dtb \

      exynos5250-smdk5250.dtb

dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb dtb-$(CONFIG_ARCH_INTEGRATOR) += integratorap.dtb \

(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos4412-smdk4412.dts new file mode 100644 index 0000000..f05bf57

arch/arm/boot/dts/exynos4412-smdk4412.dts new file +7 -0
@@ -0,0 +1,45 @@
+/*
+ * Samsung's Exynos4412 based SMDK board device tree source
+ *
+ * Copyright (c) 2012-2013 Samsung Electronics Co., Ltd.
+ *           http://www.samsung.com
+ *
+ * Device tree source file for Samsung's SMDK4412 board which is

based
on + * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation.

arch/arm/boot/dts/exynos4412-smdk4412.dts new file +2 -0
+*/
+

arch/arm/boot/dts/exynos4412-smdk4412.dts line 24

Quoted 10 lines
arch/arm/boot/dts/exynos4412-smdk4412.dts new file +10 -0
+/dts-v1/;
+/include/ "exynos4412.dtsi"
+
+/ {
+     model = "Samsung SMDK evaluation board based on Exynos4412";
+     compatible = "samsung,smdk4412", "samsung,exynos4412";
+
+     memory {
+             reg = <0x40000000 0x40000000>;
+     };

This will not boot, because section size limit is set to 256 MiB.

It might work with CONFIG_ARM_ATAG_DTB_COMPAT enabled, because the memory configuration from DT is ignored and values from ATAGs are taken instead.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

I suggest you to change it to 4 banks of 256 MiB.

Thanks for pointing this out. So are there any existing exynos based platforms that use sparse mem? If not, we should probably remove the section length configuration itself for mach-exynos. I suspect this setting might not help with the single kernel image support as well.

Isn't sparse memory the only configuration available for ARCH_EXYNOS?

Quoted 10 lines

Yes, true. Since sparsemem is choosen as default for Exynos, flatmem option is not available. Theoretically, sparsemem could be used on Exynos platforms, but if all existing exynos4/5 based boards have no holes in memory, then why not use flatmem instead? If there are performance benefits of using flatmem over sparesmem on systems without any memory holes, then it is a compelling reason to stop using sparsemem on Exynos. But then, what if there is a new Exynos4/5 based board that comes up and that has a memory hole? Or, how about removing sparsemem as default option for ARCH_EXYNOS and enabling sparsemem for boards that need it.

I'm not sure about any significant performance benefits of FLATMEM over SPARSEMEM. Some ancient benchmark from 2007 shows that overhead level of both is similar.

You can find the benchmark here:
http://lkml.indiana.edu/hypermail/linux/kernel/0711.1/1239.html

I think we should leave it as is for the time being and just make sure that sections of boards are defined according to section size limit.

Best regards,

Signature · 3 lines
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform
author
#8 lore raw

PATCH 1/1 ARM: dts: add board dts file for Exynos4412 based SMDK board

Quoted 109 lines · Tomasz Figa
Quoted 93 lines · On Friday 16 of November 2012 18:03:15 Thomas Abraham wrote:
Quoted 83 lines · Tomasz Figa
Quoted 82 lines · On Thursday 15 of November 2012 13:48:55 Thomas Abraham wrote:

Hi Tomasz,

Thanks for your comments.

Quoted 77 lines · Tomasz Figa

Hi Thomas,

Quoted 57 lines · On Saturday 03 of November 2012 20:19:32 Thomas Abraham wrote:

Add a minimal board dts file for Samsung Exynos4412 based SMDK board.

Signed-off-by Thomas Abraham <[email protected]>

---
This patch depends the on the following patch posted by Tomasz Figa.
"ARM: dts: exynos4: Add support for Exynos4x12 SoCs"

 arch/arm/boot/dts/Makefile                |    1 +
 arch/arm/boot/dts/exynos4412-smdk4412.dts |   45

+++++++++++++++++++++++++++++ 2 files changed, 46 insertions(+), 0 deletions(-)

 create mode 100644 arch/arm/boot/dts/exynos4412-smdk4412.dts
arch/arm/boot/dts/Makefile +1 -0
index f37cf9f..36488a5 100644
@@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_DOVE) += dove-cm-a510.dtb \
 
 dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
 
      exynos4210-smdkv310.dtb \
      exynos4210-trats.dtb \
 
+     exynos4412-smdk4412.dtb \

      exynos5250-smdk5250.dtb

dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb dtb-$(CONFIG_ARCH_INTEGRATOR) += integratorap.dtb \

(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos4412-smdk4412.dts new file mode 100644 index 0000000..f05bf57

arch/arm/boot/dts/exynos4412-smdk4412.dts new file +7 -0
@@ -0,0 +1,45 @@
+/*
+ * Samsung's Exynos4412 based SMDK board device tree source
+ *
+ * Copyright (c) 2012-2013 Samsung Electronics Co., Ltd.
+ *           http://www.samsung.com
+ *
+ * Device tree source file for Samsung's SMDK4412 board which is

based
on + * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation.

arch/arm/boot/dts/exynos4412-smdk4412.dts new file +2 -0
+*/
+

arch/arm/boot/dts/exynos4412-smdk4412.dts line 24

Quoted 10 lines
arch/arm/boot/dts/exynos4412-smdk4412.dts new file +10 -0
+/dts-v1/;
+/include/ "exynos4412.dtsi"
+
+/ {
+     model = "Samsung SMDK evaluation board based on Exynos4412";
+     compatible = "samsung,smdk4412", "samsung,exynos4412";
+
+     memory {
+             reg = <0x40000000 0x40000000>;
+     };

This will not boot, because section size limit is set to 256 MiB.

It might work with CONFIG_ARM_ATAG_DTB_COMPAT enabled, because the memory configuration from DT is ignored and values from ATAGs are taken instead.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

I suggest you to change it to 4 banks of 256 MiB.

Thanks for pointing this out. So are there any existing exynos based platforms that use sparse mem? If not, we should probably remove the section length configuration itself for mach-exynos. I suspect this setting might not help with the single kernel image support as well.

Isn't sparse memory the only configuration available for ARCH_EXYNOS?

Quoted 10 lines

Yes, true. Since sparsemem is choosen as default for Exynos, flatmem option is not available. Theoretically, sparsemem could be used on Exynos platforms, but if all existing exynos4/5 based boards have no holes in memory, then why not use flatmem instead? If there are performance benefits of using flatmem over sparesmem on systems without any memory holes, then it is a compelling reason to stop using sparsemem on Exynos. But then, what if there is a new Exynos4/5 based board that comes up and that has a memory hole? Or, how about removing sparsemem as default option for ARCH_EXYNOS and enabling sparsemem for boards that need it.

I'm not sure about any significant performance benefits of FLATMEM over SPARSEMEM. Some ancient benchmark from 2007 shows that overhead level of both is similar.

Quoted 5 lines

You can find the benchmark here:
http://lkml.indiana.edu/hypermail/linux/kernel/0711.1/1239.html

I think we should leave it as is for the time being and just make sure that sections of boards are defined according to section size limit.

Ok, makes sense. Thanks. By the way, I was checking why this patch did not lead me to a crash as you described. u-boot seems to be overriding the memory node in the dts file and creating a new memory node with the memory banks information that u-boot has. So looking at /proc/device-tree/memory/reg, there are multiple 256MB sized entries there.

Regards,
Thomas.

#9 lore raw

PATCH 1/1 ARM: dts: add board dts file for Exynos4412 based SMDK board

Quoted 126 lines · On Friday 16 of November 2012 18:47:54 Thomas Abraham wrote:
Quoted 119 lines · Tomasz Figa
Quoted 102 lines · On Friday 16 of November 2012 18:03:15 Thomas Abraham wrote:
Quoted 98 lines · Tomasz Figa
Quoted 89 lines · On Thursday 15 of November 2012 13:48:55 Thomas Abraham wrote:

Hi Tomasz,

Thanks for your comments.

Quoted 77 lines · Tomasz Figa

Hi Thomas,

Quoted 66 lines · On Saturday 03 of November 2012 20:19:32 Thomas Abraham wrote:

Add a minimal board dts file for Samsung Exynos4412 based SMDK board.

Signed-off-by Thomas Abraham <[email protected]>

---
This patch depends the on the following patch posted by Tomasz Figa.
"ARM: dts: exynos4: Add support for Exynos4x12 SoCs"

 arch/arm/boot/dts/Makefile                |    1 +
 arch/arm/boot/dts/exynos4412-smdk4412.dts |   45

+++++++++++++++++++++++++++++ 2 files changed, 46 insertions(+), 0
deletions(-)

 create mode 100644 arch/arm/boot/dts/exynos4412-smdk4412.dts
arch/arm/boot/dts/Makefile +1 -0
index f37cf9f..36488a5 100644
@@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_DOVE) += dove-cm-a510.dtb \
 
 dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
 
      exynos4210-smdkv310.dtb \
      exynos4210-trats.dtb \
 
+     exynos4412-smdk4412.dtb \

      exynos5250-smdk5250.dtb

dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb dtb-$(CONFIG_ARCH_INTEGRATOR) += integratorap.dtb \

(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos4412-smdk4412.dts new file mode 100644 index 0000000..f05bf57

arch/arm/boot/dts/exynos4412-smdk4412.dts new file +7 -0
@@ -0,0 +1,45 @@
+/*
+ * Samsung's Exynos4412 based SMDK board device tree source
+ *
+ * Copyright (c) 2012-2013 Samsung Electronics Co., Ltd.
+ *           http://www.samsung.com
+ *
+ * Device tree source file for Samsung's SMDK4412 board which

is
based
on + * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or
modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation.

arch/arm/boot/dts/exynos4412-smdk4412.dts new file +7 -0
+*/
+
+/dts-v1/;
+/include/ "exynos4412.dtsi"
+
+/ {
+     model = "Samsung SMDK evaluation board based on

Exynos4412";

arch/arm/boot/dts/exynos4412-smdk4412.dts

Quoted 5 lines
arch/arm/boot/dts/exynos4412-smdk4412.dts new file +5 -0
+     compatible = "samsung,smdk4412", "samsung,exynos4412";
+
+     memory {
+             reg = <0x40000000 0x40000000>;
+     };

This will not boot, because section size limit is set to 256 MiB.

Quoted 6 lines

It might work with CONFIG_ARM_ATAG_DTB_COMPAT enabled, because the
memory configuration from DT is ignored and values from ATAGs are taken instead.

I suggest you to change it to 4 banks of 256 MiB.

Quoted 7 lines

Thanks for pointing this out. So are there any existing exynos based
platforms that use sparse mem? If not, we should probably remove the
section length configuration itself for mach-exynos. I suspect this setting might not help with the single kernel image support as well.

Quoted 2 lines

Isn't sparse memory the only configuration available for ARCH_EXYNOS?

Quoted 10 lines

Yes, true. Since sparsemem is choosen as default for Exynos, flatmem option is not available. Theoretically, sparsemem could be used on Exynos platforms, but if all existing exynos4/5 based boards have no holes in memory, then why not use flatmem instead? If there are performance benefits of using flatmem over sparesmem on systems without any memory holes, then it is a compelling reason to stop using sparsemem on Exynos. But then, what if there is a new Exynos4/5 based board that comes up and that has a memory hole? Or, how about removing sparsemem as default option for ARCH_EXYNOS and enabling sparsemem for boards that need it.

I'm not sure about any significant performance benefits of FLATMEM over SPARSEMEM. Some ancient benchmark from 2007 shows that overhead level of
both is similar.

Quoted 5 lines

You can find the benchmark here:
http://lkml.indiana.edu/hypermail/linux/kernel/0711.1/1239.html

I think we should leave it as is for the time being and just make sure that sections of boards are defined according to section size limit.

Quoted 6 lines

Ok, makes sense. Thanks. By the way, I was checking why this patch did not lead me to a crash as you described. u-boot seems to be overriding the memory node in the dts file and creating a new memory node with the memory banks information that u-boot has. So looking at /proc/device-tree/memory/reg, there are multiple 256MB sized entries there.

OK, it seems like you are using a DT-aware u-boot. It can generate memory and chosen nodes, so I guess the behavior you observe is fine.

I'm testing on a legacy u-boot version without DT support, so all the information must be included in the appended DTB and so I observed boot crashes with too big sections.

Btw. It seems like Kgene has already applied your patch, so let's send a separate fixup patch. It can be considered a fix so there shouldn't be any problems with merging it. Should I send it or you will do it?

Best regards,
Tomasz Figa