Skip to contentSkip to conversation

fs: jfs: Replace CURRENT_TIME_SEC by current_time()

PATCH RESEND In review Deepa Dinamani 2 participants 3 messages Nov 11, 2016 JFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 fs: jfs: Replace CURRENT_TIME_SEC by current_time()

jfs uses nanosecond granularity for filesystem timestamps. Only this assignment is not using nanosecond granularity. Use current_time() to get the right granularity.

---
 fs/jfs/ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/jfs/ioctl.c +1 -1
index 8653cac..b6fd1ff 100644
@@ -121,7 +121,7 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 
 		jfs_set_inode_flags(inode);
 		inode_unlock(inode);
-		inode->i_ctime = CURRENT_TIME_SEC;
+		inode->i_ctime = current_time(inode);
 		mark_inode_dirty(inode);
 setflags_out:
 		mnt_drop_write_file(filp);
Signature · 1 line
2.7.4
#1 lore raw
Quoted 3 lines · Deepa Dinamani

jfs uses nanosecond granularity for filesystem timestamps. Only this assignment is not using nanosecond granularity. Use current_time() to get the right granularity.

I had thought these were being handled as a group. I'll push this one through the jfs tree.

Thanks,
Shaggy

Quoted 22 lines
---
 fs/jfs/ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/jfs/ioctl.c +1 -1
index 8653cac..b6fd1ff 100644
@@ -121,7 +121,7 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 
 		jfs_set_inode_flags(inode);
 		inode_unlock(inode);
-		inode->i_ctime = CURRENT_TIME_SEC;
+		inode->i_ctime = current_time(inode);
 		mark_inode_dirty(inode);
 setflags_out:
 		mnt_drop_write_file(filp);
#2 lore raw
Quoted 7 lines · Dave Kleikamp
Quoted 3 lines · Deepa Dinamani

jfs uses nanosecond granularity for filesystem timestamps. Only this assignment is not using nanosecond granularity. Use current_time() to get the right granularity.

I had thought these were being handled as a group. I'll push this one through the jfs tree.

Yes, that was the original plan.
Then, Greg suggested pushing only the big patches as a group and sending individual filesystem patches separately.
Big patches introducing current_time() have been merged in 4.9 rc1.

-Deepa