Skip to contentSkip to conversation

sunxi: Mele_M5_defconfig: Drop non existing STATUSLED setting

PATCH New Hans de Goede 3 participants 5 messages Nov 13, 2016 – Nov 21, 2016

lore
Share & tools
lore

Hans de Goede

author
#0 lore raw

PATCH 1/1 sunxi: Mele_M5_defconfig: Drop non existing STATUSLED setting

And also remove it from scripts/config_whitelist.txt as the Mele_M5_defconfig was the only one defining it.

Signed-off-by Hans de Goede <[email protected]>
---
 configs/Mele_M5_defconfig    | 2 +-
 scripts/config_whitelist.txt | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
configs/Mele_M5_defconfig +1 -1
index fffc332..09addc5 100644
@@ -9,7 +9,7 @@ CONFIG_VIDEO_COMPOSITE=y
 CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-m5"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_AHCI=y
-CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,STATUSLED=234"
+CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC"
 CONFIG_SPL=y
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
scripts/config_whitelist.txt +0 -1
index d476367..5a471fe 100644
@@ -4329,7 +4329,6 @@ CONFIG_STAMP_CF
 CONFIG_STANDALONE_LOAD_ADDR
 CONFIG_STATIC_BOARD_REV
 CONFIG_STATIC_RELA
-CONFIG_STATUSLED
 CONFIG_STATUS_LED
 CONFIG_STD_DEVICES_SETTINGS
 CONFIG_STK52XX
Signature · 1 line
2.9.3
#2 lore raw

PATCH 1/1 sunxi: Mele_M5_defconfig: Drop non existing STATUSLED setting

In reply to Hans de Goede
Quoted 14 lines · Hans de Goede

And also remove it from scripts/config_whitelist.txt as the Mele_M5_defconfig was the only one defining it.

Signed-off-by Hans de Goede <[email protected]>
---
 configs/Mele_M5_defconfig    | 2 +-
 scripts/config_whitelist.txt | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
configs/Mele_M5_defconfig +0 -0
index fffc332..09addc5 100644

configs/Mele_M5_defconfig CONFIG_VIDEO_COMPOSITE=y · line 12

Quoted 4 lines
configs/Mele_M5_defconfig +0 -1
@@ -9,7 +9,7 @@ CONFIG_VIDEO_COMPOSITE=y
 CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-m5"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_AHCI=y
-CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,STATUSLED=234"

Still exist in boards.cfg?

thanks!

Signature · 4 lines
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
author
#3 lore raw

PATCH 1/1 sunxi: Mele_M5_defconfig: Drop non existing STATUSLED setting

Hi,

Quoted 10 lines · Jagan Teki
Quoted 9 lines · Hans de Goede

And also remove it from scripts/config_whitelist.txt as the Mele_M5_defconfig was the only one defining it.

Signed-off-by Hans de Goede <[email protected]>
---
 configs/Mele_M5_defconfig    | 2 +-
 scripts/config_whitelist.txt | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
Quoted 11 lines

configs/Mele_M5_defconfig CONFIG_VIDEO_COMPOSITE=y · line 12

Quoted 9 lines
configs/Mele_M5_defconfig +0 -1
index fffc332..09addc5 100644
@@ -9,7 +9,7 @@ CONFIG_VIDEO_COMPOSITE=y
 CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-m5"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_AHCI=y
-CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,STATUSLED=234"

Still exist in boards.cfg?

boards.cfg is generated for backward-compat with some scripts now a days, it is not part of the git repo.

Regards,

Hans

#4 lore raw

PATCH 1/1 sunxi: Mele_M5_defconfig: Drop non existing STATUSLED setting

Quoted 30 lines · Hans de Goede

Hi,

Quoted 13 lines · Jagan Teki
Quoted 10 lines · Hans de Goede

And also remove it from scripts/config_whitelist.txt as the Mele_M5_defconfig was the only one defining it.

Signed-off-by Hans de Goede <[email protected]>
---
 configs/Mele_M5_defconfig    | 2 +-
 scripts/config_whitelist.txt | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
Quoted 12 lines

configs/Mele_M5_defconfig CONFIG_VIDEO_COMPOSITE=y · line 12

Quoted 9 lines
configs/Mele_M5_defconfig +0 -1
index fffc332..09addc5 100644
@@ -9,7 +9,7 @@ CONFIG_VIDEO_COMPOSITE=y
 CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-m5"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_AHCI=y
-CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,STATUSLED=234"

Still exist in boards.cfg?

Quoted 2 lines

boards.cfg is generated for backward-compat with some scripts now a days, it is not part of the git repo.

OK, thought the same.

Reviewed-by Jagan Teki <[email protected]>

thanks!

Signature · 4 lines
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.