drivers: dma: ti: k3-udma: Extract packet data only when Meta data is not NULL
Subsystems (2)
PATCH 1/1 drivers: dma: ti: k3-udma: Extract packet data only when Meta data is not NULL
Currently packet data is wrongly extracted when metadata is NULL. Fix it and negate the if check.
--- drivers/dma/ti/k3-udma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/ti/k3-udma.c +1 -1
@@ -1492,7 +1492,7 @@ static int udma_send(struct dma *dma, void *src, size_t len, void *metadata)u32 tc_ring_id;int ret; -if (!metadata) +if (metadata) packet_data = *((struct ti_udma_drv_packet_data *)metadata);if (dma->id >= (ud->rchan_cnt + ud->tchan_cnt)) {
Signature · 1 line
2.17.1
PATCH 1/1 drivers: dma: ti: k3-udma: Extract packet data only when Meta data is not NULL
Quoted 2 lines · Keerthy
Currently packet data is wrongly extracted when metadata is NULL. Fix it and negate the if check.
Good catch.
Quoted 13 lines
Signed-off-by Keerthy <[email protected]>Reviewed-by Grygorii Strashko <[email protected]>--- drivers/dma/ti/k3-udma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/dma/ti/k3-udma.c +0
-0
drivers/dma/ti/k3-udma.c static int udma_send(struct dma *dma, void *src, size_t len, void *metadata) · line 1498
Quoted 8 lines
drivers/dma/ti/k3-udma.c +1
-1@@ -1492,7 +1492,7 @@ static int udma_send(struct dma *dma, void *src, size_t len, void *metadata)u32 tc_ring_id;int ret; -if (!metadata) +if (metadata) packet_data = *((struct ti_udma_drv_packet_data *)metadata);if (dma->id >= (ud->rchan_cnt + ud->tchan_cnt)) {
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
PATCH 1/1 drivers: dma: ti: k3-udma: Extract packet data only when Meta data is not NULL
In reply to KeerthyQuoted 6 lines · Keerthy
Currently packet data is wrongly extracted when metadata is NULL. Fix it and negate the if check.
Signed-off-by Keerthy <[email protected]>Reviewed-by Grygorii Strashko <[email protected]>Reviewed-by Peter Ujfalusi <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190503/0b3cad2e/attachment.sig>