Skip to contentSkip to conversation

drm/amdgpu/sdma: fix typo in packet setup

PATCH In review Alex Deucher 3 participants 3 messages Nov 14, 2016 – Nov 15, 2016 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu/sdma: fix typo in packet setup

Use the correct define. No functional change as both defines are equivalent.

---
 drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 2 +-
 drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c +1 -1
index e81aa46..1b44d5b 100644
@@ -775,7 +775,7 @@ static void sdma_v2_4_vm_write_pte(struct amdgpu_ib *ib, uint64_t pe,
 	unsigned ndw = count * 2;
 
 	ib->ptr[ib->length_dw++] = SDMA_PKT_HEADER_OP(SDMA_OP_WRITE) |
-		SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_COPY_LINEAR);
+		SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_WRITE_LINEAR);
 	ib->ptr[ib->length_dw++] = pe;
 	ib->ptr[ib->length_dw++] = upper_32_bits(pe);
 	ib->ptr[ib->length_dw++] = ndw;
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c +1 -1
index 77f1465..9425c69 100644
@@ -977,7 +977,7 @@ static void sdma_v3_0_vm_write_pte(struct amdgpu_ib *ib, uint64_t pe,
 	unsigned ndw = count * 2;
 
 	ib->ptr[ib->length_dw++] = SDMA_PKT_HEADER_OP(SDMA_OP_WRITE) |
-		SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_COPY_LINEAR);
+		SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_WRITE_LINEAR);
 	ib->ptr[ib->length_dw++] = lower_32_bits(pe);
 	ib->ptr[ib->length_dw++] = upper_32_bits(pe);
 	ib->ptr[ib->length_dw++] = ndw;
Signature · 6 lines
2.5.5

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1479147215-2151-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org

Reviewed-by Chunming Zhou
#2 lore raw
Quoted 4 lines · Alex Deucher

Use the correct define. No functional change as both defines are equivalent.

Quoted 23 lines
---
  drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 2 +-
  drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c +1 -1
index e81aa46..1b44d5b 100644
@@ -775,7 +775,7 @@ static void sdma_v2_4_vm_write_pte(struct amdgpu_ib *ib, uint64_t pe,
  	unsigned ndw = count * 2;
 
  	ib->ptr[ib->length_dw++] = SDMA_PKT_HEADER_OP(SDMA_OP_WRITE) |
-		SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_COPY_LINEAR);
+		SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_WRITE_LINEAR);
  	ib->ptr[ib->length_dw++] = pe;
  	ib->ptr[ib->length_dw++] = upper_32_bits(pe);
  	ib->ptr[ib->length_dw++] = ndw;
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c +0 -0
index 77f1465..9425c69 100644

drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c static void sdma_v3_0_vm_write_pte(struct amdgpu_ib *ib, uint64_t pe, · line 983

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c +1 -1
@@ -977,7 +977,7 @@ static void sdma_v3_0_vm_write_pte(struct amdgpu_ib *ib, uint64_t pe,
  	unsigned ndw = count * 2;
 
  	ib->ptr[ib->length_dw++] = SDMA_PKT_HEADER_OP(SDMA_OP_WRITE) |
-		SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_COPY_LINEAR);
+		SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_WRITE_LINEAR);
  	ib->ptr[ib->length_dw++] = lower_32_bits(pe);
  	ib->ptr[ib->length_dw++] = upper_32_bits(pe);
  	ib->ptr[ib->length_dw++] = ndw;

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

Reviewed-by
#4 lore raw

Am 15.11.2016 um 02:55 schrieb zhoucm1:

Quoted 8 lines · Alex Deucher
Quoted 4 lines

Use the correct define. No functional change as both defines are equivalent.

Quoted 28 lines
Quoted 28 lines
---
  drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 2 +-
  drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c +1 -1
index e81aa46..1b44d5b 100644
@@ -775,7 +775,7 @@ static void sdma_v2_4_vm_write_pte(struct 
 amdgpu_ib *ib, uint64_t pe,
      unsigned ndw = count * 2;
        ib->ptr[ib->length_dw++] = SDMA_PKT_HEADER_OP(SDMA_OP_WRITE) |
-        SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_COPY_LINEAR);
+        SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_WRITE_LINEAR);
      ib->ptr[ib->length_dw++] = pe;
      ib->ptr[ib->length_dw++] = upper_32_bits(pe);
      ib->ptr[ib->length_dw++] = ndw;
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c +1 -1
index 77f1465..9425c69 100644
@@ -977,7 +977,7 @@ static void sdma_v3_0_vm_write_pte(struct 
 amdgpu_ib *ib, uint64_t pe,
      unsigned ndw = count * 2;
        ib->ptr[ib->length_dw++] = SDMA_PKT_HEADER_OP(SDMA_OP_WRITE) |
-        SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_COPY_LINEAR);
+        SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_WRITE_LINEAR);
Quoted 8 lines

drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c static void sdma_v3_0_vm_write_pte(struct amdgpu_ib *ib, uint64_t pe, · line 983

Quoted 3 lines
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c +0 -0
      ib->ptr[ib->length_dw++] = lower_32_bits(pe);
      ib->ptr[ib->length_dw++] = upper_32_bits(pe);
      ib->ptr[ib->length_dw++] = ndw;

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx