Skip to contentSkip to conversation

Patch "staging: nvec: remove managed resource from PS2 driver" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Nov 15, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

staging: nvec: remove managed resource from PS2 driver

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
staging-nvec-remove-managed-resource-from-ps2-driver.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 68fae2f3df455f53d0dfe33483a49020b3b758f3 Mon Sep 17 00:00:00 2001

From: Marc Dietrich <[email protected]>
Date: Tue, 1 Nov 2016 13:59:40 +0100
Subject: staging: nvec: remove managed resource from PS2 driver

From: Marc Dietrich <[email protected]>

commit 68fae2f3df455f53d0dfe33483a49020b3b758f3 upstream.

This basicly reverts commit e534f3e9 (staging:nvec: Introduce the use of the managed version of kzalloc). Serio struct should never by managed because it is refcounted. Doing so will lead to a double free oops on module remove.

Fixes e534f3e9429f ("staging:nvec: Introduce the use of the managed version of kzalloc")
---
 drivers/staging/nvec/nvec_ps2.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/nvec/nvec_ps2.c +1 -1
@@ -107,7 +107,7 @@ static int nvec_mouse_probe(struct platf
 	struct nvec_chip *nvec = dev_get_drvdata(pdev->dev.parent);
 	struct serio *ser_dev;
 
-	ser_dev = devm_kzalloc(&pdev->dev, sizeof(struct serio), GFP_KERNEL);
+	ser_dev = kzalloc(sizeof(struct serio), GFP_KERNEL);
 	if (!ser_dev)
 		return -ENOMEM;
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/revert-staging-nvec-ps2-change-serio-type-to-passthrough.patch queue-4.8/staging-nvec-remove-managed-resource-from-ps2-driver.patch queue-4.8/drivers-staging-nvec-remove-bogus-reset-command-for-ps-2-interface.patch