Skip to contentSkip to conversation

drm/i915/gvt: drop checks for early Skylake revisions

PATCH Applied Jani Nikula 4 participants 4 messages Nov 16, 2016 – Nov 17, 2016

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/gvt: drop checks for early Skylake revisions

We no longer cater for pre-production revisions of Skylake.

Fixes d4362225e8cb ("drm/i915/gvt: update misc ctl regs base on stepping info")
Cc Ping Gao <[email protected]>
Cc Zhenyu Wang <[email protected]>
Cc Zhi Wang <[email protected]>
---
 drivers/gpu/drm/i915/gvt/handlers.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/gvt/handlers.c +2 -4
index 1b3db0c7a6db..12cd9b2a415c 100644
@@ -1279,14 +1279,12 @@ static int skl_misc_ctl_write(struct intel_vgpu *vgpu, unsigned int offset,
 	case 0x4ddc:
 		vgpu_vreg(vgpu, offset) = 0x8000003c;
 		/* WaCompressedResourceSamplerPbeMediaNewHashMode:skl */
-		if (IS_SKL_REVID(dev_priv, SKL_REVID_C0, REVID_FOREVER))
-			I915_WRITE(reg, vgpu_vreg(vgpu, offset));
+		I915_WRITE(reg, vgpu_vreg(vgpu, offset));
 		break;
 	case 0x42080:
 		vgpu_vreg(vgpu, offset) = 0x8000;
 		/* WaCompressedResourceDisplayNewHashMode:skl */
-		if (IS_SKL_REVID(dev_priv, SKL_REVID_E0, REVID_FOREVER))
-			I915_WRITE(reg, vgpu_vreg(vgpu, offset));
+		I915_WRITE(reg, vgpu_vreg(vgpu, offset));
 		break;
 	default:
 		return -EINVAL;
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✓ Fi.CI.BAT: success for drm/i915/gvt: drop checks for early Skylake revisions

== Series Details ==

== Series Details ==

Series: drm/i915/gvt: drop checks for early Skylake revisions
URL : https://patchwork.freedesktop.org/series/15400/
State : success

== Summary ==

Series 15400v1 drm/i915/gvt: drop checks for early Skylake revisions
https://patchwork.freedesktop.org/api/1.0/series/15400/revisions/1/mbox/

fi-bdw-5557u     total:244  pass:229  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050     total:244  pass:204  dwarn:0   dfail:0   fail:0   skip:40 
fi-bxt-t5700     total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28 
fi-byt-j1900     total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28 
fi-byt-n2820     total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32 
fi-hsw-4770      total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20 
fi-hsw-4770r     total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20 
fi-ilk-650       total:244  pass:191  dwarn:0   dfail:0   fail:0   skip:53 
fi-ivb-3520m     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-ivb-3770      total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-kbl-7200u     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-skl-6260u     total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14 
fi-skl-6700hq    total:244  pass:223  dwarn:0   dfail:0   fail:0   skip:21 
fi-skl-6700k     total:244  pass:222  dwarn:1   dfail:0   fail:0   skip:21 
fi-skl-6770hq    total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14 
fi-snb-2520m     total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32 
fi-snb-2600      total:244  pass:211  dwarn:0   dfail:0   fail:0   skip:33 

6294f67611ebe69006c0e85c372efadcac8e9d66 drm-intel-nightly: 2016y-11m-16d-09h-57m-25s UTC integration manifest 892646c drm/i915/gvt: drop checks for early Skylake revisions

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3015/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#2 lore raw
In reply to Jani Nikula

Em Qua, 2016-11-16 às 12:13 +0200, Jani Nikula escreveu:

Quoted 1 line

We no longer cater for pre-production revisions of Skylake.

Quoted 35 lines
Fixes d4362225e8cb ("drm/i915/gvt: update misc ctl regs base on

stepping info")

---
 drivers/gpu/drm/i915/gvt/handlers.c | 6 ++----

 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/gvt/handlers.c +0 -0
index 1b3db0c7a6db..12cd9b2a415c 100644
@@ -1279,14 +1279,12 @@ static int skl_misc_ctl_write(struct
 intel_vgpu *vgpu, unsigned int offset,

  case 0x4ddc:
  vgpu_vreg(vgpu, offset) = 0x8000003c; /* WaCompressedResourceSamplerPbeMediaNewHashMode:skl */

drivers/gpu/drm/i915/gvt/handlers.c +0 -1
-		if (IS_SKL_REVID(dev_priv, SKL_REVID_C0,

REVID_FOREVER))

drivers/gpu/drm/i915/gvt/handlers.c +1 -1
-			I915_WRITE(reg, vgpu_vreg(vgpu, offset));
+		I915_WRITE(reg, vgpu_vreg(vgpu, offset));

  break;
  case 0x42080:
  vgpu_vreg(vgpu, offset) = 0x8000;
  /* WaCompressedResourceDisplayNewHashMode:skl */

drivers/gpu/drm/i915/gvt/handlers.c +0 -1
-		if (IS_SKL_REVID(dev_priv, SKL_REVID_E0,

REVID_FOREVER))

drivers/gpu/drm/i915/gvt/handlers.c +1 -1
-			I915_WRITE(reg, vgpu_vreg(vgpu, offset));
+		I915_WRITE(reg, vgpu_vreg(vgpu, offset));
Quoted 3 lines

  break;
  default:
  return -EINVAL;

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Applied
#3 lore raw
In reply to Jani Nikula
Quoted 9 lines · Jani Nikula

We no longer cater for pre-production revisions of Skylake.

Fixes d4362225e8cb ("drm/i915/gvt: update misc ctl regs base on stepping info")
Cc Ping Gao <[email protected]>
Cc Zhenyu Wang <[email protected]>
Cc Zhi Wang <[email protected]>

---

applied, thanks!

Quoted 27 lines
 drivers/gpu/drm/i915/gvt/handlers.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/gvt/handlers.c +2 -4
index 1b3db0c7a6db..12cd9b2a415c 100644
@@ -1279,14 +1279,12 @@ static int skl_misc_ctl_write(struct intel_vgpu *vgpu, unsigned int offset,
 	case 0x4ddc:
 		vgpu_vreg(vgpu, offset) = 0x8000003c;
 		/* WaCompressedResourceSamplerPbeMediaNewHashMode:skl */
-		if (IS_SKL_REVID(dev_priv, SKL_REVID_C0, REVID_FOREVER))
-			I915_WRITE(reg, vgpu_vreg(vgpu, offset));
+		I915_WRITE(reg, vgpu_vreg(vgpu, offset));
 		break;
 	case 0x42080:
 		vgpu_vreg(vgpu, offset) = 0x8000;
 		/* WaCompressedResourceDisplayNewHashMode:skl */
-		if (IS_SKL_REVID(dev_priv, SKL_REVID_E0, REVID_FOREVER))
-			I915_WRITE(reg, vgpu_vreg(vgpu, offset));
+		I915_WRITE(reg, vgpu_vreg(vgpu, offset));
 		break;
 	default:
 		return -EINVAL;
Signature · 1 line
2.1.4
Signature · 3 lines
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx