Skip to contentSkip to conversation

crec: Correct name of output binary to crec

PATCH In review Richard Fitzgerald 2 participants 6 messages Nov 16, 2016 – Nov 18, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crec: Correct name of output binary to crec

For some reason when the build system was converted to automake by this patch

"Convert the build system to autotools"

the name of the output binary for crec was changed from 'crec' to 'crecord'.

This patch corrects it back to 'crec'

---
 src/utils/Makefile.am | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
src/utils/Makefile.am +4 -4
index 5f685e3..1967d92 100644
@@ -1,11 +1,11 @@
-bin_PROGRAMS = cplay crecord
+bin_PROGRAMS = cplay crec
 
 cplay_SOURCES = cplay.c
-crecord_SOURCES = crec.c
+crec_SOURCES = crec.c
 
 cplay_CFLAGS = -I$(top_srcdir)/include
-crecord_CFLAGS = -I$(top_srcdir)/include
+crec_CFLAGS = -I$(top_srcdir)/include
 
 
 cplay_LDADD = $(top_builddir)/src/lib/libtinycompress.la
-crecord_LDADD = $(top_builddir)/src/lib/libtinycompress.la
+crec_LDADD = $(top_builddir)/src/lib/libtinycompress.la
Signature · 1 line
2.1.4
#1 lore raw
Quoted 9 lines · Richard Fitzgerald

For some reason when the build system was converted to automake by this patch

"Convert the build system to autotools"

the name of the output binary for crec was changed from 'crec' to 'crecord'.

This patch corrects it back to 'crec'

That implies crecord is incorrect, I do not think so.

Can you explain why you would want to rename this back.

The motivation for this was to make it proper like cplay. Also similar to aplay and arecord.

Signature · 1 line
~Vinod
#2 lore raw
Quoted 9 lines · Vinod Koul
Quoted 8 lines · Richard Fitzgerald

For some reason when the build system was converted to automake by this patch

"Convert the build system to autotools"

the name of the output binary for crec was changed from 'crec' to 'crecord'.

Quoted 9 lines
Quoted 1 line

This patch corrects it back to 'crec'

That implies crecord is incorrect, I do not think so.

Can you explain why you would want to rename this back.

The motivation for this was to make it proper like cplay. Also similar to aplay and arecord.

I don't really see a need for that, or why "crec" is wrong.

In any case if you did want to change that name

a) it should be an explicit patch, not sneaked in as an undocumented and unexpected side-effect of some other patch

b) the source file should have been renamed to match, if the name "crec" is a massive problem then it should also be a problem that "cplay.c->cplay" but "crec.c->crecord". If it's ok to have the source file called crec.c what's wrong with the binary it builds being called crec?

c) it's a nuisance to have to change existing test systems and apps that launch "crec", or to create symlinks from crec->crecord.

#3 lore raw
Quoted 20 lines · Richard Fitzgerald
Quoted 9 lines · Vinod Koul
Quoted 8 lines · Richard Fitzgerald

For some reason when the build system was converted to automake by this patch

"Convert the build system to autotools"

the name of the output binary for crec was changed from 'crec' to 'crecord'.

Quoted 9 lines
Quoted 1 line

This patch corrects it back to 'crec'

That implies crecord is incorrect, I do not think so.

Can you explain why you would want to rename this back.

The motivation for this was to make it proper like cplay. Also similar to aplay and arecord.

Quoted 6 lines

I don't really see a need for that, or why "crec" is wrong.

In any case if you did want to change that name

a) it should be an explicit patch, not sneaked in as an undocumented and unexpected side-effect of some other patch

This part I agree. Unfortunately this was not done transparently...

Quoted 5 lines

b) the source file should have been renamed to match, if the name "crec" is a massive problem then it should also be a problem that "cplay.c->cplay" but "crec.c->crecord". If it's ok to have the source file called crec.c what's wrong with the binary it builds being called crec?

I dont mind renaming source as well..

I think bigger question is should we continue crec or crecord, my preference is latter.

Quoted 2 lines

c) it's a nuisance to have to change existing test systems and apps that launch "crec", or to create symlinks from crec->crecord.

Yeah agree, lets decide on one and stick to that, forever hopefully :)

Signature · 1 line
~Vinod
#4 lore raw
Quoted 38 lines · Vinod Koul
Quoted 20 lines · Richard Fitzgerald
Quoted 9 lines · Vinod Koul
Quoted 8 lines · Richard Fitzgerald

For some reason when the build system was converted to automake by this patch

"Convert the build system to autotools"

the name of the output binary for crec was changed from 'crec' to 'crecord'.

Quoted 9 lines
Quoted 1 line

This patch corrects it back to 'crec'

That implies crecord is incorrect, I do not think so.

Can you explain why you would want to rename this back.

The motivation for this was to make it proper like cplay. Also similar to aplay and arecord.

Quoted 6 lines

I don't really see a need for that, or why "crec" is wrong.

In any case if you did want to change that name

a) it should be an explicit patch, not sneaked in as an undocumented and unexpected side-effect of some other patch

This part I agree. Unfortunately this was not done transparently...

Quoted 5 lines

b) the source file should have been renamed to match, if the name "crec" is a massive problem then it should also be a problem that "cplay.c->cplay" but "crec.c->crecord". If it's ok to have the source file called crec.c what's wrong with the binary it builds being called crec?

I dont mind renaming source as well..

Quoted 8 lines

I think bigger question is should we continue crec or crecord, my preference is latter.

Quoted 2 lines

c) it's a nuisance to have to change existing test systems and apps that launch "crec", or to create symlinks from crec->crecord.

Yeah agree, lets decide on one and stick to that, forever hopefully :)

Ok let's change to crecord for consistency with arecord, and I'll do a patch to rename the source to match.

#5 lore raw
Quoted 13 lines · Richard Fitzgerald
Quoted 13 lines

This part I agree. Unfortunately this was not done transparently...

Quoted 5 lines

b) the source file should have been renamed to match, if the name "crec" is a massive problem then it should also be a problem that "cplay.c->cplay" but "crec.c->crecord". If it's ok to have the source file called crec.c what's wrong with the binary it builds being called crec?

I dont mind renaming source as well..

I think bigger question is should we continue crec or crecord, my preference is latter.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

c) it's a nuisance to have to change existing test systems and apps that launch "crec", or to create symlinks from crec->crecord.

Yeah agree, lets decide on one and stick to that, forever hopefully :)

Ok let's change to crecord for consistency with arecord, and I'll do a patch to rename the source to match.

Sounds good :)

Signature · 1 line
~Vinod