Skip to contentSkip to conversation

Patch "watchdog: core: Fix devres_alloc() allocation size" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Nov 17, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

watchdog: core: Fix devres_alloc() allocation size

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
watchdog-core-fix-devres_alloc-allocation-size.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 2e91838bf7ffdedabdb29e091207d6531d04ef4f Mon Sep 17 00:00:00 2001

From: Guenter Roeck <[email protected]>
Date: Tue, 9 Aug 2016 22:34:31 -0700
Subject: watchdog: core: Fix devres_alloc() allocation size

From: Guenter Roeck <[email protected]>

commit 2e91838bf7ffdedabdb29e091207d6531d04ef4f upstream.

Coverity reports:

Passing argument 152UL /* sizeof (*wdd) */ to function __devres_alloc_node and then casting the return value to struct watchdog_device ** is suspicious.

Allocation size needs to be sizeof(*rcwdd), not sizeof(*wdd).

Fixes 83fbae5a148c ("watchdog: Add a device managed API for ...")
Cc Neil Armstrong <[email protected]>
---
 drivers/watchdog/watchdog_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/watchdog_core.c +1 -1
@@ -349,7 +349,7 @@ int devm_watchdog_register_device(struct
 	struct watchdog_device **rcwdd;
 	int ret;
 
-	rcwdd = devres_alloc(devm_watchdog_unregister_device, sizeof(*wdd),
+	rcwdd = devres_alloc(devm_watchdog_unregister_device, sizeof(*rcwdd),
 			     GFP_KERNEL);
 	if (!rcwdd)
 		return -ENOMEM;

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/input-synaptics-rmi4-fix-error-handling-in-spi-transport-driver.patch queue-4.8/watchdog-core-fix-devres_alloc-allocation-size.patch queue-4.8/input-synaptics-rmi4-fix-error-handling-in-i2c-transport-driver.patch