Skip to contentSkip to conversation

Patch "i40e: fix call of ndo_dflt_bridge_getlink()" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Nov 17, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

i40e: fix call of ndo_dflt_bridge_getlink()

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
i40e-fix-call-of-ndo_dflt_bridge_getlink.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 599b076d15ee3ead7af20fc907079df00b2d59a0 Mon Sep 17 00:00:00 2001

From: Huaibin Wang <[email protected]>
Date: Mon, 26 Sep 2016 09:51:18 +0200
Subject: i40e: fix call of ndo_dflt_bridge_getlink()

From: Huaibin Wang <[email protected]>

commit 599b076d15ee3ead7af20fc907079df00b2d59a0 upstream.

Order of arguments is wrong.
The wrong code has been introduced by commit 7d4f8d871ab1, but is compiled only since commit 9df70b66418e.

Note that this may break netlink dumps.

Fixes 9df70b66418e ("i40e: Remove incorrect #ifdef's")
Fixes 7d4f8d871ab1 ("switchdev; add VLAN support for port's bridge_getlink")
CC Carolyn Wyborny <[email protected]>
---
 drivers/net/ethernet/intel/i40e/i40e_main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/i40e/i40e_main.c +1 -1
@@ -8595,7 +8595,7 @@ static int i40e_ndo_bridge_getlink(struc
 		return 0;
 
 	return ndo_dflt_bridge_getlink(skb, pid, seq, dev, veb->bridge_mode,
-				       nlflags, 0, 0, filter_mask, NULL);
+				       0, 0, nlflags, filter_mask, NULL);
 }
 
 #define I40E_MAX_TUNNEL_HDR_LEN 80

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/i40e-fix-call-of-ndo_dflt_bridge_getlink.patch