Skip to contentSkip to conversation

Patch "rtc: pcf2123: Add missing error code assignment before test" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Nov 17, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

rtc: pcf2123: Add missing error code assignment before test

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
rtc-pcf2123-add-missing-error-code-assignment-before-test.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 83ab7dad06b74e390c2ce0e7b5136daf286e1f5e Mon Sep 17 00:00:00 2001

From: Christophe JAILLET <[email protected]>
Date: Tue, 9 Aug 2016 13:58:27 +0200
Subject: rtc: pcf2123: Add missing error code assignment before test

From: Christophe JAILLET <[email protected]>

commit 83ab7dad06b74e390c2ce0e7b5136daf286e1f5e upstream.

It is likely that checking the result of 'pcf2123_write_reg' is expected here.
Also fix a small style issue. The '{' at the beginning of the function is misplaced.

Fixes 809b453b76e15 ("rtc: pcf2123: clean up writes to the rtc chip")
---
 drivers/rtc/rtc-pcf2123.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/rtc/rtc-pcf2123.c +3 -2
@@ -182,7 +182,8 @@ static ssize_t pcf2123_show(struct devic
 }
 
 static ssize_t pcf2123_store(struct device *dev, struct device_attribute *attr,
-			     const char *buffer, size_t count) {
+			     const char *buffer, size_t count)
+{
 	struct pcf2123_sysfs_reg *r;
 	unsigned long reg;
 	unsigned long val;
@@ -199,7 +200,7 @@ static ssize_t pcf2123_store(struct devi
 	if (ret)
 		return ret;
 
-	pcf2123_write_reg(dev, reg, val);
+	ret = pcf2123_write_reg(dev, reg, val);
 	if (ret < 0)
 		return -EIO;
 	return count;

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/rtc-pcf2123-add-missing-error-code-assignment-before-test.patch