drm: also move DSI panels to the front of the connector list
Subsystems (2)
PATCH 1/1 drm: also move DSI panels to the front of the connector list
We've overlooked adding DSI panels to the front of the connector list. This seems to be the right thing to do, and I suspect this might fix some issues, although I currently have no evidence to support this.
--- drivers/gpu/drm/drm_modeset_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/drm_modeset_helper.c +2 -1
@@ -51,7 +51,8 @@ void drm_helper_move_panel_connectors_to_head(struct drm_device *dev)list_for_each_entry_safe (connector, tmp, &dev->mode_config.connector_list, head) {if (connector->connector_type ==DRM_MODE_CONNECTOR_LVDS || - connector->connector_type == DRM_MODE_CONNECTOR_eDP) + connector->connector_type == DRM_MODE_CONNECTOR_eDP || + connector->connector_type ==DRM_MODE_CONNECTOR_DSI )list_move_tail (&connector->head, &panel_list); }
Signature · 6 lines
2.1.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 1/1 drm: also move DSI panels to the front of the connector list
We've overlooked adding DSI panels to the front of the connector list. This seems to be the right thing to do, and I suspect this might fix some issues, although I currently have no evidence to support this.
v2: also git add the comment change
--- drivers/gpu/drm/drm_modeset_helper.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_modeset_helper.c +3 -2
@@ -38,7 +38,7 @@* Some userspace presumes that the first connected connector is the main * display, where it's supposed to display e.g. the login screen. For * laptops, this should be the main panel. Use this function to sort all -* (eDP/LVDS) panels to the front of the connector list, instead of +* (eDP/LVDS/DSI) panels to the front of the connector list, instead of * painstakingly trying to initialize them in the right order. */ void drm_helper_move_panel_connectors_to_head (struct drm_device *dev)
@@ -51,7 +51,8 @@ void drm_helper_move_panel_connectors_to_head(struct drm_device *dev)list_for_each_entry_safe (connector, tmp, &dev->mode_config.connector_list, head) {if (connector->connector_type ==DRM_MODE_CONNECTOR_LVDS || - connector->connector_type == DRM_MODE_CONNECTOR_eDP) + connector->connector_type == DRM_MODE_CONNECTOR_eDP || + connector->connector_type ==DRM_MODE_CONNECTOR_DSI )list_move_tail (&connector->head, &panel_list); }
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter
AppliedQuoted 8 lines · Jani Nikula
We've overlooked adding DSI panels to the front of the connector list. This seems to be the right thing to do, and I suspect this might fix some issues, although I currently have no evidence to support this.
v2: also git add the comment change
Cc Daniel Vetter <[email protected]>Signed-off-by Jani Nikula <[email protected]>
Applied to drm-misc, thx.
-Daniel
Quoted 30 lines
--- drivers/gpu/drm/drm_modeset_helper.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_modeset_helper.c +3
-2@@ -38,7 +38,7 @@* Some userspace presumes that the first connected connector is the main * display, where it's supposed to display e.g. the login screen. For * laptops, this should be the main panel. Use this function to sort all -* (eDP/LVDS) panels to the front of the connector list, instead of +* (eDP/LVDS/DSI) panels to the front of the connector list, instead of * painstakingly trying to initialize them in the right order. */ void drm_helper_move_panel_connectors_to_head (struct drm_device *dev)@@ -51,7 +51,8 @@ void drm_helper_move_panel_connectors_to_head(struct drm_device *dev)list_for_each_entry_safe (connector, tmp, &dev->mode_config.connector_list, head) {if (connector->connector_type ==DRM_MODE_CONNECTOR_LVDS || - connector->connector_type == DRM_MODE_CONNECTOR_eDP) + connector->connector_type == DRM_MODE_CONNECTOR_eDP || + connector->connector_type ==DRM_MODE_CONNECTOR_DSI )list_move_tail (&connector->head, &panel_list); }Signature · 1 line
2.1.4
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 8 lines · Jani Nikula
We've overlooked adding DSI panels to the front of the connector list. This seems to be the right thing to do, and I suspect this might fix some issues, although I currently have no evidence to support this.
v2: also git add the comment change
Cc Daniel Vetter <[email protected]>Signed-off-by Jani Nikula <[email protected]>
Out of curiosity, why driver (i915) do not create connectors just in proper order instead of sorting them later.
--
Regards
Andrzej
Quoted 18 lines
--- drivers/gpu/drm/drm_modeset_helper.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_modeset_helper.c +1
-1@@ -38,7 +38,7 @@* Some userspace presumes that the first connected connector is the main * display, where it's supposed to display e.g. the login screen. For * laptops, this should be the main panel. Use this function to sort all -* (eDP/LVDS) panels to the front of the connector list, instead of +* (eDP/LVDS/DSI) panels to the front of the connector list, instead of * painstakingly trying to initialize them in the right order. */ void drm_helper_move_panel_connectors_to_head (struct drm_device *dev)
drivers/gpu/drm/drm_modeset_helper.c void drm_helper_move_panel_connectors_to_head(struct drm_device *dev) · line 58
Quoted 9 lines
drivers/gpu/drm/drm_modeset_helper.c +2
-1@@ -51,7 +51,8 @@ void drm_helper_move_panel_connectors_to_head(struct drm_device *dev)list_for_each_entry_safe (connector, tmp, &dev->mode_config.connector_list, head) {if (connector->connector_type ==DRM_MODE_CONNECTOR_LVDS || - connector->connector_type == DRM_MODE_CONNECTOR_eDP) + connector->connector_type == DRM_MODE_CONNECTOR_eDP || + connector->connector_type ==DRM_MODE_CONNECTOR_DSI )list_move_tail (&connector->head, &panel_list); }
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 7 lines · Andrzej Hajda
Quoted 6 lines · Jani Nikula
We've overlooked adding DSI panels to the front of the connector list. This seems to be the right thing to do, and I suspect this might fix some issues, although I currently have no evidence to support this.
v2: also git add the comment change
Quoted 7 lines
Quoted 2 lines
Cc Daniel Vetter <[email protected]>Signed-off-by Jani Nikula <[email protected]>Reviewed-by Andrzej Hajda <[email protected]>Out of curiosity, why driver (i915) do not create connectors just in proper order instead of sorting them later.
commit 270b30420c5e0d5f779aa76882367f9265c5aa7d
Author: Daniel Vetter <[email protected]> Date: Sat Oct 27 15:52:05 2012 +0200
drm/i915: move panel connectors to the front
This essentially reverts
commit cb0953d734348e8862d6d7edc666cfb3bf6d8fae
Author: Adam Jackson <[email protected]>
Date: Fri Jul 16 14:46:29 2010 -0400
drm/i915: Initialize LVDS and eDP outputs before anything else
simply because it doesn't scale: It misses SDVO and DVO panels, and now with DDI encoders on haswell this is becoming unmanageable.
Instead we simply sort the connector list after everything is set up.
Quoted 39 lines
--
Regards
AndrzejQuoted 18 lines
--- drivers/gpu/drm/drm_modeset_helper.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_modeset_helper.c +1
-1@@ -38,7 +38,7 @@* Some userspace presumes that the first connected connector is the main * display, where it's supposed to display e.g. the login screen. For * laptops, this should be the main panel. Use this function to sort all -* (eDP/LVDS) panels to the front of the connector list, instead of +* (eDP/LVDS/DSI) panels to the front of the connector list, instead of * painstakingly trying to initialize them in the right order. */ void drm_helper_move_panel_connectors_to_head (struct drm_device *dev)drivers/gpu/drm/drm_modeset_helper.c void drm_helper_move_panel_connectors_to_head(struct drm_device *dev) · line 58
Quoted 9 lines
drivers/gpu/drm/drm_modeset_helper.c +2
-1@@ -51,7 +51,8 @@ void drm_helper_move_panel_connectors_to_head(struct drm_device *dev)list_for_each_entry_safe (connector, tmp, &dev->mode_config.connector_list, head) {if (connector->connector_type ==DRM_MODE_CONNECTOR_LVDS || - connector->connector_type == DRM_MODE_CONNECTOR_eDP) + connector->connector_type == DRM_MODE_CONNECTOR_eDP || + connector->connector_type ==DRM_MODE_CONNECTOR_DSI )list_move_tail (&connector->head, &panel_list); }_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm: also move DSI panels to the front of the connector list (rev2)
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm: also move DSI panels to the front of the connector list (rev2)
URL : https://patchwork.freedesktop.org/series/15483/
State : success
== Summary ==
Series 15483v2 drm: also move DSI panels to the front of the connector list
https://patchwork.freedesktop.org/api/1.0/series/15483/revisions/2/mbox/
fi-bdw-5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15 fi-bsw-n3050 total:244 pass:204 dwarn:0 dfail:0 fail:0 skip:40 fi-bxt-t5700 total:244 pass:216 dwarn:0 dfail:0 fail:0 skip:28 fi-byt-j1900 total:244 pass:216 dwarn:0 dfail:0 fail:0 skip:28 fi-byt-n2820 total:244 pass:212 dwarn:0 dfail:0 fail:0 skip:32 fi-hsw-4770 total:244 pass:224 dwarn:0 dfail:0 fail:0 skip:20 fi-hsw-4770r total:244 pass:224 dwarn:0 dfail:0 fail:0 skip:20 fi-ilk-650 total:244 pass:191 dwarn:0 dfail:0 fail:0 skip:53 fi-ivb-3520m total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-ivb-3770 total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-kbl-7200u total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-skl-6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14 fi-skl-6700hq total:244 pass:223 dwarn:0 dfail:0 fail:0 skip:21 fi-skl-6700k total:244 pass:222 dwarn:1 dfail:0 fail:0 skip:21 fi-skl-6770hq total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14 fi-snb-2520m total:244 pass:212 dwarn:0 dfail:0 fail:0 skip:32 fi-snb-2600 total:244 pass:211 dwarn:0 dfail:0 fail:0 skip:33
ccd01198820ab7286f0b98f7b28dbf6ad29fa861 drm-intel-nightly: 2016y-11m-17d-10h-54m-57s UTC integration manifest 3f6fa82 drm: also move DSI panels to the front of the connector list
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3033/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx