Skip to contentSkip to conversation

nvmecli-tests : update the list of dependencies

PATCH New chaitany kulkarni 2 participants 3 messages Nov 17, 2016 NVMe

lore
Share & tools
lore

chaitany kulkarni

author
#0 lore raw

PATCH 1/1 nvmecli-tests : update the list of dependencies

README file is updated with complete list of dependencies required to setup the environment for unitttests.

Signed-off-by Chaitanya Kulkarni <chaitanya.kulkarni at hgst.com>
---
 tests/README | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)
tests/README +11 -2
index 70686d8..686bd04 100644
@@ -12,8 +12,17 @@ nvmetests
 ------------------------------
 
     1. Python(>= 2.7.5 or >= 3.3)
-    2. nose2(Installation guide http://nose2.readthedocs.io/)
-    3. nvme-cli(https://github.com/linux-nvme/nvme-cli.git)
+    2. nose(http://nose.readthedocs.io/en/latest/)
+    3. nose2(Installation guide http://nose2.readthedocs.io/)
+    4. pep8(https://pypi.python.org/pypi/setuptools-pep8)
+    5. flake8(https://pypi.python.org/pypi/flake8)
+    6. pylint(https://www.pylint.org/)
+    7. Epydoc(http://epydoc.sourceforge.net/)
+    8. nvme-cli(https://github.com/linux-nvme/nvme-cli.git)
+
+    Python package management system pip can be used to install most of the
+    listed packages(https://pip.pypa.io/en/stable/installing/) :-
+    $ pip install nose nose2 pep8 flake8 pylint epydoc
 
 2. Overview
 -----------
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 nvmecli-tests : update the list of dependencies

Quoted 15 lines · chaitany kulkarni

README file is updated with complete list of dependencies required to setup the environment for unitttests.

Signed-off-by Chaitanya Kulkarni <chaitanya.kulkarni at hgst.com>

---
?tests/README | 13 +++++++++++--
?1 file changed, 11 insertions(+), 2 deletions(-)

tests/README +0 -0
index 70686d8..686bd04 100644
@@ -12,8 +12,17 @@ nvmetests

?------------------------------

Quoted 16 lines

?????1. Python(>= 2.7.5 or >= 3.3)
-????2. nose2(Installation guide http://nose2.readthedocs.io/)
-????3. nvme-cli(https://github.com/linux-nvme/nvme-cli.git) +????2. nose(http://nose.readthedocs.io/en/latest/) +????3. nose2(Installation guide http://nose2.readthedocs.io/)
+????4. pep8(https://pypi.python.org/pypi/setuptools-pep8) +????5. flake8(https://pypi.python.org/pypi/flake8) +????6. pylint(https://www.pylint.org/)
+????7. Epydoc(http://epydoc.sourceforge.net/)
+????8. nvme-cli(https://github.com/linux-nvme/nvme-cli.git) +
+????Python package management system pip can be used to install most of the
+????listed packages(https://pip.pypa.io/en/stable/installing/) :- +????$ pip install nose nose2 pep8 flake8 pylint epydoc

Readme looks good, seems to address Keith's point on dependencies.

Though Keith mentioned there was a 'doc' folder referenced in the README that appeared to be missing from the commit. ?Maybe that is a future patch?

Reviewed-by ?Jay Freyensee <james_p_freyensee at linux.intel.com>
author
#2 lore raw

PATCH 1/1 nvmecli-tests : update the list of dependencies

Hi J Freyensee,

I did not commit the documentation since it can be generated by executing the "make doc" (README section 3.7.b) upon cloning the repository from .py. For reference I did mention it in the README, if it is confusing I'll take it out from README.

Let me know if we should have the documentation as a part of repository I'll send a patch today.

Regards,
-Chaitanya

Quoted 42 lines · J Freyensee
Quoted 29 lines · chaitany kulkarni

README file is updated with complete list of dependencies required to setup the environment for unitttests.

Signed-off-by Chaitanya Kulkarni <chaitanya.kulkarni at hgst.com>
---
 tests/README | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)
tests/README +9 -2
index 70686d8..686bd04 100644
@@ -12,8 +12,17 @@ nvmetests
 ------------------------------
 
     1. Python(>= 2.7.5 or >= 3.3)
-    2. nose2(Installation guide http://nose2.readthedocs.io/)
-    3. nvme-cli(https://github.com/linux-nvme/nvme-cli.git)
+    2. nose(http://nose.readthedocs.io/en/latest/)
+    3. nose2(Installation guide http://nose2.readthedocs.io/)
+    4. pep8(https://pypi.python.org/pypi/setuptools-pep8)
+    5. flake8(https://pypi.python.org/pypi/flake8)
+    6. pylint(https://www.pylint.org/)
+    7. Epydoc(http://epydoc.sourceforge.net/)
+    8. nvme-cli(https://github.com/linux-nvme/nvme-cli.git)
+
+    Python package management system pip can be used to install most

of the

tests/README nvmetests · line 25

Quoted 2 lines
tests/README +2 -0
+    listed packages(https://pip.pypa.io/en/stable/installing/) :-
+    $ pip install nose nose2 pep8 flake8 pylint epydoc

Readme looks good, seems to address Keith's point on dependencies.

Though Keith mentioned there was a 'doc' folder referenced in the README that appeared to be missing from the commit. Maybe that is a future patch?

Reviewed-by Jay Freyensee <james_p_freyensee at linux.intel.com>