Skip to contentSkip to conversation

drm/i915: Do not log disabled planes in pipe config

PATCH In review Tvrtko Ursulin 5 participants 6 messages Nov 18, 2016 – Nov 21, 2016

Subsystems (2)
lore
Share & tools
lore

Tvrtko Ursulin

author maintainer
#0 lore raw

PATCH 1/1 drm/i915: Do not log disabled planes in pipe config

From: Tvrtko Ursulin <[email protected]>

It just says "plane X disabled" which does not seem very useful.

Cc Maarten Lankhorst <[email protected]>
Cc Ville Syrjälä <[email protected]>
---
 drivers/gpu/drm/i915/intel_display.c | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/intel_display.c +10 -12
index 155910c93896..d35ffb40ca67 100644
@@ -12732,9 +12732,7 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,
 	struct drm_device *dev = crtc->base.dev;
 	struct drm_i915_private *dev_priv = to_i915(dev);
 	struct drm_plane *plane;
-	struct intel_plane *intel_plane;
-	struct intel_plane_state *state;
-	struct drm_framebuffer *fb;
+	bool planes = false;
 
 	DRM_DEBUG_KMS("[CRTC:%d:%s]%s\n",
 		      crtc->base.base.id, crtc->base.name, context);
@@ -12822,19 +12820,19 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,
 			      pipe_config->dpll_hw_state.fp1);
 	}
 
-	DRM_DEBUG_KMS("planes on this crtc\n");
 	list_for_each_entry(plane, &dev->mode_config.plane_list, head) {
+		struct intel_plane *intel_plane = to_intel_plane(plane);
+		struct intel_plane_state *state =
+				to_intel_plane_state(plane->state);
+		struct drm_framebuffer *fb = state->base.fb;
 		struct drm_format_name_buf format_name;
-		intel_plane = to_intel_plane(plane);
-		if (intel_plane->pipe != crtc->pipe)
-			continue;
 
-		state = to_intel_plane_state(plane->state);
-		fb = state->base.fb;
-		if (!fb) {
-			DRM_DEBUG_KMS("[PLANE:%d:%s] disabled, scaler_id = %d\n",
-				      plane->base.id, plane->name, state->scaler_id);
+		if (intel_plane->pipe != crtc->pipe || !fb)
 			continue;
+
+		if (!planes) {
+			DRM_DEBUG_KMS("Planes on this crtc:\n");
+			planes = true;
 		}
 
 		DRM_DEBUG_KMS("[PLANE:%d:%s] FB:%d, fb = %ux%u format = %s\n",
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.BAT: failure for drm/i915: Do not log disabled planes in pipe config

== Series Details ==

== Series Details ==

Series: drm/i915: Do not log disabled planes in pipe config
URL : https://patchwork.freedesktop.org/series/15548/
State : failure

== Summary ==

Series 15548v1 drm/i915: Do not log disabled planes in pipe config
https://patchwork.freedesktop.org/api/1.0/series/15548/revisions/1/mbox/

Test gem_ringfill:

        Subgroup basic-default-hang:
                pass       -> INCOMPLETE (fi-hsw-4770r)
fi-bdw-5557u     total:244  pass:229  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050     total:244  pass:204  dwarn:0   dfail:0   fail:0   skip:40 
fi-bxt-t5700     total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28 
fi-byt-j1900     total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28 
fi-byt-n2820     total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32 
fi-hsw-4770      total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20 
fi-hsw-4770r     total:115  pass:105  dwarn:0   dfail:0   fail:0   skip:9  
fi-ilk-650       total:244  pass:191  dwarn:0   dfail:0   fail:0   skip:53 
fi-ivb-3520m     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-ivb-3770      total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-kbl-7200u     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-skl-6260u     total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14 
fi-skl-6700hq    total:244  pass:223  dwarn:0   dfail:0   fail:0   skip:21 
fi-skl-6700k     total:244  pass:222  dwarn:1   dfail:0   fail:0   skip:21 
fi-skl-6770hq    total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14 
fi-snb-2520m     total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32 
fi-snb-2600      total:244  pass:211  dwarn:0   dfail:0   fail:0   skip:33 

9debbae8dd870123be84e5501dbc9c88cbe32c68 drm-intel-nightly: 2016y-11m-18d-11h-48m-38s UTC integration manifest 5c1ce61 drm/i915: Do not log disabled planes in pipe config

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3053/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
In reply to Tvrtko Ursulin

Op 18-11-16 om 12:40 schreef Tvrtko Ursulin:

Quoted 7 lines

From: Tvrtko Ursulin <[email protected]>

It just says "plane X disabled" which does not seem very useful.

Cc Maarten Lankhorst <[email protected]>
Cc Ville Syrjälä <[email protected]>

Could we remove plane dumping altogether? It's not safe to do so in the way done by this function, and we could add missing things in intel_plane_atomic_calc_changes.

~Maarten
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
Quoted 9 lines · Maarten Lankhorst

Op 18-11-16 om 12:40 schreef Tvrtko Ursulin:

Quoted 7 lines

From: Tvrtko Ursulin <[email protected]>

It just says "plane X disabled" which does not seem very useful.

Cc Maarten Lankhorst <[email protected]>
Cc Ville Syrjälä <[email protected]>

Could we remove plane dumping altogether? It's not safe to do so in the way done by this function, and we could add missing things in intel_plane_atomic_calc_changes.

Yeah, might make sense to dump that stuff only from some plane code. And we should probably take a good look at Rob Clark's new state dumping stuff for that, so that we'll get it in some decently standardized format.

I must admit that I didn't take a very good look at Rob's stuff, but maybe he already added the dumps to some useful places, and all we'd have to do is expand the dumps with our own derived plane state...

Signature · 6 lines
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw
Quoted 11 lines · Ville Syrjälä
Quoted 9 lines · Maarten Lankhorst

Op 18-11-16 om 12:40 schreef Tvrtko Ursulin:

Quoted 7 lines

From: Tvrtko Ursulin <[email protected]>

It just says "plane X disabled" which does not seem very useful.

Cc Maarten Lankhorst <[email protected]>
Cc Ville Syrjälä <[email protected]>

Could we remove plane dumping altogether? It's not safe to do so in the way done by this function, and we could add missing things in intel_plane_atomic_calc_changes.

Quoted 7 lines

Yeah, might make sense to dump that stuff only from some plane code. And we should probably take a good look at Rob Clark's new state dumping stuff for that, so that we'll get it in some decently standardized format.

I must admit that I didn't take a very good look at Rob's stuff, but maybe he already added the dumps to some useful places, and all we'd have to do is expand the dumps with our own derived plane state...

Shall I leave it with you guys then? The most I would feel confident in this area is to submit a patch which removes the plane debug from intel_dump_pipe_config if that is broken. But not sure how useful would that be without this other work you are discussing.

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

Op 21-11-16 om 11:50 schreef Tvrtko Ursulin:

Quoted 17 lines · Ville Syrjälä
Quoted 15 lines · Maarten Lankhorst
Quoted 9 lines

Op 18-11-16 om 12:40 schreef Tvrtko Ursulin:

Quoted 7 lines

From: Tvrtko Ursulin <[email protected]>

It just says "plane X disabled" which does not seem very useful.

Cc Maarten Lankhorst <[email protected]>
Cc Ville Syrjälä <[email protected]>

Could we remove plane dumping altogether? It's not safe to do so in the way done by this function, and we could add missing things in intel_plane_atomic_calc_changes.

Yeah, might make sense to dump that stuff only from some plane code. And we should probably take a good look at Rob Clark's new state dumping stuff for that, so that we'll get it in some decently standardized format.

Quoted 5 lines
Quoted 3 lines

I must admit that I didn't take a very good look at Rob's stuff, but maybe he already added the dumps to some useful places, and all we'd have to do is expand the dumps with our own derived plane state...

Shall I leave it with you guys then? The most I would feel confident in this area is to submit a patch which removes the plane debug from intel_dump_pipe_config if that is broken. But not sure how useful would that be without this other work you are discussing.

Intel plane dumping is broken regardless, so feel I think it's good to submit a patch to nuke it. :)
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx