scsi/esp: do not raise an interrupt when reading the FIFO register

PATCH New Hervé Poussineau 1 participant 1 message Nov 18, 2016

Share & tools

Hervé Poussineau

author

2016-11-18 22:34 UTC #0 lore raw

PATCH 1/1 scsi/esp: do not raise an interrupt when reading the FIFO register

This fixes SCSI adapter self-tests done in MIPS Jazz emulation, broken since ff589551c8e8e9e95e211b9d8daafb4ed39f1aec.

Signed-off-by Hervé Poussineau <[email protected]>

---
 hw/scsi/esp.c | 2 --
 1 file changed, 2 deletions(-)

hw/scsi/esp.c +0 -2

index 1f2f2d3..5a5a4e9 100644
@@ -406,11 +406,9 @@ uint64_t esp_reg_read(ESPState *s, uint32_t saddr)
             /* Data out.  */
             qemu_log_mask(LOG_UNIMP, "esp: PIO data read not implemented\n");
             s->rregs[ESP_FIFO] = 0;
-            esp_raise_irq(s);
         } else if (s->ti_rptr < s->ti_wptr) {
             s->ti_size--;
             s->rregs[ESP_FIFO] = s->ti_buf[s->ti_rptr++];
-            esp_raise_irq(s);
         }
         if (s->ti_rptr == s->ti_wptr) {
             s->ti_rptr = 0;

Signature · 1 line

2.1.4