Skip to contentSkip to conversation

Patch "sparc: serial: sunhv: fix a double lock bug" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Nov 19, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

sparc: serial: sunhv: fix a double lock bug

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
sparc-serial-sunhv-fix-a-double-lock-bug.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Sat Nov 19 09:52:37 CET 2016

From: Dan Carpenter <[email protected]>
Date: Fri, 15 Jul 2016 14:17:33 +0300
Subject: sparc: serial: sunhv: fix a double lock bug

From: Dan Carpenter <[email protected]>

[ Upstream commit 344e3c7734d5090b148c19ac6539b8947fed6767 ]

We accidentally take the "port->lock" twice in a row. This old code was supposed to be deleted.

Fixes e58e241c1788 ('sparc: serial: Clean up the locking for -rt')
---
 drivers/tty/serial/sunhv.c |    6 ------
 1 file changed, 6 deletions(-)
drivers/tty/serial/sunhv.c +0 -6
@@ -490,12 +490,6 @@ static void sunhv_console_write_bychar(s
 		locked = spin_trylock_irqsave(&port->lock, flags);
 	else
 		spin_lock_irqsave(&port->lock, flags);
-	if (port->sysrq) {
-		locked = 0;
-	} else if (oops_in_progress) {
-		locked = spin_trylock(&port->lock);
-	} else
-		spin_lock(&port->lock);
 
 	for (i = 0; i < n; i++) {
 		if (*s == '\n')

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/sparc-serial-sunhv-fix-a-double-lock-bug.patch