Fix various compiler warnings
PATCH 1/1 Fix various compiler warnings
- move p2mp only push_option_fmt to p2mp only section to avoid warning that struct push_list being defined in the argument list
- incoming_push_message not declared on client without server by putting it into the right define block
--- src/openvpn/push.c | 49 ++++++++++++++++++++++++------------------------- src/openvpn/push.h | 3 +-- 2 files changed, 25 insertions(+), 27 deletions(-)
src/openvpn/push.c +24 -25
@@ -42,31 +42,6 @@static char push_reply_cmd[] ="PUSH_REPLY" ; -/** -* Add an option to the given push list by providing a format string. -* -* The string added to the push options is allocated in o->gc, so the caller -* does not have to preserve anything. -* -* @param gc GC arena where options are allocated -* @param push_list Push list containing options -* @param msglevel The message level to use when printing errors -* @param fmt Format string for the option -* @param ... Format string arguments -* -* @return true on success, false on failure. -*/ -static bool push_option_fmt (struct gc_arena *gc,struct push_list *push_list, - int msglevel, const char *fmt, ...) -#ifdef __GNUC__ -#if __USE_MINGW_ANSI_STDIO - __attribute__ ((format (gnu_printf, 4, 5))) -#else - __attribute__ ((format (__printf__, 4, 5))) -#endif -#endif - ; -/* * Auth username/password *
@@ -177,6 +152,30 @@ server_pushed_signal (struct context *c, const struct buffer *buffer, const bool }#if P2MP_SERVER +/** +* Add an option to the given push list by providing a format string. +* +* The string added to the push options is allocated in o->gc, so the caller +* does not have to preserve anything. +* +* @param gc GC arena where options are allocated +* @param push_list Push list containing options +* @param msglevel The message level to use when printing errors +* @param fmt Format string for the option +* @param ... Format string arguments +* +* @return true on success, false on failure. +*/ +static bool push_option_fmt (struct gc_arena *gc,struct push_list *push_list, + int msglevel, const char *fmt, ...) +#ifdef __GNUC__ +#if __USE_MINGW_ANSI_STDIO + __attribute__ ((format (gnu_printf, 4, 5))) +#else + __attribute__ ((format (__printf__, 4, 5))) +#endif +#endif + ;/* * Send auth failed message from server to client.
src/openvpn/push.h +1 -2
@@ -51,10 +51,9 @@ void receive_auth_failed (struct context *c, const struct buffer *buffer);void server_pushed_signal (struct context *c,const struct buffer *buffer,const bool restart,const int adv); -#if P2MP_SERVER -void incoming_push_message (struct context *c,const struct buffer *buffer); +#if P2MP_SERVER void clone_push_list (struct options *o);void push_option (struct options *o,const char *opt,int msglevel);
Signature · 1 line
2.9.3 (Apple Git-75)
ACK.
Your patch has been applied to the master branch.
commit 3212d0c0a5caac6607b30effb584887eb3325942
Author: Arne Schwabe Date: Sat Nov 19 16:42:44 2016 +0100
Fix various compiler warnings
Acked-by: Gert Doering <[email protected]...>
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg13124.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering