Skip to contentSkip to conversation

staging: speakup: thread.c checkpatch modifications

PATCH New Walt Feasel 1 participant 3 messages Nov 19, 2016 Staging

lore
Share & tools
lore
#0 lore raw

v2 cover staging: speakup: thread.c checkpatch modifications

Make Linux kernel style modifications for speakup to include

comment style modifications
align parenthesis

Walt Feasel (2):
staging: speakup: thread.c Comment modifications
staging: speakup: thread.c align on parenthesis

 drivers/staging/speakup/thread.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Signature · 2 lines
v2 makes changes to correct for email format patch submission
2.1.4
#1 lore raw

PATCH v2 1/2 staging: speakup: thread.c Comment modifications

Make comment style modifications

---
v2 makes changes to correct for email format patch submission

 drivers/staging/speakup/thread.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/speakup/thread.c +2 -1
index 90c383e..e4de7dc 100644
@@ -47,7 +47,8 @@ int speakup_thread(void *data)
 		if (our_sound.active)
 			kd_mksound(our_sound.freq, our_sound.jiffies);
 		if (synth && synth->catch_up && synth->alive) {
-			/* It is up to the callee to take the lock, so that it
+			/*
+			 * It is up to the callee to take the lock, so that it
 			 * can sleep whenever it likes
 			 */
 			synth->catch_up(synth);
Signature · 1 line
2.1.4
#2 lore raw

PATCH v2 2/2 staging: speakup: thread.c align on parenthesis

In reply to Walt Feasel

Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis

---
v2 makes changes to correct for email format patch submission

 drivers/staging/speakup/thread.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/speakup/thread.c +1 -1
index e4de7dc..8c64f1a 100644
@@ -27,7 +27,7 @@ int speakup_thread(void *data)
 			our_sound = spk_unprocessed_sound;
 			spk_unprocessed_sound.active = 0;
 			prepare_to_wait(&speakup_event, &wait,
-				TASK_INTERRUPTIBLE);
+					TASK_INTERRUPTIBLE);
 			should_break = kthread_should_stop() ||
 				our_sound.active ||
 				(synth && synth->catch_up && synth->alive &&
Signature · 1 line
2.1.4