Skip to contentSkip to conversation

amdgpu: fix firmware loading failure

PATCH In review Xiangliang Yu 3 participants 4 messages Nov 21, 2016 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 amdgpu: fix firmware loading failure

For virtualization, firmware loading need the firmware version info, and will load the right firmware. So, transfer fw_version to toc.

---
 drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c +1 -1
index 6df0d6e..c9bd1cf 100644
@@ -366,7 +366,7 @@ static int smu7_populate_single_firmware_entry(struct pp_smumgr *smumgr,
 				&info);
 
 	if (!result) {
-		entry->version = info.version;
+		entry->version = info.fw_version;
 		entry->id = (uint16_t)fw_type;
 		entry->image_addr_high = smu_upper_32_bits(info.mc_addr);
 		entry->image_addr_low = smu_lower_32_bits(info.mc_addr);
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1479708780-3954-1-git-send-email-Xiangliang.Yu-5C7GfCeVMHo@public.gmane.org

#2 lore raw

Please use "drm/amdgpu" as th prefix for the title

-----邮件原件-----
发件人: amd-gfx [mailto:[email protected]] 代表 Xiangliang Yu 发送时间: Monday, November 21, 2016 2:13 PM
收件人: [email protected]
抄送: Yu, Xiangliang
主题: [PATCH 1/2] amdgpu: fix firmware loading failure

For virtualization, firmware loading need the firmware version info, and will load the right firmware. So, transfer fw_version to toc.

---
 drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c +1 -1
index 6df0d6e..c9bd1cf 100644
@@ -366,7 +366,7 @@ static int smu7_populate_single_firmware_entry(struct pp_smumgr *smumgr,
 				&info);
 
 	if (!result) {
-		entry->version = info.version;
+		entry->version = info.fw_version;
 		entry->id = (uint16_t)fw_type;
 		entry->image_addr_high = smu_upper_32_bits(info.mc_addr);
 		entry->image_addr_low = smu_lower_32_bits(info.mc_addr);

--
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): BY2PR12MB00542E2704514C13C42BA35F84B50-K//h7OWB4q7GdVlgMuSljQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org

#4 lore raw
Quoted 1 line

Please use "drm/amdgpu" as th prefix for the title

Ok.

Quoted 37 lines

-----邮件原件-----
发件人: amd-gfx [mailto:[email protected]] 代表 Xiangliang Yu
发送时间: Monday, November 21, 2016 2:13 PM
收件人: [email protected]
抄送: Yu, Xiangliang
主题: [PATCH 1/2] amdgpu: fix firmware loading failure

For virtualization, firmware loading need the firmware version info, and will load the right firmware. So, transfer fw_version to toc.

---
 drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c +1 -1
index 6df0d6e..c9bd1cf 100644
@@ -366,7 +366,7 @@ static int
 smu7_populate_single_firmware_entry(struct pp_smumgr *smumgr,
 				&info);
 
 	if (!result) {
-		entry->version = info.version;
+		entry->version = info.fw_version;
 		entry->id = (uint16_t)fw_type;
 		entry->image_addr_high =

smu_upper_32_bits(info.mc_addr);
entry->image_addr_low =
smu_lower_32_bits(info.mc_addr);
--
2.7.4

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#5 lore raw
In reply to a message not in the archive
Quoted 8 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Xiangliang Yu
Sent: Monday, November 21, 2016 1:13 AM
To: [email protected]
Cc: Yu, Xiangliang
Subject: [PATCH 1/2] amdgpu: fix firmware loading failure

Quoted 4 lines

For virtualization, firmware loading need the firmware version info, and will load the right firmware. So, transfer fw_version to toc.

With the title fixed as per Monk's suggestion, the series is:
Reviewed- by: Alex Deucher <[email protected]>

Quoted 24 lines
---
 drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c +1 -1
index 6df0d6e..c9bd1cf 100644
@@ -366,7 +366,7 @@ static int
 smu7_populate_single_firmware_entry(struct pp_smumgr *smumgr,
 				&info);
 
 	if (!result) {
-		entry->version = info.version;
+		entry->version = info.fw_version;
 		entry->id = (uint16_t)fw_type;
 		entry->image_addr_high =

smu_upper_32_bits(info.mc_addr);
entry->image_addr_low =
smu_lower_32_bits(info.mc_addr);
--
2.7.4

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx