Skip to contentSkip to conversation

Patch "mfd: intel-lpss: Do not put device in reset state on suspend" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Nov 21, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

mfd: intel-lpss: Do not put device in reset state on suspend

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mfd-intel-lpss-do-not-put-device-in-reset-state-on-suspend.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 274e43edcda6f709aa67e436b3123e45a6270923 Mon Sep 17 00:00:00 2001

From: Azhar Shaikh <[email protected]>
Date: Wed, 12 Oct 2016 10:12:20 -0700
Subject: mfd: intel-lpss: Do not put device in reset state on suspend

From: Azhar Shaikh <[email protected]>

commit 274e43edcda6f709aa67e436b3123e45a6270923 upstream.

Commit 41a3da2b8e163 ("mfd: intel-lpss: Save register context on suspend") saved the register context while going to suspend and also put the device in reset state.

Due to the resetting of device, system cannot enter S3/S0ix states when no_console_suspend flag is enabled. The system and serial console both hang. The resetting of device is not needed while going to suspend. Hence remove this code.

Fixes 41a3da2b8e163 ("mfd: intel-lpss: Save register context on suspend")
---
 drivers/mfd/intel-lpss.c |    3 ---
 1 file changed, 3 deletions(-)
drivers/mfd/intel-lpss.c +0 -3
@@ -494,9 +494,6 @@ int intel_lpss_suspend(struct device *de
 	for (i = 0; i < LPSS_PRIV_REG_COUNT; i++)
 		lpss->priv_ctx[i] = readl(lpss->priv + i * 4);
 
-	/* Put the device into reset state */
-	writel(0, lpss->priv + LPSS_PRIV_RESETS);
-
 	return 0;
 }
 EXPORT_SYMBOL_GPL(intel_lpss_suspend);

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/mfd-intel-lpss-do-not-put-device-in-reset-state-on-suspend.patch