Skip to contentSkip to conversation

Patch "PM / sleep: fix device reference leak in test_suspend" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Nov 21, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

PM / sleep: fix device reference leak in test_suspend

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
pm-sleep-fix-device-reference-leak-in-test_suspend.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From ceb75787bc75d0a7b88519ab8a68067ac690f55a Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Tue, 1 Nov 2016 11:49:56 +0100
Subject: PM / sleep: fix device reference leak in test_suspend

From: Johan Hovold <[email protected]>

commit ceb75787bc75d0a7b88519ab8a68067ac690f55a upstream.

Make sure to drop the reference taken by class_find_device() after opening the RTC device.

Fixes 77437fd4e61f (pm: boot time suspend selftest)
---
 kernel/power/suspend_test.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
kernel/power/suspend_test.c +3 -1
@@ -203,8 +203,10 @@ static int __init test_suspend(void)
 
 	/* RTCs have initialized by now too ... can we use one? */
 	dev = class_find_device(rtc_class, NULL, NULL, has_wakealarm);
-	if (dev)
+	if (dev) {
 		rtc = rtc_class_open(dev_name(dev));
+		put_device(dev);
+	}
 	if (!rtc) {
 		printk(warn_no_rtc);
 		return 0;

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/mfd-core-fix-device-reference-leak-in-mfd_clone_cell.patch queue-4.8/pm-sleep-fix-device-reference-leak-in-test_suspend.patch queue-4.8/uwb-fix-device-reference-leaks.patch