Skip to contentSkip to conversation

ASoC: wm_adsp: Only write shutdown controls for active firmwares

PATCH In review Charles Keepax 2 participants 2 messages Nov 21, 2016

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: wm_adsp: Only write shutdown controls for active firmwares

The control list may contain shutdown controls for firmwares that are not currently active, attempting to write this will at best fail. To avoid this issue we skip any control that is not active.

Fixes commit f4f0c4c60c39 ("ASoC: wm_adsp: Signal firmware shutdown

through event control")

---
 sound/soc/codecs/wm_adsp.c | 3 +++
 1 file changed, 3 insertions(+)
sound/soc/codecs/wm_adsp.c +3 -0
index 4fb6e2f..6ccb731 100644
@@ -1194,6 +1194,9 @@ static void wm_adsp_signal_event_controls(struct wm_adsp *dsp,
 		if (ctl->type != WMFW_CTL_TYPE_HOSTEVENT)
 			continue;
 
+		if (!ctl->enabled)
+			continue;
+
 		ret = wm_coeff_write_acked_control(ctl, event);
 		if (ret)
 			adsp_warn(dsp,
Signature · 1 line
2.1.4
maintainer
#1 lore raw

Applied "ASoC: wm_adsp: Only write shutdown controls for active firmwares" to the asoc tree

The patch

ASoC: wm_adsp: Only write shutdown controls for active firmwares

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 87aa63746260e3e9db2fe6b6d8e97b55bdb63a2b Mon Sep 17 00:00:00 2001

From: Charles Keepax <[email protected]>
Date: Mon, 21 Nov 2016 18:00:02 +0000
Subject: [PATCH] ASoC: wm_adsp: Only write shutdown controls for active
firmwares

The control list may contain shutdown controls for firmwares that are not currently active, attempting to write this will at best fail. To avoid this issue we skip any control that is not active.

Fixes commit f4f0c4c60c39 ("ASoC: wm_adsp: Signal firmware shutdown

through event control")

---
 sound/soc/codecs/wm_adsp.c | 3 +++
 1 file changed, 3 insertions(+)
sound/soc/codecs/wm_adsp.c +3 -0
index 4fb6e2f035e0..6ccb7313a0f6 100644
@@ -1194,6 +1194,9 @@ static void wm_adsp_signal_event_controls(struct wm_adsp *dsp,
 		if (ctl->type != WMFW_CTL_TYPE_HOSTEVENT)
 			continue;
 
+		if (!ctl->enabled)
+			continue;
+
 		ret = wm_coeff_write_acked_control(ctl, event);
 		if (ret)
 			adsp_warn(dsp,
Signature · 1 line
2.10.2