Skip to contentSkip to conversation

drm/amdgpu: remove error message when loading driver

PATCH In review Xiangliang Yu 2 participants 2 messages Nov 22, 2016 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 2/2 drm/amdgpu: remove error message when loading driver

Forget to check UCODE_ID_STORAGE case and will cause to print error message when loading driver, corret it.

v2: use "drm/amdgpu" as the prefix for patch tile.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c +4 -2
index 7ded61e..9ada56c 100755
@@ -723,7 +723,7 @@ static uint16_t amdgpu_get_firmware_version(struct cgs_device *cgs_device,
 					enum cgs_ucode_id type)
 {
 	CGS_FUNC_ADEV;
-	uint16_t fw_version;
+	uint16_t fw_version = 0;
 
 	switch (type) {
 		case CGS_UCODE_ID_SDMA0:
@@ -753,9 +753,11 @@ static uint16_t amdgpu_get_firmware_version(struct cgs_device *cgs_device,
 		case CGS_UCODE_ID_RLC_G:
 			fw_version = adev->gfx.rlc_fw_version;
 			break;
+		case CGS_UCODE_ID_STORAGE:
+			break;
 		default:
 			DRM_ERROR("firmware type %d do not have version\n", type);
-			fw_version = 0;
+			break;
 	}
 	return fw_version;
 }
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1479783736-4233-1-git-send-email-Xiangliang.Yu-5C7GfCeVMHo@public.gmane.org

Reviewed-by Alex Deucher
#2 lore raw
Quoted 9 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Xiangliang Yu
Sent: Monday, November 21, 2016 10:02 PM
To: [email protected]
Cc: Yu, Xiangliang
Subject: [Patch v2 2/2] drm/amdgpu: remove error message when loading driver

Quoted 6 lines

Forget to check UCODE_ID_STORAGE case and will cause to print error message when loading driver, corret it.

v2: use "drm/amdgpu" as the prefix for patch tile.

Quoted 37 lines
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c +1 -1
index 7ded61e..9ada56c 100755
@@ -723,7 +723,7 @@ static uint16_t amdgpu_get_firmware_version(struct
 cgs_device *cgs_device,
 					enum cgs_ucode_id type)
 {
 	CGS_FUNC_ADEV;
-	uint16_t fw_version;
+	uint16_t fw_version = 0;
 
 	switch (type) {
drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c +3 -1
 		case CGS_UCODE_ID_SDMA0:
@@ -753,9 +753,11 @@ static uint16_t
 amdgpu_get_firmware_version(struct cgs_device *cgs_device,
 		case CGS_UCODE_ID_RLC_G:
 			fw_version = adev->gfx.rlc_fw_version;
 			break;
+		case CGS_UCODE_ID_STORAGE:
+			break;
 		default:
 			DRM_ERROR("firmware type %d do not have
 version\n", type);
-			fw_version = 0;
+			break;
 	}

return fw_version;
}
--
2.7.4

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx