Skip to contentSkip to conversation

ASoC: ab8500: Remove explicit initialization of driver callbacks to NULL

PATCH In review Lars-Peter Clausen 2 participants 2 messages Nov 22, 2016 – Nov 23, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: ab8500: Remove explicit initialization of driver callbacks to NULL

Fields of structs with global storage are implicitly initialized to 0/NULL, there is usually no need to do this explicitly.

Removing the initialization of the legacy suspend/resume callback fields also gets the driver ready for the day when they are eventually removed.

---
 sound/soc/codecs/ab8500-codec.c | 2 --
 1 file changed, 2 deletions(-)
sound/soc/codecs/ab8500-codec.c +0 -2
index 935ff7c..312b2a1 100644
@@ -2587,8 +2587,6 @@ static struct platform_driver ab8500_codec_platform_driver = {
 	},
 	.probe		= ab8500_codec_driver_probe,
 	.remove		= ab8500_codec_driver_remove,
-	.suspend	= NULL,
-	.resume		= NULL,
 };
 module_platform_driver(ab8500_codec_platform_driver);
 
Signature · 1 line
2.1.4
maintainer
#1 lore raw

Applied "ASoC: ab8500: Remove explicit initialization of driver callbacks to NULL" to the asoc tree

The patch

ASoC: ab8500: Remove explicit initialization of driver callbacks to NULL

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 0a69516cd8b9878c4040c35294443ac18338febd Mon Sep 17 00:00:00 2001

From: Lars-Peter Clausen <[email protected]>
Date: Tue, 22 Nov 2016 22:49:48 +0100
Subject: [PATCH] ASoC: ab8500: Remove explicit initialization of driver
callbacks to NULL

Fields of structs with global storage are implicitly initialized to 0/NULL, there is usually no need to do this explicitly.

Removing the initialization of the legacy suspend/resume callback fields also gets the driver ready for the day when they are eventually removed.

---
 sound/soc/codecs/ab8500-codec.c | 2 --
 1 file changed, 2 deletions(-)
sound/soc/codecs/ab8500-codec.c +0 -2
index 935ff7cb71c5..312b2a11abb6 100644
@@ -2587,8 +2587,6 @@ static struct platform_driver ab8500_codec_platform_driver = {
 	},
 	.probe		= ab8500_codec_driver_probe,
 	.remove		= ab8500_codec_driver_remove,
-	.suspend	= NULL,
-	.resume		= NULL,
 };
 module_platform_driver(ab8500_codec_platform_driver);
 
Signature · 1 line
2.10.2