drm/i915: Pass dev_priv to intel_setup_outputs()
Subsystems (2)
PATCH 1/1 drm/i915: Pass dev_priv to intel_setup_outputs()
Pass dev_priv to intel_setup_outputs() and functions called by it, since those are all intel i915 specific functions. Also, in the majority of the functions dev_priv is used more often than dev. In the rare cases where there are a few calls back into drm core, a local dev variable was added.
--- drivers/gpu/drm/i915/i915_drv.c | 4 +- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_crt.c | 7 +- drivers/gpu/drm/i915/intel_ddi.c | 5 +- drivers/gpu/drm/i915/intel_display.c | 120 ++++++++++++++++------------------- drivers/gpu/drm/i915/intel_dp.c | 8 +-- drivers/gpu/drm/i915/intel_drv.h | 22 ++++--- drivers/gpu/drm/i915/intel_dsi.c | 8 +-- drivers/gpu/drm/i915/intel_dvo.c | 9 ++- drivers/gpu/drm/i915/intel_hdmi.c | 8 +-- drivers/gpu/drm/i915/intel_lvds.c | 4 +- drivers/gpu/drm/i915/intel_psr.c | 4 +- drivers/gpu/drm/i915/intel_sdvo.c | 19 +++--- drivers/gpu/drm/i915/intel_tv.c | 4 +- 14 files changed, 107 insertions(+), 117 deletions(-)
drivers/gpu/drm/i915/i915_drv.c +2 -2
@@ -1571,7 +1571,7 @@ static int i915_drm_resume(struct drm_device *dev)intel_pps_unlock_regs_wa (dev_priv);intel_opregion_setup (dev_priv); -intel_init_pch_refclk (dev); +intel_init_pch_refclk (dev_priv);drm_mode_config_reset (dev);/*
@@ -2408,7 +2408,7 @@ static int intel_runtime_resume(struct device *kdev)intel_guc_resume (dev);if (IS_GEN6 (dev_priv)) -intel_init_pch_refclk (dev); +intel_init_pch_refclk (dev_priv);if (IS_BROXTON (dev_priv)) {bxt_disable_dc9 (dev_priv);
drivers/gpu/drm/i915/i915_drv.h +1 -1
@@ -3487,7 +3487,7 @@ extern void intel_display_resume(struct drm_device *dev);extern void i915_redisable_vga (struct drm_i915_private *dev_priv);extern void i915_redisable_vga_power_on (struct drm_i915_private *dev_priv);extern bool ironlake_set_drps (struct drm_i915_private *dev_priv,u8 val); -extern void intel_init_pch_refclk (struct drm_device *dev); +extern void intel_init_pch_refclk (struct drm_i915_private *dev_priv);extern void intel_set_rps (struct drm_i915_private *dev_priv,u8 val);extern void intel_set_memory_cxsr (struct drm_i915_private *dev_priv,bool enable);
drivers/gpu/drm/i915/intel_crt.c +3 -4
@@ -836,12 +836,11 @@ static const struct drm_encoder_funcs intel_crt_enc_funcs = { .destroy = intel_encoder_destroy, }; -void intel_crt_init (struct drm_device *dev) +void intel_crt_init (struct drm_i915_private *dev_priv) {struct drm_connector *connector;struct intel_crt *crt;struct intel_connector *intel_connector; -struct drm_i915_private *dev_priv =to_i915 (dev);i915_reg_t adpa_reg;u32 adpa;
@@ -881,10 +880,10 @@ void intel_crt_init(struct drm_device *dev) connector = &intel_connector->base; crt->connector = intel_connector; -drm_connector_init (dev, &intel_connector->base, +drm_connector_init (&dev_priv->drm, &intel_connector->base, &intel_crt_connector_funcs,DRM_MODE_CONNECTOR_VGA ); -drm_encoder_init (dev, &crt->base.base, &intel_crt_enc_funcs, +drm_encoder_init (&dev_priv->drm, &crt->base.base, &intel_crt_enc_funcs,DRM_MODE_ENCODER_DAC ,"CRT" );intel_connector_attach_encoder (intel_connector, &crt->base);
drivers/gpu/drm/i915/intel_ddi.c +2 -3
@@ -2154,9 +2154,8 @@ intel_ddi_get_link_dpll(struct intel_dp *intel_dp, int clock)return pll; } -void intel_ddi_init (struct drm_device *dev,enum port port) +void intel_ddi_init (struct drm_i915_private *dev_priv,enum port port) { -struct drm_i915_private *dev_priv =to_i915 (dev);struct intel_digital_port *intel_dig_port;struct intel_encoder *intel_encoder;struct drm_encoder *encoder;
@@ -2218,7 +2217,7 @@ void intel_ddi_init(struct drm_device *dev, enum port port) intel_encoder = &intel_dig_port->base; encoder = &intel_encoder->base; -drm_encoder_init (dev, encoder, &intel_ddi_funcs, +drm_encoder_init (&dev_priv->drm, encoder, &intel_ddi_funcs,DRM_MODE_ENCODER_TMDS ,"DDI %c" ,port_name (port)); intel_encoder->compute_config = intel_ddi_compute_config;
drivers/gpu/drm/i915/intel_display.c +56 -64
322 lines not on this page · raw message
drivers/gpu/drm/i915/intel_dp.c +4 -4
@@ -5766,11 +5766,10 @@ intel_dp_init_connector(struct intel_digital_port *intel_dig_port,return false; } -bool intel_dp_init (struct drm_device *dev, +bool intel_dp_init (struct drm_i915_private *dev_priv,i915_reg_t output_reg,enum port port) { -struct drm_i915_private *dev_priv =to_i915 (dev);struct intel_digital_port *intel_dig_port;struct intel_encoder *intel_encoder;struct drm_encoder *encoder;
@@ -5787,8 +5786,9 @@ bool intel_dp_init(struct drm_device *dev, intel_encoder = &intel_dig_port->base; encoder = &intel_encoder->base; -if (drm_encoder_init (dev, &intel_encoder->base, &intel_dp_enc_funcs, -DRM_MODE_ENCODER_TMDS ,"DP %c" ,port_name (port))) +if (drm_encoder_init (&dev_priv->drm, &intel_encoder->base, + &intel_dp_enc_funcs,DRM_MODE_ENCODER_TMDS , +"DP %c" ,port_name (port))) goto err_encoder_init; intel_encoder->compute_config = intel_dp_compute_config;
drivers/gpu/drm/i915/intel_drv.h +12 -10
@@ -1141,7 +1141,7 @@ void gen9_enable_guc_interrupts(struct drm_i915_private *dev_priv);void gen9_disable_guc_interrupts (struct drm_i915_private *dev_priv);/* intel_crt.c */ -void intel_crt_init (struct drm_device *dev); +void intel_crt_init (struct drm_i915_private *dev_priv);void intel_crt_reset (struct drm_encoder *encoder);/* intel_ddi.c */
@@ -1152,7 +1152,7 @@ void intel_ddi_fdi_post_disable(struct intel_encoder *intel_encoder, struct drm_connector_state *old_conn_state);void intel_prepare_dp_ddi_buffers (struct intel_encoder *encoder);void hsw_fdi_link_train (struct drm_crtc *crtc); -void intel_ddi_init (struct drm_device *dev,enum port port); +void intel_ddi_init (struct drm_i915_private *dev_priv,enum port port);enum port intel_ddi_get_encoder_port (struct intel_encoder *intel_encoder);bool intel_ddi_get_hw_state (struct intel_encoder *encoder,enum pipe *pipe);void intel_ddi_enable_transcoder_func (struct drm_crtc *crtc);
@@ -1377,7 +1377,8 @@ void intel_csr_ucode_suspend(struct drm_i915_private *);void intel_csr_ucode_resume (struct drm_i915_private *);/* intel_dp.c */ -bool intel_dp_init (struct drm_device *dev,i915_reg_t output_reg,enum port port); +bool intel_dp_init (struct drm_i915_private *dev_priv,i915_reg_t output_reg, +enum port port);bool intel_dp_init_connector (struct intel_digital_port *intel_dig_port,struct intel_connector *intel_connector); void intel_dp_set_link_params(struct intel_dp *intel_dp,
@@ -1452,13 +1453,13 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector);int intel_dp_mst_encoder_init (struct intel_digital_port *intel_dig_port,int conn_id);void intel_dp_mst_encoder_cleanup (struct intel_digital_port *intel_dig_port);/* intel_dsi.c */ -void intel_dsi_init (struct drm_device *dev); +void intel_dsi_init (struct drm_i915_private *dev_priv);/* intel_dsi_dcs_backlight.c */ int intel_dsi_dcs_init_backlight_funcs (struct intel_connector *intel_connector);/* intel_dvo.c */ -void intel_dvo_init (struct drm_device *dev); +void intel_dvo_init (struct drm_i915_private *dev_priv);/* intel_hotplug.c */ void intel_hpd_poll_init (struct drm_i915_private *dev_priv);
@@ -1522,7 +1523,8 @@ void intel_fbc_cleanup_cfb(struct drm_i915_private *dev_priv);void intel_fbc_handle_fifo_underrun_irq (struct drm_i915_private *dev_priv);/* intel_hdmi.c */ -void intel_hdmi_init (struct drm_device *dev,i915_reg_t hdmi_reg,enum port port); +void intel_hdmi_init (struct drm_i915_private *dev_priv,i915_reg_t hdmi_reg, +enum port port);void intel_hdmi_init_connector (struct intel_digital_port *intel_dig_port,struct intel_connector *intel_connector);struct intel_hdmi *enc_to_intel_hdmi (struct drm_encoder *encoder);
@@ -1533,7 +1535,7 @@ void intel_dp_dual_mode_set_tmds_output(struct intel_hdmi *hdmi, bool enable);/* intel_lvds.c */ -void intel_lvds_init (struct drm_device *dev); +void intel_lvds_init (struct drm_i915_private *dev_priv);struct intel_encoder *intel_get_lvds_encoder (struct drm_device *dev);bool intel_is_dual_link_lvds (struct drm_device *dev);
@@ -1606,7 +1608,7 @@ void intel_psr_invalidate(struct drm_i915_private *dev_priv,void intel_psr_flush (struct drm_i915_private *dev_priv,unsigned frontbuffer_bits,enum fb_op_origin origin); -void intel_psr_init (struct drm_device *dev); +void intel_psr_init (struct drm_i915_private *dev_priv);void intel_psr_single_frame_update (struct drm_i915_private *dev_priv,unsigned frontbuffer_bits);
@@ -1751,7 +1753,7 @@ static inline int intel_enable_rc6(void) }/* intel_sdvo.c */ -bool intel_sdvo_init (struct drm_device *dev, +bool intel_sdvo_init (struct drm_i915_private *dev_priv,i915_reg_t reg,enum port port);
@@ -1766,7 +1768,7 @@ void intel_pipe_update_start(struct intel_crtc *crtc);void intel_pipe_update_end (struct intel_crtc *crtc,struct intel_flip_work *work);/* intel_tv.c */ -void intel_tv_init (struct drm_device *dev); +void intel_tv_init (struct drm_i915_private *dev_priv);/* intel_atomic.c */ int intel_connector_atomic_get_property(struct drm_connector *connector,
drivers/gpu/drm/i915/intel_dsi.c +4 -4
@@ -1431,15 +1431,15 @@ static void intel_dsi_add_properties(struct intel_connector *connector) } } -void intel_dsi_init (struct drm_device *dev) +void intel_dsi_init (struct drm_i915_private *dev_priv) { +struct drm_device *dev = &dev_priv->drm;struct intel_dsi *intel_dsi;struct intel_encoder *intel_encoder;struct drm_encoder *encoder;struct intel_connector *intel_connector;struct drm_connector *connector;struct drm_display_mode *scan, *fixed_mode =NULL ; -struct drm_i915_private *dev_priv =to_i915 (dev);enum port port;unsigned int i;
@@ -1474,8 +1474,8 @@ void intel_dsi_init(struct drm_device *dev) connector = &intel_connector->base; -drm_encoder_init (dev, encoder, &intel_dsi_funcs,DRM_MODE_ENCODER_DSI , -"DSI %c" ,port_name (port)); +drm_encoder_init (&dev_priv->drm, encoder, &intel_dsi_funcs, +DRM_MODE_ENCODER_DSI ,"DSI %c" ,port_name (port)); intel_encoder->compute_config = intel_dsi_compute_config; intel_encoder->pre_enable = intel_dsi_pre_enable;
drivers/gpu/drm/i915/intel_dvo.c +4 -5
@@ -422,9 +422,8 @@ static enum port intel_dvo_port(i915_reg_t dvo_reg)return PORT_C ; } -void intel_dvo_init (struct drm_device *dev) +void intel_dvo_init (struct drm_i915_private *dev_priv) { -struct drm_i915_private *dev_priv =to_i915 (dev);struct intel_encoder *intel_encoder;struct intel_dvo *intel_dvo;struct intel_connector *intel_connector;
@@ -511,7 +510,7 @@ void intel_dvo_init(struct drm_device *dev)continue ; port =intel_dvo_port (dvo->dvo_reg); -drm_encoder_init (dev, &intel_encoder->base, +drm_encoder_init (&dev_priv->drm, &intel_encoder->base, &intel_dvo_enc_funcs, encoder_type,"DVO %c" ,port_name (port));
@@ -523,14 +522,14 @@ void intel_dvo_init(struct drm_device *dev)case INTEL_DVO_CHIP_TMDS : intel_encoder->cloneable = (1 <<INTEL_OUTPUT_ANALOG ) | (1 <<INTEL_OUTPUT_DVO ); -drm_connector_init (dev, connector, +drm_connector_init (&dev_priv->drm, connector, &intel_dvo_connector_funcs,DRM_MODE_CONNECTOR_DVII ); encoder_type =DRM_MODE_ENCODER_TMDS ;break ;case INTEL_DVO_CHIP_LVDS : intel_encoder->cloneable =0 ; -drm_connector_init (dev, connector, +drm_connector_init (&dev_priv->drm, connector, &intel_dvo_connector_funcs,DRM_MODE_CONNECTOR_LVDS ); encoder_type =DRM_MODE_ENCODER_LVDS ;
drivers/gpu/drm/i915/intel_hdmi.c +4 -4
@@ -1933,10 +1933,9 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, } } -void intel_hdmi_init (struct drm_device *dev, +void intel_hdmi_init (struct drm_i915_private *dev_priv,i915_reg_t hdmi_reg,enum port port) { -struct drm_i915_private *dev_priv =to_i915 (dev);struct intel_digital_port *intel_dig_port;struct intel_encoder *intel_encoder;struct intel_connector *intel_connector;
@@ -1953,8 +1952,9 @@ void intel_hdmi_init(struct drm_device *dev, intel_encoder = &intel_dig_port->base; -drm_encoder_init (dev, &intel_encoder->base, &intel_hdmi_enc_funcs, -DRM_MODE_ENCODER_TMDS ,"HDMI %c" ,port_name (port)); +drm_encoder_init (&dev_priv->drm, &intel_encoder->base, + &intel_hdmi_enc_funcs,DRM_MODE_ENCODER_TMDS , +"HDMI %c" ,port_name (port)); intel_encoder->compute_config = intel_hdmi_compute_config;if (HAS_PCH_SPLIT (dev_priv)) {
drivers/gpu/drm/i915/intel_lvds.c +2 -2
@@ -971,9 +971,9 @@ static bool intel_lvds_supported(struct drm_i915_private *dev_priv)* Create the connector, register the LVDS DDC bus, and try to figure out what * modes we can display on the LVDS panel (if present). */ -void intel_lvds_init (struct drm_device *dev) +void intel_lvds_init (struct drm_i915_private *dev_priv) { -struct drm_i915_private *dev_priv =to_i915 (dev); +struct drm_device *dev = &dev_priv->drm;struct intel_lvds_encoder *lvds_encoder;struct intel_encoder *intel_encoder;struct intel_lvds_connector *lvds_connector;
drivers/gpu/drm/i915/intel_psr.c +1 -3
@@ -818,10 +818,8 @@ void intel_psr_flush(struct drm_i915_private *dev_priv,* This function is called only once at driver load to initialize basic * PSR stuff. */ -void intel_psr_init (struct drm_device *dev) +void intel_psr_init (struct drm_i915_private *dev_priv) { -struct drm_i915_private *dev_priv =to_i915 (dev); - dev_priv->psr_mmio_base =IS_HASWELL (dev_priv) ?HSW_EDP_PSR_BASE :BDW_EDP_PSR_BASE ;
drivers/gpu/drm/i915/intel_sdvo.c +10 -9
@@ -2342,9 +2342,9 @@ intel_sdvo_is_hdmi_connector(struct intel_sdvo *intel_sdvo, int device) }static u8 -intel_sdvo_get_slave_addr (struct drm_device *dev,struct intel_sdvo *sdvo) +intel_sdvo_get_slave_addr (struct drm_i915_private *dev_priv, +struct intel_sdvo *sdvo) { -struct drm_i915_private *dev_priv =to_i915 (dev);struct sdvo_device_mapping *my_mapping, *other_mapping;if (sdvo->port ==PORT_B ) {
@@ -2934,9 +2934,9 @@ static const struct i2c_algorithm intel_sdvo_ddc_proxy = {static bool intel_sdvo_init_ddc_proxy (struct intel_sdvo *sdvo, -struct drm_device *dev) +struct drm_i915_private *dev_priv) { -struct pci_dev *pdev = dev->pdev; +struct pci_dev *pdev = dev_priv->drm.pdev; sdvo->ddc.owner =THIS_MODULE ; sdvo->ddc.class =I2C_CLASS_DDC ;
@@ -2957,10 +2957,9 @@ static void assert_sdvo_port_valid(const struct drm_i915_private *dev_priv,WARN_ON (port !=PORT_B && port !=PORT_C ); } -bool intel_sdvo_init (struct drm_device *dev, +bool intel_sdvo_init (struct drm_i915_private *dev_priv,i915_reg_t sdvo_reg,enum port port) { -struct drm_i915_private *dev_priv =to_i915 (dev);struct intel_encoder *intel_encoder;struct intel_sdvo *intel_sdvo;int i;
@@ -2973,16 +2972,18 @@ bool intel_sdvo_init(struct drm_device *dev, intel_sdvo->sdvo_reg = sdvo_reg; intel_sdvo->port = port; - intel_sdvo->slave_addr =intel_sdvo_get_slave_addr (dev, intel_sdvo) >>1 ; + intel_sdvo->slave_addr = +intel_sdvo_get_slave_addr (dev_priv, intel_sdvo) >>1 ;intel_sdvo_select_i2c_bus (dev_priv, intel_sdvo); -if (!intel_sdvo_init_ddc_proxy (intel_sdvo, dev)) +if (!intel_sdvo_init_ddc_proxy (intel_sdvo, dev_priv)) goto err_i2c_bus;/* encoder type will be decided later */ intel_encoder = &intel_sdvo->base; intel_encoder->type =INTEL_OUTPUT_SDVO ; intel_encoder->port = port; -drm_encoder_init (dev, &intel_encoder->base, &intel_sdvo_enc_funcs,0 , +drm_encoder_init (&dev_priv->drm, &intel_encoder->base, + &intel_sdvo_enc_funcs,0 ,"SDVO %c" ,port_name (port));/* Read the regs to test if we can talk to the device */
drivers/gpu/drm/i915/intel_tv.c +2 -2
@@ -1537,9 +1537,9 @@ static const struct drm_encoder_funcs intel_tv_enc_funcs = { };void -intel_tv_init (struct drm_device *dev) +intel_tv_init (struct drm_i915_private *dev_priv) { -struct drm_i915_private *dev_priv =to_i915 (dev); +struct drm_device *dev = &dev_priv->drm;struct drm_connector *connector;struct intel_tv *intel_tv;struct intel_encoder *intel_encoder;
Signature · 6 lines
2.5.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 24 lines · Ander Conselvan de Oliveira
Pass
dev_privtointel_setup_outputs()and functions called by it, since those are all intel i915 specific functions. Also, in the majority of the functionsdev_privis used more often than dev. In the rare cases where there are a few calls back into drm core, a local dev variable was added.Signed-off-by Ander Conselvan de Oliveira <[email protected]>--- drivers/gpu/drm/i915/i915_drv.c | 4 +- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_crt.c | 7 +- drivers/gpu/drm/i915/intel_ddi.c | 5 +- drivers/gpu/drm/i915/intel_display.c | 120 ++++++++++++++++------------------- drivers/gpu/drm/i915/intel_dp.c | 8 +-- drivers/gpu/drm/i915/intel_drv.h | 22 ++++--- drivers/gpu/drm/i915/intel_dsi.c | 8 +-- drivers/gpu/drm/i915/intel_dvo.c | 9 ++- drivers/gpu/drm/i915/intel_hdmi.c | 8 +-- drivers/gpu/drm/i915/intel_lvds.c | 4 +- drivers/gpu/drm/i915/intel_psr.c | 4 +- drivers/gpu/drm/i915/intel_sdvo.c | 19 +++--- drivers/gpu/drm/i915/intel_tv.c | 4 +- 14 files changed, 107 insertions(+), 117 deletions(-)
<snip>
Quoted 23 lines
drivers/gpu/drm/i915/intel_dsi.c +2
-2@@ -1431,15 +1431,15 @@ static void intel_dsi_add_properties(struct intel_connector *connector) } } -void intel_dsi_init (struct drm_device *dev) +void intel_dsi_init (struct drm_i915_private *dev_priv) { +struct drm_device *dev = &dev_priv->drm;struct intel_dsi *intel_dsi;struct intel_encoder *intel_encoder;struct drm_encoder *encoder;struct intel_connector *intel_connector;struct drm_connector *connector;struct drm_display_mode *scan, *fixed_mode =NULL ; -struct drm_i915_private *dev_priv =to_i915 (dev);enum port port;unsigned int i;
drivers/gpu/drm/i915/intel_dsi.c void intel_dsi_init(struct drm_device *dev) · line 1478
Quoted 7 lines
drivers/gpu/drm/i915/intel_dsi.c +2
-2@@ -1474,8 +1474,8 @@ void intel_dsi_init(struct drm_device *dev) connector = &intel_connector->base; -drm_encoder_init (dev, encoder, &intel_dsi_funcs,DRM_MODE_ENCODER_DSI , -"DSI %c" ,port_name (port)); +drm_encoder_init (&dev_priv->drm, encoder, &intel_dsi_funcs, +DRM_MODE_ENCODER_DSI ,"DSI %c" ,port_name (port));
Here you have introduced a local 'dev', so this hunk doesn't seem necessary. But no biggie. Patch lgtm.
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 1/1 drm/i915: Pass dev_priv to intel_setup_outputs()
Pass dev_priv to intel_setup_outputs() and functions called by it, since those are all intel i915 specific functions. Also, in the majority of the functions dev_priv is used more often than dev. In the rare cases where there are a few calls back into drm core, a local dev variable was added.
v2: Don't convert dev to &dev_priv->drm in intel_dsi_init. (Ville)
--- drivers/gpu/drm/i915/i915_drv.c | 4 +- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_crt.c | 7 +- drivers/gpu/drm/i915/intel_ddi.c | 5 +- drivers/gpu/drm/i915/intel_display.c | 120 ++++++++++++++++------------------- drivers/gpu/drm/i915/intel_dp.c | 8 +-- drivers/gpu/drm/i915/intel_drv.h | 22 ++++--- drivers/gpu/drm/i915/intel_dsi.c | 4 +- drivers/gpu/drm/i915/intel_dvo.c | 9 ++- drivers/gpu/drm/i915/intel_hdmi.c | 8 +-- drivers/gpu/drm/i915/intel_lvds.c | 4 +- drivers/gpu/drm/i915/intel_psr.c | 4 +- drivers/gpu/drm/i915/intel_sdvo.c | 19 +++--- drivers/gpu/drm/i915/intel_tv.c | 4 +- 14 files changed, 105 insertions(+), 115 deletions(-)
drivers/gpu/drm/i915/i915_drv.c +2 -2
@@ -1571,7 +1571,7 @@ static int i915_drm_resume(struct drm_device *dev)intel_pps_unlock_regs_wa (dev_priv);intel_opregion_setup (dev_priv); -intel_init_pch_refclk (dev); +intel_init_pch_refclk (dev_priv);drm_mode_config_reset (dev);/*
@@ -2408,7 +2408,7 @@ static int intel_runtime_resume(struct device *kdev)intel_guc_resume (dev);if (IS_GEN6 (dev_priv)) -intel_init_pch_refclk (dev); +intel_init_pch_refclk (dev_priv);if (IS_BROXTON (dev_priv)) {bxt_disable_dc9 (dev_priv);
drivers/gpu/drm/i915/i915_drv.h +1 -1
@@ -3487,7 +3487,7 @@ extern void intel_display_resume(struct drm_device *dev);extern void i915_redisable_vga (struct drm_i915_private *dev_priv);extern void i915_redisable_vga_power_on (struct drm_i915_private *dev_priv);extern bool ironlake_set_drps (struct drm_i915_private *dev_priv,u8 val); -extern void intel_init_pch_refclk (struct drm_device *dev); +extern void intel_init_pch_refclk (struct drm_i915_private *dev_priv);extern void intel_set_rps (struct drm_i915_private *dev_priv,u8 val);extern void intel_set_memory_cxsr (struct drm_i915_private *dev_priv,bool enable);
drivers/gpu/drm/i915/intel_crt.c +3 -4
@@ -836,12 +836,11 @@ static const struct drm_encoder_funcs intel_crt_enc_funcs = { .destroy = intel_encoder_destroy, }; -void intel_crt_init (struct drm_device *dev) +void intel_crt_init (struct drm_i915_private *dev_priv) {struct drm_connector *connector;struct intel_crt *crt;struct intel_connector *intel_connector; -struct drm_i915_private *dev_priv =to_i915 (dev);i915_reg_t adpa_reg;u32 adpa;
@@ -881,10 +880,10 @@ void intel_crt_init(struct drm_device *dev) connector = &intel_connector->base; crt->connector = intel_connector; -drm_connector_init (dev, &intel_connector->base, +drm_connector_init (&dev_priv->drm, &intel_connector->base, &intel_crt_connector_funcs,DRM_MODE_CONNECTOR_VGA ); -drm_encoder_init (dev, &crt->base.base, &intel_crt_enc_funcs, +drm_encoder_init (&dev_priv->drm, &crt->base.base, &intel_crt_enc_funcs,DRM_MODE_ENCODER_DAC ,"CRT" );intel_connector_attach_encoder (intel_connector, &crt->base);
drivers/gpu/drm/i915/intel_ddi.c +2 -3
@@ -2154,9 +2154,8 @@ intel_ddi_get_link_dpll(struct intel_dp *intel_dp, int clock)return pll; } -void intel_ddi_init (struct drm_device *dev,enum port port) +void intel_ddi_init (struct drm_i915_private *dev_priv,enum port port) { -struct drm_i915_private *dev_priv =to_i915 (dev);struct intel_digital_port *intel_dig_port;struct intel_encoder *intel_encoder;struct drm_encoder *encoder;
@@ -2218,7 +2217,7 @@ void intel_ddi_init(struct drm_device *dev, enum port port) intel_encoder = &intel_dig_port->base; encoder = &intel_encoder->base; -drm_encoder_init (dev, encoder, &intel_ddi_funcs, +drm_encoder_init (&dev_priv->drm, encoder, &intel_ddi_funcs,DRM_MODE_ENCODER_TMDS ,"DDI %c" ,port_name (port)); intel_encoder->compute_config = intel_ddi_compute_config;
drivers/gpu/drm/i915/intel_display.c +56 -64
322 lines not on this page · raw message
drivers/gpu/drm/i915/intel_dp.c +4 -4
@@ -5766,11 +5766,10 @@ intel_dp_init_connector(struct intel_digital_port *intel_dig_port,return false; } -bool intel_dp_init (struct drm_device *dev, +bool intel_dp_init (struct drm_i915_private *dev_priv,i915_reg_t output_reg,enum port port) { -struct drm_i915_private *dev_priv =to_i915 (dev);struct intel_digital_port *intel_dig_port;struct intel_encoder *intel_encoder;struct drm_encoder *encoder;
@@ -5787,8 +5786,9 @@ bool intel_dp_init(struct drm_device *dev, intel_encoder = &intel_dig_port->base; encoder = &intel_encoder->base; -if (drm_encoder_init (dev, &intel_encoder->base, &intel_dp_enc_funcs, -DRM_MODE_ENCODER_TMDS ,"DP %c" ,port_name (port))) +if (drm_encoder_init (&dev_priv->drm, &intel_encoder->base, + &intel_dp_enc_funcs,DRM_MODE_ENCODER_TMDS , +"DP %c" ,port_name (port))) goto err_encoder_init; intel_encoder->compute_config = intel_dp_compute_config;
drivers/gpu/drm/i915/intel_drv.h +12 -10
@@ -1141,7 +1141,7 @@ void gen9_enable_guc_interrupts(struct drm_i915_private *dev_priv);void gen9_disable_guc_interrupts (struct drm_i915_private *dev_priv);/* intel_crt.c */ -void intel_crt_init (struct drm_device *dev); +void intel_crt_init (struct drm_i915_private *dev_priv);void intel_crt_reset (struct drm_encoder *encoder);/* intel_ddi.c */
@@ -1152,7 +1152,7 @@ void intel_ddi_fdi_post_disable(struct intel_encoder *intel_encoder, struct drm_connector_state *old_conn_state);void intel_prepare_dp_ddi_buffers (struct intel_encoder *encoder);void hsw_fdi_link_train (struct drm_crtc *crtc); -void intel_ddi_init (struct drm_device *dev,enum port port); +void intel_ddi_init (struct drm_i915_private *dev_priv,enum port port);enum port intel_ddi_get_encoder_port (struct intel_encoder *intel_encoder);bool intel_ddi_get_hw_state (struct intel_encoder *encoder,enum pipe *pipe);void intel_ddi_enable_transcoder_func (struct drm_crtc *crtc);
@@ -1377,7 +1377,8 @@ void intel_csr_ucode_suspend(struct drm_i915_private *);void intel_csr_ucode_resume (struct drm_i915_private *);/* intel_dp.c */ -bool intel_dp_init (struct drm_device *dev,i915_reg_t output_reg,enum port port); +bool intel_dp_init (struct drm_i915_private *dev_priv,i915_reg_t output_reg, +enum port port);bool intel_dp_init_connector (struct intel_digital_port *intel_dig_port,struct intel_connector *intel_connector); void intel_dp_set_link_params(struct intel_dp *intel_dp,
@@ -1452,13 +1453,13 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector);int intel_dp_mst_encoder_init (struct intel_digital_port *intel_dig_port,int conn_id);void intel_dp_mst_encoder_cleanup (struct intel_digital_port *intel_dig_port);/* intel_dsi.c */ -void intel_dsi_init (struct drm_device *dev); +void intel_dsi_init (struct drm_i915_private *dev_priv);/* intel_dsi_dcs_backlight.c */ int intel_dsi_dcs_init_backlight_funcs (struct intel_connector *intel_connector);/* intel_dvo.c */ -void intel_dvo_init (struct drm_device *dev); +void intel_dvo_init (struct drm_i915_private *dev_priv);/* intel_hotplug.c */ void intel_hpd_poll_init (struct drm_i915_private *dev_priv);
@@ -1522,7 +1523,8 @@ void intel_fbc_cleanup_cfb(struct drm_i915_private *dev_priv);void intel_fbc_handle_fifo_underrun_irq (struct drm_i915_private *dev_priv);/* intel_hdmi.c */ -void intel_hdmi_init (struct drm_device *dev,i915_reg_t hdmi_reg,enum port port); +void intel_hdmi_init (struct drm_i915_private *dev_priv,i915_reg_t hdmi_reg, +enum port port);void intel_hdmi_init_connector (struct intel_digital_port *intel_dig_port,struct intel_connector *intel_connector);struct intel_hdmi *enc_to_intel_hdmi (struct drm_encoder *encoder);
@@ -1533,7 +1535,7 @@ void intel_dp_dual_mode_set_tmds_output(struct intel_hdmi *hdmi, bool enable);/* intel_lvds.c */ -void intel_lvds_init (struct drm_device *dev); +void intel_lvds_init (struct drm_i915_private *dev_priv);struct intel_encoder *intel_get_lvds_encoder (struct drm_device *dev);bool intel_is_dual_link_lvds (struct drm_device *dev);
@@ -1606,7 +1608,7 @@ void intel_psr_invalidate(struct drm_i915_private *dev_priv,void intel_psr_flush (struct drm_i915_private *dev_priv,unsigned frontbuffer_bits,enum fb_op_origin origin); -void intel_psr_init (struct drm_device *dev); +void intel_psr_init (struct drm_i915_private *dev_priv);void intel_psr_single_frame_update (struct drm_i915_private *dev_priv,unsigned frontbuffer_bits);
@@ -1751,7 +1753,7 @@ static inline int intel_enable_rc6(void) }/* intel_sdvo.c */ -bool intel_sdvo_init (struct drm_device *dev, +bool intel_sdvo_init (struct drm_i915_private *dev_priv,i915_reg_t reg,enum port port);
@@ -1766,7 +1768,7 @@ void intel_pipe_update_start(struct intel_crtc *crtc);void intel_pipe_update_end (struct intel_crtc *crtc,struct intel_flip_work *work);/* intel_tv.c */ -void intel_tv_init (struct drm_device *dev); +void intel_tv_init (struct drm_i915_private *dev_priv);/* intel_atomic.c */ int intel_connector_atomic_get_property(struct drm_connector *connector,
drivers/gpu/drm/i915/intel_dsi.c +2 -2
@@ -1431,15 +1431,15 @@ static void intel_dsi_add_properties(struct intel_connector *connector) } } -void intel_dsi_init (struct drm_device *dev) +void intel_dsi_init (struct drm_i915_private *dev_priv) { +struct drm_device *dev = &dev_priv->drm;struct intel_dsi *intel_dsi;struct intel_encoder *intel_encoder;struct drm_encoder *encoder;struct intel_connector *intel_connector;struct drm_connector *connector;struct drm_display_mode *scan, *fixed_mode =NULL ; -struct drm_i915_private *dev_priv =to_i915 (dev);enum port port;unsigned int i;
drivers/gpu/drm/i915/intel_dvo.c +4 -5
@@ -422,9 +422,8 @@ static enum port intel_dvo_port(i915_reg_t dvo_reg)return PORT_C ; } -void intel_dvo_init (struct drm_device *dev) +void intel_dvo_init (struct drm_i915_private *dev_priv) { -struct drm_i915_private *dev_priv =to_i915 (dev);struct intel_encoder *intel_encoder;struct intel_dvo *intel_dvo;struct intel_connector *intel_connector;
@@ -511,7 +510,7 @@ void intel_dvo_init(struct drm_device *dev)continue ; port =intel_dvo_port (dvo->dvo_reg); -drm_encoder_init (dev, &intel_encoder->base, +drm_encoder_init (&dev_priv->drm, &intel_encoder->base, &intel_dvo_enc_funcs, encoder_type,"DVO %c" ,port_name (port));
@@ -523,14 +522,14 @@ void intel_dvo_init(struct drm_device *dev)case INTEL_DVO_CHIP_TMDS : intel_encoder->cloneable = (1 <<INTEL_OUTPUT_ANALOG ) | (1 <<INTEL_OUTPUT_DVO ); -drm_connector_init (dev, connector, +drm_connector_init (&dev_priv->drm, connector, &intel_dvo_connector_funcs,DRM_MODE_CONNECTOR_DVII ); encoder_type =DRM_MODE_ENCODER_TMDS ;break ;case INTEL_DVO_CHIP_LVDS : intel_encoder->cloneable =0 ; -drm_connector_init (dev, connector, +drm_connector_init (&dev_priv->drm, connector, &intel_dvo_connector_funcs,DRM_MODE_CONNECTOR_LVDS ); encoder_type =DRM_MODE_ENCODER_LVDS ;
drivers/gpu/drm/i915/intel_hdmi.c +4 -4
@@ -1933,10 +1933,9 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, } } -void intel_hdmi_init (struct drm_device *dev, +void intel_hdmi_init (struct drm_i915_private *dev_priv,i915_reg_t hdmi_reg,enum port port) { -struct drm_i915_private *dev_priv =to_i915 (dev);struct intel_digital_port *intel_dig_port;struct intel_encoder *intel_encoder;struct intel_connector *intel_connector;
@@ -1953,8 +1952,9 @@ void intel_hdmi_init(struct drm_device *dev, intel_encoder = &intel_dig_port->base; -drm_encoder_init (dev, &intel_encoder->base, &intel_hdmi_enc_funcs, -DRM_MODE_ENCODER_TMDS ,"HDMI %c" ,port_name (port)); +drm_encoder_init (&dev_priv->drm, &intel_encoder->base, + &intel_hdmi_enc_funcs,DRM_MODE_ENCODER_TMDS , +"HDMI %c" ,port_name (port)); intel_encoder->compute_config = intel_hdmi_compute_config;if (HAS_PCH_SPLIT (dev_priv)) {
drivers/gpu/drm/i915/intel_lvds.c +2 -2
@@ -971,9 +971,9 @@ static bool intel_lvds_supported(struct drm_i915_private *dev_priv)* Create the connector, register the LVDS DDC bus, and try to figure out what * modes we can display on the LVDS panel (if present). */ -void intel_lvds_init (struct drm_device *dev) +void intel_lvds_init (struct drm_i915_private *dev_priv) { -struct drm_i915_private *dev_priv =to_i915 (dev); +struct drm_device *dev = &dev_priv->drm;struct intel_lvds_encoder *lvds_encoder;struct intel_encoder *intel_encoder;struct intel_lvds_connector *lvds_connector;
drivers/gpu/drm/i915/intel_psr.c +1 -3
@@ -818,10 +818,8 @@ void intel_psr_flush(struct drm_i915_private *dev_priv,* This function is called only once at driver load to initialize basic * PSR stuff. */ -void intel_psr_init (struct drm_device *dev) +void intel_psr_init (struct drm_i915_private *dev_priv) { -struct drm_i915_private *dev_priv =to_i915 (dev); - dev_priv->psr_mmio_base =IS_HASWELL (dev_priv) ?HSW_EDP_PSR_BASE :BDW_EDP_PSR_BASE ;
drivers/gpu/drm/i915/intel_sdvo.c +10 -9
@@ -2342,9 +2342,9 @@ intel_sdvo_is_hdmi_connector(struct intel_sdvo *intel_sdvo, int device) }static u8 -intel_sdvo_get_slave_addr (struct drm_device *dev,struct intel_sdvo *sdvo) +intel_sdvo_get_slave_addr (struct drm_i915_private *dev_priv, +struct intel_sdvo *sdvo) { -struct drm_i915_private *dev_priv =to_i915 (dev);struct sdvo_device_mapping *my_mapping, *other_mapping;if (sdvo->port ==PORT_B ) {
@@ -2934,9 +2934,9 @@ static const struct i2c_algorithm intel_sdvo_ddc_proxy = {static bool intel_sdvo_init_ddc_proxy (struct intel_sdvo *sdvo, -struct drm_device *dev) +struct drm_i915_private *dev_priv) { -struct pci_dev *pdev = dev->pdev; +struct pci_dev *pdev = dev_priv->drm.pdev; sdvo->ddc.owner =THIS_MODULE ; sdvo->ddc.class =I2C_CLASS_DDC ;
@@ -2957,10 +2957,9 @@ static void assert_sdvo_port_valid(const struct drm_i915_private *dev_priv,WARN_ON (port !=PORT_B && port !=PORT_C ); } -bool intel_sdvo_init (struct drm_device *dev, +bool intel_sdvo_init (struct drm_i915_private *dev_priv,i915_reg_t sdvo_reg,enum port port) { -struct drm_i915_private *dev_priv =to_i915 (dev);struct intel_encoder *intel_encoder;struct intel_sdvo *intel_sdvo;int i;
@@ -2973,16 +2972,18 @@ bool intel_sdvo_init(struct drm_device *dev, intel_sdvo->sdvo_reg = sdvo_reg; intel_sdvo->port = port; - intel_sdvo->slave_addr =intel_sdvo_get_slave_addr (dev, intel_sdvo) >>1 ; + intel_sdvo->slave_addr = +intel_sdvo_get_slave_addr (dev_priv, intel_sdvo) >>1 ;intel_sdvo_select_i2c_bus (dev_priv, intel_sdvo); -if (!intel_sdvo_init_ddc_proxy (intel_sdvo, dev)) +if (!intel_sdvo_init_ddc_proxy (intel_sdvo, dev_priv)) goto err_i2c_bus;/* encoder type will be decided later */ intel_encoder = &intel_sdvo->base; intel_encoder->type =INTEL_OUTPUT_SDVO ; intel_encoder->port = port; -drm_encoder_init (dev, &intel_encoder->base, &intel_sdvo_enc_funcs,0 , +drm_encoder_init (&dev_priv->drm, &intel_encoder->base, + &intel_sdvo_enc_funcs,0 ,"SDVO %c" ,port_name (port));/* Read the regs to test if we can talk to the device */
drivers/gpu/drm/i915/intel_tv.c +2 -2
@@ -1537,9 +1537,9 @@ static const struct drm_encoder_funcs intel_tv_enc_funcs = { };void -intel_tv_init (struct drm_device *dev) +intel_tv_init (struct drm_i915_private *dev_priv) { -struct drm_i915_private *dev_priv =to_i915 (dev); +struct drm_device *dev = &dev_priv->drm;struct drm_connector *connector;struct intel_tv *intel_tv;struct intel_encoder *intel_encoder;
Signature · 6 lines
2.5.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
kbuild test robot
build botAll warnings (new ones prefixed by >>):
Hi Ander,
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20161123]
[cannot apply to v4.9-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Ander-Conselvan-de-Oliveira/drm-i915-Pass-dev_priv-to-intel_setup_outputs/20161124-093455 base: git://anongit.freedesktop.org/drm-intel for-linux-next reproduce: make htmldocs
All warnings (new ones prefixed by >>):
make[3]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule. include/linux/init.h:1: warning: no structured comments found
include/linux/workqueue.h:392: warning: No description found for parameter '...' include/linux/workqueue.h:392: warning: Excess function parameter 'args' description in 'alloc_workqueue' include/linux/workqueue.h:413: warning: No description found for parameter '...' include/linux/workqueue.h:413: warning: Excess function parameter 'args' description in 'alloc_ordered_workqueue' include/linux/kthread.h:26: warning: No description found for parameter '...'
kernel/sys.c:1: warning: no structured comments found
drivers/dma-buf/seqno-fence.c:1: warning: no structured comments found include/sound/core.h:324: warning: No description found for parameter '...' include/sound/core.h:335: warning: No description found for parameter '...' include/sound/core.h:388: warning: No description found for parameter '...'
include/drm/drm_drv.h:295: warning: Incorrect use of kernel-doc format: * Hook for allocating the GEM object struct, for use by core
include/drm/drm_drv.h:407: warning: No description found for parameter 'load' include/drm/drm_drv.h:407: warning: No description found for parameter 'firstopen' include/drm/drm_drv.h:407: warning: No description found for parameter 'open' include/drm/drm_drv.h:407: warning: No description found for parameter 'preclose' include/drm/drm_drv.h:407: warning: No description found for parameter 'postclose' include/drm/drm_drv.h:407: warning: No description found for parameter 'lastclose' include/drm/drm_drv.h:407: warning: No description found for parameter 'unload' include/drm/drm_drv.h:407: warning: No description found for parameter 'dma_ioctl' include/drm/drm_drv.h:407: warning: No description found for parameter 'dma_quiescent' include/drm/drm_drv.h:407: warning: No description found for parameter 'context_dtor' include/drm/drm_drv.h:407: warning: No description found for parameter 'set_busid' include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_handler' include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_preinstall' include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_postinstall' include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_uninstall' include/drm/drm_drv.h:407: warning: No description found for parameter 'debugfs_init' include/drm/drm_drv.h:407: warning: No description found for parameter 'debugfs_cleanup' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_open_object' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_close_object' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_create_object' include/drm/drm_drv.h:407: warning: No description found for parameter 'prime_handle_to_fd' include/drm/drm_drv.h:407: warning: No description found for parameter 'prime_fd_to_handle' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_export' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_import' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_pin' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_unpin' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_res_obj' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_get_sg_table' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_import_sg_table' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_vmap' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_vunmap' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_mmap' include/drm/drm_drv.h:407: warning: No description found for parameter 'vgaarb_irq' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_vm_ops' include/drm/drm_drv.h:407: warning: No description found for parameter 'major' include/drm/drm_drv.h:407: warning: No description found for parameter 'minor' include/drm/drm_drv.h:407: warning: No description found for parameter 'patchlevel' include/drm/drm_drv.h:407: warning: No description found for parameter 'name' include/drm/drm_drv.h:407: warning: No description found for parameter 'desc' include/drm/drm_drv.h:407: warning: No description found for parameter 'date' include/drm/drm_drv.h:407: warning: No description found for parameter 'driver_features' include/drm/drm_drv.h:407: warning: No description found for parameter 'dev_priv_size' include/drm/drm_drv.h:407: warning: No description found for parameter 'ioctls' include/drm/drm_drv.h:407: warning: No description found for parameter 'num_ioctls' include/drm/drm_drv.h:407: warning: No description found for parameter 'fops' include/drm/drm_drv.h:407: warning: No description found for parameter 'legacy_dev_list'
>> drivers/gpu/drm/i915/intel_psr.c:822: warning: No description found for parameter 'dev_priv' >> drivers/gpu/drm/i915/intel_psr.c:822: warning: Excess function parameter 'dev' description in 'intel_psr_init'
drivers/gpu/drm/i915/intel_psr.c:823: warning: No description found for parameter 'dev_priv' drivers/gpu/drm/i915/intel_psr.c:823: warning: Excess function parameter 'dev' description in 'intel_psr_init' include/media/media-entity.h:1054: warning: No description found for parameter '...' include/net/mac80211.h:3207: ERROR: Unexpected indentation.
include/net/mac80211.h:3210: WARNING: Block quote ends without a blank line; unexpected unindent. include/net/mac80211.h:3212: ERROR: Unexpected indentation.
include/net/mac80211.h:3213: WARNING: Block quote ends without a blank line; unexpected unindent. include/net/mac80211.h:1772: ERROR: Unexpected indentation.
include/net/mac80211.h:1776: WARNING: Block quote ends without a blank line; unexpected unindent. kernel/sched/fair.c:7259: WARNING: Inline emphasis start-string without end-string. kernel/time/timer.c:1240: ERROR: Unexpected indentation.
kernel/time/timer.c:1242: ERROR: Unexpected indentation.
kernel/time/timer.c:1243: WARNING: Block quote ends without a blank line; unexpected unindent. include/linux/wait.h:121: WARNING: Block quote ends without a blank line; unexpected unindent. include/linux/wait.h:124: ERROR: Unexpected indentation.
include/linux/wait.h:126: WARNING: Block quote ends without a blank line; unexpected unindent. kernel/time/hrtimer.c:1021: WARNING: Block quote ends without a blank line; unexpected unindent. kernel/signal.c:317: WARNING: Inline literal start-string without end-string. drivers/base/firmware_class.c:1348: WARNING: Bullet list ends without a blank line; unexpected unindent. drivers/message/fusion/mptbase.c:5054: WARNING: Definition list ends without a blank line; unexpected unindent. drivers/tty/serial/serial_core.c:1893: WARNING: Definition list ends without a blank line; unexpected unindent. include/linux/spi/spi.h:369: ERROR: Unexpected indentation.
WARNING: dvipng command 'dvipng' cannot be run (needed for math display), check the imgmath_dvipng setting
vim +/dev_priv +822 drivers/gpu/drm/i915/intel_psr.c
995d3047 Rodrigo Vivi 2014-11-19 806
0bc12bcb Rodrigo Vivi 2014-11-14 807 if (!dev_priv->psr.active && !dev_priv->psr.busy_frontbuffer_bits)
d0ac896a Rodrigo Vivi 2015-11-11 808 if (!work_busy(&dev_priv->psr.work.work))
0bc12bcb Rodrigo Vivi 2014-11-14 809 schedule_delayed_work(&dev_priv->psr.work,
20bb97fe Rodrigo Vivi 2015-11-11 810 msecs_to_jiffies(100));
0bc12bcb Rodrigo Vivi 2014-11-14 811 mutex_unlock(&dev_priv->psr.lock);
0bc12bcb Rodrigo Vivi 2014-11-14 812 }
0bc12bcb Rodrigo Vivi 2014-11-14 813
b2b89f55 Rodrigo Vivi 2014-11-14 814 /**
b2b89f55 Rodrigo Vivi 2014-11-14 815 * intel_psr_init - Init basic PSR work and mutex.
b2b89f55 Rodrigo Vivi 2014-11-14 816 * @dev: DRM device
b2b89f55 Rodrigo Vivi 2014-11-14 817 *
b2b89f55 Rodrigo Vivi 2014-11-14 818 * This function is called only once at driver load to initialize basic
b2b89f55 Rodrigo Vivi 2014-11-14 819 * PSR stuff.
b2b89f55 Rodrigo Vivi 2014-11-14 820 */
91ed48bf Ander Conselvan de Oliveira 2016-11-23 821 void intel_psr_init(struct drm_i915_private *dev_priv)
0bc12bcb Rodrigo Vivi 2014-11-14 @822 {
443a389f Ville Syrjälä 2015-11-11 823 dev_priv->psr_mmio_base = IS_HASWELL(dev_priv) ?
443a389f Ville Syrjälä 2015-11-11 824 HSW_EDP_PSR_BASE : BDW_EDP_PSR_BASE;
443a389f Ville Syrjälä 2015-11-11 825
d94d6e87 Rodrigo Vivi 2016-02-12 826 /* Per platform default */
d94d6e87 Rodrigo Vivi 2016-02-12 827 if (i915.enable_psr == -1) {
8652744b Tvrtko Ursulin 2016-10-13 828 if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
a38c274f Rodrigo Vivi 2016-02-12 829 i915.enable_psr = 1;
a38c274f Rodrigo Vivi 2016-02-12 830 else:::::: The code at line 822 was first introduced by commit
:::::: 0bc12bcb1b9686d7011f16410ba17ed0740167c3 drm/i915: Introduce intel_psr.c
:::::: TO: Rodrigo Vivi <[email protected]> :::::: CC: Daniel Vetter <[email protected]>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 64 lines · kbuild test robot
Hi Ander,
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20161123]
[cannot apply to v4.9-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]url: https://github.com/0day-ci/linux/commits/Ander-Conselvan-de-Oliveira/drm-i915-Pass-dev_priv-to-intel_setup_outputs/20161124-093455 base: git://anongit.freedesktop.org/drm-intel for-linux-next reproduce: make htmldocsAll warnings (new ones prefixed by >>):
make[3]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.
include/linux/init.h:1: warning: no structured comments found
include/linux/workqueue.h:392: warning: No description found for parameter '...'include/linux/workqueue.h:392: warning: Excess function parameter 'args' description in 'alloc_workqueue'include/linux/workqueue.h:413: warning: No description found for parameter '...'include/linux/workqueue.h:413: warning: Excess function parameter 'args' description in 'alloc_ordered_workqueue'include/linux/kthread.h:26: warning: No description found for parameter '...'
kernel/sys.c:1: warning: no structured comments found
drivers/dma-buf/seqno-fence.c:1: warning: no structured comments foundinclude/sound/core.h:324: warning: No description found for parameter '...'include/sound/core.h:335: warning: No description found for parameter '...'include/sound/core.h:388: warning: No description found for parameter '...'
include/drm/drm_drv.h:295: warning: Incorrect use of kernel-doc format: * Hook for allocating the GEM object struct, for use by core
include/drm/drm_drv.h:407: warning: No description found for parameter 'load'include/drm/drm_drv.h:407: warning: No description found for parameter 'firstopen'include/drm/drm_drv.h:407: warning: No description found for parameter 'open'include/drm/drm_drv.h:407: warning: No description found for parameter 'preclose'include/drm/drm_drv.h:407: warning: No description found for parameter 'postclose'include/drm/drm_drv.h:407: warning: No description found for parameter 'lastclose'include/drm/drm_drv.h:407: warning: No description found for parameter 'unload'include/drm/drm_drv.h:407: warning: No description found for parameter 'dma_ioctl'include/drm/drm_drv.h:407: warning: No description found for parameter 'dma_quiescent'include/drm/drm_drv.h:407: warning: No description found for parameter 'context_dtor'include/drm/drm_drv.h:407: warning: No description found for parameter 'set_busid'include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_handler'include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_preinstall'include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_postinstall'include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_uninstall'include/drm/drm_drv.h:407: warning: No description found for parameter 'debugfs_init'include/drm/drm_drv.h:407: warning: No description found for parameter 'debugfs_cleanup'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_open_object'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_close_object'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_create_object'include/drm/drm_drv.h:407: warning: No description found for parameter 'prime_handle_to_fd'include/drm/drm_drv.h:407: warning: No description found for parameter 'prime_fd_to_handle'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_export'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_import'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_pin'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_unpin'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_res_obj'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_get_sg_table'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_import_sg_table'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_vmap'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_vunmap'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_mmap'include/drm/drm_drv.h:407: warning: No description found for parameter 'vgaarb_irq'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_vm_ops'include/drm/drm_drv.h:407: warning: No description found for parameter 'major'include/drm/drm_drv.h:407: warning: No description found for parameter 'minor'include/drm/drm_drv.h:407: warning: No description found for parameter 'patchlevel'include/drm/drm_drv.h:407: warning: No description found for parameter 'name'
Quoted 10 lines
include/drm/drm_drv.h:407: warning: No description found for parameter 'desc'include/drm/drm_drv.h:407: warning: No description found for parameter 'date'include/drm/drm_drv.h:407: warning: No description found for parameter 'driver_features'include/drm/drm_drv.h:407: warning: No description found for parameter 'dev_priv_size'include/drm/drm_drv.h:407: warning: No description found for parameter 'ioctls'include/drm/drm_drv.h:407: warning: No description found for parameter 'num_ioctls'include/drm/drm_drv.h:407: warning: No description found for parameter 'fops'include/drm/drm_drv.h:407: warning: No description found for parameter 'legacy_dev_list'Quoted 2 lines
Quoted 2 lines
drivers/gpu/drm/i915/intel_psr.c:822: warning: No description found for parameter 'dev_priv'drivers/gpu/drm/i915/intel_psr.c:822: warning: Excess function parameter 'dev' description in 'intel_psr_init'
I also just spotted these. Please run
make DOCBOOKS="" htmldocs
and fix up the fallout.
Thanks, Daniel
Quoted 67 lines
drivers/gpu/drm/i915/intel_psr.c:823: warning: No description found for parameter 'dev_priv'drivers/gpu/drm/i915/intel_psr.c:823: warning: Excess function parameter 'dev' description in 'intel_psr_init'include/media/media-entity.h:1054: warning: No description found for parameter '...'include/net/mac80211.h:3207: ERROR: Unexpected indentation.
include/net/mac80211.h:3210: WARNING: Block quote ends without a blank line; unexpected unindent.include/net/mac80211.h:3212: ERROR: Unexpected indentation.
include/net/mac80211.h:3213: WARNING: Block quote ends without a blank line; unexpected unindent.include/net/mac80211.h:1772: ERROR: Unexpected indentation.
include/net/mac80211.h:1776: WARNING: Block quote ends without a blank line; unexpected unindent.kernel/sched/fair.c:7259: WARNING: Inline emphasis start-string without end-string.kernel/time/timer.c:1240: ERROR: Unexpected indentation.
kernel/time/timer.c:1242: ERROR: Unexpected indentation.
kernel/time/timer.c:1243: WARNING: Block quote ends without a blank line; unexpected unindent.include/linux/wait.h:121: WARNING: Block quote ends without a blank line; unexpected unindent.include/linux/wait.h:124: ERROR: Unexpected indentation.
include/linux/wait.h:126: WARNING: Block quote ends without a blank line; unexpected unindent.kernel/time/hrtimer.c:1021: WARNING: Block quote ends without a blank line; unexpected unindent.kernel/signal.c:317: WARNING: Inline literal start-string without end-string.drivers/base/firmware_class.c:1348: WARNING: Bullet list ends without a blank line; unexpected unindent.drivers/message/fusion/mptbase.c:5054: WARNING: Definition list ends without a blank line; unexpected unindent.drivers/tty/serial/serial_core.c:1893: WARNING: Definition list ends without a blank line; unexpected unindent.include/linux/spi/spi.h:369: ERROR: Unexpected indentation.
WARNING: dvipng command 'dvipng' cannot be run (needed for math display), check theimgmath_dvipngsettingvim +/dev_priv +822
drivers/gpu/drm/i915/intel_psr.c995d3047 Rodrigo Vivi 2014-11-19 806 0bc12bcb Rodrigo Vivi 2014-11-14 807 if (!dev_priv->psr.active && !dev_priv->psr.busy_frontbuffer_bits) d0ac896a Rodrigo Vivi 2015-11-11 808 if (!work_busy(&dev_priv->psr.work.work)) 0bc12bcb Rodrigo Vivi 2014-11-14 809 schedule_delayed_work(&dev_priv->psr.work, 20bb97fe Rodrigo Vivi 2015-11-11 810 msecs_to_jiffies(100)); 0bc12bcb Rodrigo Vivi 2014-11-14 811 mutex_unlock(&dev_priv->psr.lock); 0bc12bcb Rodrigo Vivi 2014-11-14 812 } 0bc12bcb Rodrigo Vivi 2014-11-14 813 b2b89f55 Rodrigo Vivi 2014-11-14 814 /** b2b89f55 Rodrigo Vivi 2014-11-14 815 * intel_psr_init - Init basic PSR work and mutex. b2b89f55 Rodrigo Vivi 2014-11-14 816 * @dev: DRM device b2b89f55 Rodrigo Vivi 2014-11-14 817 * b2b89f55 Rodrigo Vivi 2014-11-14 818 * This function is called only once at driver load to initialize basic b2b89f55 Rodrigo Vivi 2014-11-14 819 * PSR stuff. b2b89f55 Rodrigo Vivi 2014-11-14 820 */ 91ed48bf Ander Conselvan de Oliveira 2016-11-23 821 void intel_psr_init(struct drm_i915_private *dev_priv) 0bc12bcb Rodrigo Vivi 2014-11-14 @822 { 443a389f Ville Syrjälä 2015-11-11 823 dev_priv->psr_mmio_base = IS_HASWELL(dev_priv) ? 443a389f Ville Syrjälä 2015-11-11 824 HSW_EDP_PSR_BASE : BDW_EDP_PSR_BASE; 443a389f Ville Syrjälä 2015-11-11 825 d94d6e87 Rodrigo Vivi 2016-02-12 826 /* Per platform default */ d94d6e87 Rodrigo Vivi 2016-02-12 827 if (i915.enable_psr == -1) { 8652744b Tvrtko Ursulin 2016-10-13 828 if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv)) a38c274f Rodrigo Vivi 2016-02-12 829 i915.enable_psr = 1; a38c274f Rodrigo Vivi 2016-02-12 830 else:::::: The code at line 822 was first introduced by commit
::::::0bc12bcb1b9686d7011f16410ba17ed0740167c3drm/i915: Introduceintel_psr.c:::::: TO: Rodrigo Vivi <[email protected]> :::::: CC: Daniel Vetter <[email protected]>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/1 drm/i915: Fix intel_psr_init() kerneldoc
In commit c39055b072f8 ("drm/i915: Pass dev_priv to intel_setup_outputs()"), I forgot to update the kerneldoc for intel_psr_init() init, leading to warnings when building the documentation:
drivers/gpu/drm/i915/intel_psr.c:822: warning: No description found for parameter 'dev_priv' drivers/gpu/drm/i915/intel_psr.c:822: warning: Excess function parameter 'dev' description in 'intel_psr_init'
--- drivers/gpu/drm/i915/intel_psr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_psr.c +1 -1
@@ -813,7 +813,7 @@ void intel_psr_flush(struct drm_i915_private *dev_priv,/** * intel_psr_init - Init basic PSR work and mutex. -* @dev: DRM device +* @dev_priv: i915 device private * * This function is called only once at driver load to initialize basic * PSR stuff.
Signature · 6 lines
2.5.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
kbuild test robot
build botRe: [PATCH] drm/i915: Fix intel_psr_init() kerneldoc
All warnings (new ones prefixed by >>):
Hi Ander,
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v4.9-rc7 next-20161129]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Ander-Conselvan-de-Oliveira/drm-i915-Fix-intel_psr_init-kerneldoc/20161130-081024 base: git://anongit.freedesktop.org/drm-intel for-linux-next reproduce: make htmldocs
All warnings (new ones prefixed by >>):
make[3]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule. include/linux/init.h:1: warning: no structured comments found
include/linux/workqueue.h:392: warning: No description found for parameter '...' include/linux/workqueue.h:392: warning: Excess function parameter 'args' description in 'alloc_workqueue' include/linux/workqueue.h:413: warning: No description found for parameter '...' include/linux/workqueue.h:413: warning: Excess function parameter 'args' description in 'alloc_ordered_workqueue' include/linux/kthread.h:26: warning: No description found for parameter '...'
kernel/sys.c:1: warning: no structured comments found
drivers/dma-buf/seqno-fence.c:1: warning: no structured comments found include/sound/core.h:324: warning: No description found for parameter '...' include/sound/core.h:335: warning: No description found for parameter '...' include/sound/core.h:388: warning: No description found for parameter '...'
include/drm/drm_drv.h:295: warning: Incorrect use of kernel-doc format: * Hook for allocating the GEM object struct, for use by core
include/drm/drm_drv.h:407: warning: No description found for parameter 'load' include/drm/drm_drv.h:407: warning: No description found for parameter 'firstopen' include/drm/drm_drv.h:407: warning: No description found for parameter 'open' include/drm/drm_drv.h:407: warning: No description found for parameter 'preclose' include/drm/drm_drv.h:407: warning: No description found for parameter 'postclose' include/drm/drm_drv.h:407: warning: No description found for parameter 'lastclose' include/drm/drm_drv.h:407: warning: No description found for parameter 'unload' include/drm/drm_drv.h:407: warning: No description found for parameter 'dma_ioctl' include/drm/drm_drv.h:407: warning: No description found for parameter 'dma_quiescent' include/drm/drm_drv.h:407: warning: No description found for parameter 'context_dtor' include/drm/drm_drv.h:407: warning: No description found for parameter 'set_busid' include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_handler' include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_preinstall' include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_postinstall' include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_uninstall' include/drm/drm_drv.h:407: warning: No description found for parameter 'debugfs_init' include/drm/drm_drv.h:407: warning: No description found for parameter 'debugfs_cleanup' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_open_object' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_close_object' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_create_object' include/drm/drm_drv.h:407: warning: No description found for parameter 'prime_handle_to_fd' include/drm/drm_drv.h:407: warning: No description found for parameter 'prime_fd_to_handle' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_export' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_import' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_pin' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_unpin' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_res_obj' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_get_sg_table' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_import_sg_table' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_vmap' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_vunmap' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_mmap' include/drm/drm_drv.h:407: warning: No description found for parameter 'vgaarb_irq' include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_vm_ops' include/drm/drm_drv.h:407: warning: No description found for parameter 'major' include/drm/drm_drv.h:407: warning: No description found for parameter 'minor' include/drm/drm_drv.h:407: warning: No description found for parameter 'patchlevel' include/drm/drm_drv.h:407: warning: No description found for parameter 'name' include/drm/drm_drv.h:407: warning: No description found for parameter 'desc' include/drm/drm_drv.h:407: warning: No description found for parameter 'date' include/drm/drm_drv.h:407: warning: No description found for parameter 'driver_features' include/drm/drm_drv.h:407: warning: No description found for parameter 'dev_priv_size' include/drm/drm_drv.h:407: warning: No description found for parameter 'ioctls' include/drm/drm_drv.h:407: warning: No description found for parameter 'num_ioctls' include/drm/drm_drv.h:407: warning: No description found for parameter 'fops' include/drm/drm_drv.h:407: warning: No description found for parameter 'legacy_dev_list'
>> drivers/gpu/drm/i915/intel_psr.c:822: warning: No description found for parameter 'dev' >> drivers/gpu/drm/i915/intel_psr.c:822: warning: Excess function parameter 'dev_priv' description in 'intel_psr_init'
drivers/gpu/drm/i915/intel_psr.c:823: warning: No description found for parameter 'dev' drivers/gpu/drm/i915/intel_psr.c:823: warning: Excess function parameter 'dev_priv' description in 'intel_psr_init' include/media/media-entity.h:1054: warning: No description found for parameter '...' include/net/mac80211.h:3207: ERROR: Unexpected indentation.
include/net/mac80211.h:3210: WARNING: Block quote ends without a blank line; unexpected unindent. include/net/mac80211.h:3212: ERROR: Unexpected indentation.
include/net/mac80211.h:3213: WARNING: Block quote ends without a blank line; unexpected unindent. include/net/mac80211.h:1772: ERROR: Unexpected indentation.
include/net/mac80211.h:1776: WARNING: Block quote ends without a blank line; unexpected unindent. kernel/sched/fair.c:7259: WARNING: Inline emphasis start-string without end-string. kernel/time/timer.c:1240: ERROR: Unexpected indentation.
kernel/time/timer.c:1242: ERROR: Unexpected indentation.
kernel/time/timer.c:1243: WARNING: Block quote ends without a blank line; unexpected unindent. include/linux/wait.h:121: WARNING: Block quote ends without a blank line; unexpected unindent. include/linux/wait.h:124: ERROR: Unexpected indentation.
include/linux/wait.h:126: WARNING: Block quote ends without a blank line; unexpected unindent. kernel/time/hrtimer.c:1021: WARNING: Block quote ends without a blank line; unexpected unindent. kernel/signal.c:317: WARNING: Inline literal start-string without end-string. drivers/base/firmware_class.c:1348: WARNING: Bullet list ends without a blank line; unexpected unindent. drivers/message/fusion/mptbase.c:5054: WARNING: Definition list ends without a blank line; unexpected unindent. drivers/tty/serial/serial_core.c:1893: WARNING: Definition list ends without a blank line; unexpected unindent. include/linux/spi/spi.h:369: ERROR: Unexpected indentation.
WARNING: dvipng command 'dvipng' cannot be run (needed for math display), check the imgmath_dvipng setting
vim +/dev +822 drivers/gpu/drm/i915/intel_psr.c
995d3047 Rodrigo Vivi 2014-11-19 806
0bc12bcb Rodrigo Vivi 2014-11-14 807 if (!dev_priv->psr.active && !dev_priv->psr.busy_frontbuffer_bits)
d0ac896a Rodrigo Vivi 2015-11-11 808 if (!work_busy(&dev_priv->psr.work.work))
0bc12bcb Rodrigo Vivi 2014-11-14 809 schedule_delayed_work(&dev_priv->psr.work,
20bb97fe Rodrigo Vivi 2015-11-11 810 msecs_to_jiffies(100));
0bc12bcb Rodrigo Vivi 2014-11-14 811 mutex_unlock(&dev_priv->psr.lock);
0bc12bcb Rodrigo Vivi 2014-11-14 812 }
0bc12bcb Rodrigo Vivi 2014-11-14 813
b2b89f55 Rodrigo Vivi 2014-11-14 814 /**
b2b89f55 Rodrigo Vivi 2014-11-14 815 * intel_psr_init - Init basic PSR work and mutex.
acd19c01 Ander Conselvan de Oliveira 2016-11-29 816 * @dev_priv: i915 device private
b2b89f55 Rodrigo Vivi 2014-11-14 817 *
b2b89f55 Rodrigo Vivi 2014-11-14 818 * This function is called only once at driver load to initialize basic
b2b89f55 Rodrigo Vivi 2014-11-14 819 * PSR stuff.
b2b89f55 Rodrigo Vivi 2014-11-14 820 */
0bc12bcb Rodrigo Vivi 2014-11-14 821 void intel_psr_init(struct drm_device *dev)
0bc12bcb Rodrigo Vivi 2014-11-14 @822 {
fac5e23e Chris Wilson 2016-07-04 823 struct drm_i915_private *dev_priv = to_i915(dev);
0bc12bcb Rodrigo Vivi 2014-11-14 824
443a389f Ville Syrjälä 2015-11-11 825 dev_priv->psr_mmio_base = IS_HASWELL(dev_priv) ?
443a389f Ville Syrjälä 2015-11-11 826 HSW_EDP_PSR_BASE : BDW_EDP_PSR_BASE;
443a389f Ville Syrjälä 2015-11-11 827
d94d6e87 Rodrigo Vivi 2016-02-12 828 /* Per platform default */
d94d6e87 Rodrigo Vivi 2016-02-12 829 if (i915.enable_psr == -1) {
8652744b Tvrtko Ursulin 2016-10-13 830 if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv)):::::: The code at line 822 was first introduced by commit
:::::: 0bc12bcb1b9686d7011f16410ba17ed0740167c3 drm/i915: Introduce intel_psr.c
:::::: TO: Rodrigo Vivi <[email protected]>
:::::: CC: Daniel Vetter <[email protected]>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH] drm/i915: Fix intel_psr_init() kerneldoc
Quoted 71 lines · kbuild test robot
Hi Ander,
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v4.9-rc7 next-20161129]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]url: https://github.com/0day-ci/linux/commits/Ander-Conselvan-de-Oliveira/drm-i915-Fix-intel_psr_init-kerneldoc/20161130-081024
base:git://anongit.freedesktop.org/drm-intelfor-linux-next
reproduce: make htmldocsAll warnings (new ones prefixed by >>):
make[3]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.
include/linux/init.h:1: warning: no structured comments found
include/linux/workqueue.h:392: warning: No description found for parameter '...'
include/linux/workqueue.h:392: warning: Excess function parameter 'args' description in 'alloc_workqueue'include/linux/workqueue.h:413: warning: No description found for parameter '...'
include/linux/workqueue.h:413: warning: Excess function parameter 'args' description in 'alloc_ordered_workqueue'include/linux/kthread.h:26: warning: No description found for parameter '...'
kernel/sys.c:1: warning: no structured comments found
drivers/dma-buf/seqno-fence.c:1: warning: no structured comments found
include/sound/core.h:324: warning: No description found for parameter '...'
include/sound/core.h:335: warning: No description found for parameter '...'
include/sound/core.h:388: warning: No description found for parameter '...'
include/drm/drm_drv.h:295: warning: Incorrect use of kernel-doc format: * Hook for allocating the GEM object struct, for use by coreinclude/drm/drm_drv.h:407: warning: No description found for parameter 'load'
include/drm/drm_drv.h:407: warning: No description found for parameter 'firstopen'
include/drm/drm_drv.h:407: warning: No description found for parameter 'open'
include/drm/drm_drv.h:407: warning: No description found for parameter 'preclose'
include/drm/drm_drv.h:407: warning: No description found for parameter 'postclose'
include/drm/drm_drv.h:407: warning: No description found for parameter 'lastclose'
include/drm/drm_drv.h:407: warning: No description found for parameter 'unload'
include/drm/drm_drv.h:407: warning: No description found for parameter 'dma_ioctl'
include/drm/drm_drv.h:407: warning: No description found for parameter 'dma_quiescent'
include/drm/drm_drv.h:407: warning: No description found for parameter 'context_dtor'
include/drm/drm_drv.h:407: warning: No description found for parameter 'set_busid'
include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_handler'
include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_preinstall'
include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_postinstall'
include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_uninstall'
include/drm/drm_drv.h:407: warning: No description found for parameter 'debugfs_init'
include/drm/drm_drv.h:407: warning: No description found for parameter 'debugfs_cleanup'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_open_object'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_close_object'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_create_object'include/drm/drm_drv.h:407: warning: No description found for parameter 'prime_handle_to_fd'include/drm/drm_drv.h:407: warning: No description found for parameter 'prime_fd_to_handle'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_export'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_import'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_pin'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_unpin'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_res_obj'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_get_sg_table'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_import_sg_table'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_vmap'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_vunmap'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_mmap'
include/drm/drm_drv.h:407: warning: No description found for parameter 'vgaarb_irq'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_vm_ops'
include/drm/drm_drv.h:407: warning: No description found for parameter 'major'
include/drm/drm_drv.h:407: warning: No description found for parameter 'minor'
include/drm/drm_drv.h:407: warning: No description found for parameter 'patchlevel'
include/drm/drm_drv.h:407: warning: No description found for parameter 'name'
include/drm/drm_drv.h:407: warning: No description found for parameter 'desc'
include/drm/drm_drv.h:407: warning: No description found for parameter 'date'
include/drm/drm_drv.h:407: warning: No description found for parameter 'driver_features'
include/drm/drm_drv.h:407: warning: No description found for parameter 'dev_priv_size'
include/drm/drm_drv.h:407: warning: No description found for parameter 'ioctls'
include/drm/drm_drv.h:407: warning: No description found for parameter 'num_ioctls'
include/drm/drm_drv.h:407: warning: No description found for parameter 'fops'
include/drm/drm_drv.h:407: warning: No description found for parameter 'legacy_dev_list'
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
drivers/gpu/drm/i915/intel_psr.c:822: warning: No description found for parameter 'dev'drivers/gpu/drm/i915/intel_psr.c:822: warning: Excess function parameter 'dev_priv' description in 'intel_psr_init'
drivers/gpu/drm/i915/intel_psr.c:823: warning: No description found for parameter 'dev'drivers/gpu/drm/i915/intel_psr.c:823: warning: Excess function parameter 'dev_priv' description in 'intel_psr_init'
These warnings are for some wrong tree, which doesn't have the patch that converts from dev to dev_priv in intel_psr_init()'s signature.
Ander
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [lkp] [PATCH] drm/i915: Fix intel_psr_init() kerneldoc
Quoted 72 lines · Ander Conselvan De Oliveira
Quoted 71 lines · kbuild test robot
Hi Ander,
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v4.9-rc7 next-20161129]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]url: https://github.com/0day-ci/linux/commits/Ander-Conselvan-de-Oliveira/drm-i915-Fix-intel_psr_init-kerneldoc/20161130-081024
base:git://anongit.freedesktop.org/drm-intelfor-linux-next
reproduce: make htmldocsAll warnings (new ones prefixed by >>):
make[3]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.
include/linux/init.h:1: warning: no structured comments found
include/linux/workqueue.h:392: warning: No description found for parameter '...'
include/linux/workqueue.h:392: warning: Excess function parameter 'args' description in 'alloc_workqueue'include/linux/workqueue.h:413: warning: No description found for parameter '...'
include/linux/workqueue.h:413: warning: Excess function parameter 'args' description in 'alloc_ordered_workqueue'include/linux/kthread.h:26: warning: No description found for parameter '...'
kernel/sys.c:1: warning: no structured comments found
drivers/dma-buf/seqno-fence.c:1: warning: no structured comments found
include/sound/core.h:324: warning: No description found for parameter '...'
include/sound/core.h:335: warning: No description found for parameter '...'
include/sound/core.h:388: warning: No description found for parameter '...'
include/drm/drm_drv.h:295: warning: Incorrect use of kernel-doc format: * Hook for allocating the GEM object struct, for use by coreinclude/drm/drm_drv.h:407: warning: No description found for parameter 'load'
include/drm/drm_drv.h:407: warning: No description found for parameter 'firstopen'
include/drm/drm_drv.h:407: warning: No description found for parameter 'open'
include/drm/drm_drv.h:407: warning: No description found for parameter 'preclose'
include/drm/drm_drv.h:407: warning: No description found for parameter 'postclose'
include/drm/drm_drv.h:407: warning: No description found for parameter 'lastclose'
include/drm/drm_drv.h:407: warning: No description found for parameter 'unload'
include/drm/drm_drv.h:407: warning: No description found for parameter 'dma_ioctl'
include/drm/drm_drv.h:407: warning: No description found for parameter 'dma_quiescent'
include/drm/drm_drv.h:407: warning: No description found for parameter 'context_dtor'
include/drm/drm_drv.h:407: warning: No description found for parameter 'set_busid'
include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_handler'
include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_preinstall'
include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_postinstall'
include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_uninstall'
include/drm/drm_drv.h:407: warning: No description found for parameter 'debugfs_init'
include/drm/drm_drv.h:407: warning: No description found for parameter 'debugfs_cleanup'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_open_object'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_close_object'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_create_object'include/drm/drm_drv.h:407: warning: No description found for parameter 'prime_handle_to_fd'include/drm/drm_drv.h:407: warning: No description found for parameter 'prime_fd_to_handle'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_export'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_import'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_pin'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_unpin'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_res_obj'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_get_sg_table'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_import_sg_table'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_vmap'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_vunmap'include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_mmap'
include/drm/drm_drv.h:407: warning: No description found for parameter 'vgaarb_irq'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_vm_ops'
include/drm/drm_drv.h:407: warning: No description found for parameter 'major'
include/drm/drm_drv.h:407: warning: No description found for parameter 'minor'
include/drm/drm_drv.h:407: warning: No description found for parameter 'patchlevel'
include/drm/drm_drv.h:407: warning: No description found for parameter 'name'
include/drm/drm_drv.h:407: warning: No description found for parameter 'desc'
include/drm/drm_drv.h:407: warning: No description found for parameter 'date'
include/drm/drm_drv.h:407: warning: No description found for parameter 'driver_features'
include/drm/drm_drv.h:407: warning: No description found for parameter 'dev_priv_size'
include/drm/drm_drv.h:407: warning: No description found for parameter 'ioctls'
include/drm/drm_drv.h:407: warning: No description found for parameter 'num_ioctls'
include/drm/drm_drv.h:407: warning: No description found for parameter 'fops'
include/drm/drm_drv.h:407: warning: No description found for parameter 'legacy_dev_list'
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
drivers/gpu/drm/i915/intel_psr.c:822: warning: No description found for parameter 'dev'drivers/gpu/drm/i915/intel_psr.c:822: warning: Excess function parameter 'dev_priv' description in 'intel_psr_init'
drivers/gpu/drm/i915/intel_psr.c:823: warning: No description found for parameter 'dev'drivers/gpu/drm/i915/intel_psr.c:823: warning: Excess function parameter 'dev_priv' description in 'intel_psr_init'These warnings are for some wrong tree, which doesn't have the patch that converts from dev to
dev_privin intel_psr_init()'s signature.
Thanks for the note, could you tell us the correct tree to which this patch should be applied?
Thanks,
Xiaolong
Quoted 4 lines
Ander
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [lkp] [PATCH] drm/i915: Fix intel_psr_init() kerneldoc
Quoted 139 lines · Ye Xiaolong
Quoted 138 lines · Ander Conselvan De Oliveira
Quoted 136 lines · kbuild test robot
Hi Ander,
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v4.9-rc7 next-20161129]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]url: https://github.com/0day-ci/linux/commits/Ander-Conselvan-de-Olivei
ra/drm-i915-Fix-intel_psr_init-kerneldoc/20161130-081024
base:git://anongit.freedesktop.org/drm-intelfor-linux-next
reproduce: make htmldocsAll warnings (new ones prefixed by >>):
make[3]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.
include/linux/init.h:1: warning: no structured comments foundinclude/linux/workqueue.h:392: warning: No description found for parameter '...'
include/linux/workqueue.h:392: warning: Excess function parameter 'args' description in 'alloc_workqueue'include/linux/workqueue.h:413: warning: No description found for parameter '...'
include/linux/workqueue.h:413: warning: Excess function parameter 'args' description in 'alloc_ordered_workqueue'include/linux/kthread.h:26: warning: No description found for parameter '...'
kernel/sys.c:1: warning: no structured comments founddrivers/dma-buf/seqno-fence.c:1: warning: no structured comments foundinclude/sound/core.h:324: warning: No description found for parameter '...'
include/sound/core.h:335: warning: No description found for parameter '...'
include/sound/core.h:388: warning: No description found for parameter '...'
include/drm/drm_drv.h:295: warning: Incorrect use of kernel-doc format: * Hook for allocating the GEM object struct, for use by coreinclude/drm/drm_drv.h:407: warning: No description found for parameter 'load'
include/drm/drm_drv.h:407: warning: No description found for parameter 'firstopen'
include/drm/drm_drv.h:407: warning: No description found for parameter 'open'
include/drm/drm_drv.h:407: warning: No description found for parameter 'preclose'
include/drm/drm_drv.h:407: warning: No description found for parameter 'postclose'
include/drm/drm_drv.h:407: warning: No description found for parameter 'lastclose'
include/drm/drm_drv.h:407: warning: No description found for parameter 'unload'
include/drm/drm_drv.h:407: warning: No description found for parameter 'dma_ioctl'
include/drm/drm_drv.h:407: warning: No description found for parameter 'dma_quiescent'
include/drm/drm_drv.h:407: warning: No description found for parameter 'context_dtor'
include/drm/drm_drv.h:407: warning: No description found for parameter 'set_busid'
include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_handler'
include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_preinstall'
include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_postinstall'
include/drm/drm_drv.h:407: warning: No description found for parameter 'irq_uninstall'
include/drm/drm_drv.h:407: warning: No description found for parameter 'debugfs_init'
include/drm/drm_drv.h:407: warning: No description found for parameter 'debugfs_cleanup'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_open_object'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_close_object'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_create_object'
include/drm/drm_drv.h:407: warning: No description found for parameter 'prime_handle_to_fd'
include/drm/drm_drv.h:407: warning: No description found for parameter 'prime_fd_to_handle'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_export'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_import'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_pin'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_unpin'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_res_obj'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_get_sg_table'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_import_sg_table'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_vmap'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_vunmap'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_prime_mmap'
include/drm/drm_drv.h:407: warning: No description found for parameter 'vgaarb_irq'
include/drm/drm_drv.h:407: warning: No description found for parameter 'gem_vm_ops'
include/drm/drm_drv.h:407: warning: No description found for parameter 'major'
include/drm/drm_drv.h:407: warning: No description found for parameter 'minor'
include/drm/drm_drv.h:407: warning: No description found for parameter 'patchlevel'
include/drm/drm_drv.h:407: warning: No description found for parameter 'name'
include/drm/drm_drv.h:407: warning: No description found for parameter 'desc'
include/drm/drm_drv.h:407: warning: No description found for parameter 'date'
include/drm/drm_drv.h:407: warning: No description found for parameter 'driver_features'
include/drm/drm_drv.h:407: warning: No description found for parameter 'dev_priv_size'
include/drm/drm_drv.h:407: warning: No description found for parameter 'ioctls'
include/drm/drm_drv.h:407: warning: No description found for parameter 'num_ioctls'
include/drm/drm_drv.h:407: warning: No description found for parameter 'fops'
include/drm/drm_drv.h:407: warning: No description found for parameter 'legacy_dev_list'Quoted 6 lines
Quoted 6 lines
drivers/gpu/drm/i915/intel_psr.c:822: warning: No description found for parameter 'dev'drivers/gpu/drm/i915/intel_psr.c:822: warning: Excess function parameter 'dev_priv' description in 'intel_psr_init'
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
drivers/gpu/drm/i915/intel_psr.c:823: warning: No description found for parameter 'dev'
drivers/gpu/drm/i915/intel_psr.c:823: warning: Excess function parameter 'dev_priv' description in 'intel_psr_init'These warnings are for some wrong tree, which doesn't have the patch that converts from dev to
dev_privin intel_psr_init()'s signature.Thanks for the note, could you tell us the correct tree to which this patch should be applied?
That would be drm-intel/drm-intel-next-queued.
Ander
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH] drm/i915: Fix intel_psr_init() kerneldoc
In reply to Ander Conselvan de OliveiraQuoted 8 lines · Ander Conselvan de Oliveira
In commit
c39055b072f8("drm/i915: Passdev_privtointel_setup_outputs()"), I forgot to update the kerneldoc forintel_psr_init()init, leading to warnings when building the documentation:drivers/gpu/drm/i915/intel_psr.c:822: warning: No description found for parameter '
dev_priv'drivers/gpu/drm/i915/intel_psr.c:822: warning: Excess function parameter 'dev' description in 'intel_psr_init'
Quoted 7 lines
Fixes c39055b072f8 ("drm/i915: Pass dev_priv to intel_setup_outputs()")Cc Ander Conselvan de Oliveira <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Daniel Vetter <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Ander Conselvan de Oliveira <[email protected]>
Pushed with Daniel's irc r-b.
Ander
Quoted 10 lines
---
drivers/gpu/drm/i915/intel_psr.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_psr.c +0
-0@@ -813,7 +813,7 @@ void intel_psr_flush(struct drm_i915_private *dev_priv,
Quoted 8 lines
/**
*intel_psr_init- Init basic PSR work and mutex.
- * @dev: DRM device
+ * @dev_priv: i915 device private
*
* This function is called only once at driver load to initialize basic
* PSR stuff.
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Pass dev_priv to intel_setup_outputs() (rev2)
In reply to Ander Conselvan de Oliveira== Series Details ==
== Series Details ==
Series: drm/i915: Pass dev_priv to intel_setup_outputs() (rev2)
URL : https://patchwork.freedesktop.org/series/15820/
State : success
== Summary ==
Series 15820v2 drm/i915: Pass dev_priv to intel_setup_outputs()
https://patchwork.freedesktop.org/api/1.0/series/15820/revisions/2/mbox/
fi-bdw-5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15 fi-bsw-n3050 total:244 pass:204 dwarn:0 dfail:0 fail:0 skip:40 fi-bxt-t5700 total:244 pass:216 dwarn:0 dfail:0 fail:0 skip:28 fi-byt-j1900 total:244 pass:216 dwarn:0 dfail:0 fail:0 skip:28 fi-byt-n2820 total:244 pass:212 dwarn:0 dfail:0 fail:0 skip:32 fi-hsw-4770 total:244 pass:224 dwarn:0 dfail:0 fail:0 skip:20 fi-hsw-4770r total:244 pass:224 dwarn:0 dfail:0 fail:0 skip:20 fi-ilk-650 total:244 pass:191 dwarn:0 dfail:0 fail:0 skip:53 fi-ivb-3520m total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-ivb-3770 total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-kbl-7200u total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-skl-6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14 fi-skl-6700hq total:244 pass:223 dwarn:0 dfail:0 fail:0 skip:21 fi-skl-6700k total:244 pass:222 dwarn:1 dfail:0 fail:0 skip:21 fi-skl-6770hq total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14 fi-snb-2520m total:244 pass:212 dwarn:0 dfail:0 fail:0 skip:32 fi-snb-2600 total:244 pass:211 dwarn:0 dfail:0 fail:0 skip:33
01896e61d9cc0cad08e19990cd095cdf679f6142 drm-intel-nightly: 2016y-11m-23d-14h-45m-53s UTC integration manifest 0832b12 drm/i915: Pass dev_priv to intel_setup_outputs()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3094/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✓ Fi.CI.BAT: success for drm/i915: Pass dev_priv to intel_setup_outputs() (rev2)
Quoted 5 lines · Patchwork
== Series Details ==
Series: drm/i915: Pass
dev_privtointel_setup_outputs()(rev2) URL : https://patchwork.freedesktop.org/series/15820/
State : success
Pushed. Thanks for the review.
Ander
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Pass dev_priv to intel_setup_outputs() (rev3)
In reply to Ander Conselvan de Oliveira== Series Details ==
== Series Details ==
Series: drm/i915: Pass dev_priv to intel_setup_outputs() (rev3)
URL : https://patchwork.freedesktop.org/series/15820/
State : success
== Summary ==
Series 15820v3 drm/i915: Pass dev_priv to intel_setup_outputs()
https://patchwork.freedesktop.org/api/1.0/series/15820/revisions/3/mbox/
fi-bdw-5557u total:245 pass:230 dwarn:0 dfail:0 fail:0 skip:15 fi-bsw-n3050 total:245 pass:205 dwarn:0 dfail:0 fail:0 skip:40 fi-bxt-t5700 total:245 pass:217 dwarn:0 dfail:0 fail:0 skip:28 fi-byt-j1900 total:245 pass:217 dwarn:0 dfail:0 fail:0 skip:28 fi-byt-n2820 total:245 pass:213 dwarn:0 dfail:0 fail:0 skip:32 fi-hsw-4770 total:245 pass:225 dwarn:0 dfail:0 fail:0 skip:20 fi-hsw-4770r total:245 pass:225 dwarn:0 dfail:0 fail:0 skip:20 fi-ilk-650 total:245 pass:192 dwarn:0 dfail:0 fail:0 skip:53 fi-ivb-3520m total:245 pass:223 dwarn:0 dfail:0 fail:0 skip:22 fi-ivb-3770 total:245 pass:223 dwarn:0 dfail:0 fail:0 skip:22 fi-kbl-7500u total:245 pass:223 dwarn:0 dfail:0 fail:0 skip:22 fi-skl-6260u total:245 pass:231 dwarn:0 dfail:0 fail:0 skip:14 fi-skl-6700hq total:245 pass:224 dwarn:0 dfail:0 fail:0 skip:21 fi-skl-6700k total:245 pass:223 dwarn:1 dfail:0 fail:0 skip:21 fi-skl-6770hq total:245 pass:231 dwarn:0 dfail:0 fail:0 skip:14 fi-snb-2520m total:245 pass:213 dwarn:0 dfail:0 fail:0 skip:32 fi-snb-2600 total:245 pass:212 dwarn:0 dfail:0 fail:0 skip:33
676d4ee0b28bd4c5f9b7b3aee61b043c98ab9cc5 drm-tip: 2016y-11m-29d-12h-54m-36s UTC integration manifest 21afd5a drm/i915: Fix intel_psr_init() kerneldoc
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3137/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx