Skip to contentSkip to conversation

gcc: the special workaround for ARC is no longer required

PATCH New Waldemar Brodkorb 3 participants 3 messages Nov 23, 2016

lore
Share & tools
lore

Waldemar Brodkorb

author
#0 lore raw

PATCH 1/1 gcc: the special workaround for ARC is no longer required

It seems with the change to gcc 6.x based toolchain this workaround is no longer required. Tested with an arc hs toolchain.

Signed-off-by Waldemar Brodkorb <[email protected]>
---
 package/gcc/gcc-initial/gcc-initial.mk | 13 -------------
 1 file changed, 13 deletions(-)
package/gcc/gcc-initial/gcc-initial.mk +0 -13
index 7bb988b..a51e29c 100644
@@ -25,19 +25,6 @@ HOST_GCC_INITIAL_SUBDIR = build
 
 HOST_GCC_INITIAL_PRE_CONFIGURE_HOOKS += HOST_GCC_CONFIGURE_SYMLINK
 
-# gcc on ARC has a bug: in its libgcc, even when no C library is
-# available (--with-newlib is passed, and therefore inhibit_libc is
-# defined), it tries to use the C library for the libgmon
-# library. Since it's not needed in gcc-initial, we disabled it here.
-ifeq ($(BR2_GCC_VERSION_ARC),y)
-define HOST_GCC_INITIAL_DISABLE_LIBGMON
-	$(SED) 's/crtbeginS.o libgmon.a crtg.o/crtbeginS.o crtg.o/' \
-		$(@D)/libgcc/config.host
-endef
-HOST_GCC_INITIAL_POST_PATCH_HOOKS += HOST_GCC_INITIAL_DISABLE_LIBGMON
-HOST_GCC_INITIAL_POST_RSYNC_HOOKS += HOST_GCC_INITIAL_DISABLE_LIBGMON
-endif
-
 HOST_GCC_INITIAL_CONF_OPTS = \
 	$(HOST_GCC_COMMON_CONF_OPTS) \
 	--enable-languages=c \
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 gcc: the special workaround for ARC is no longer required

Hi Waldemar,

Quoted 5 lines · Waldemar Brodkorb

It seems with the change to gcc 6.x based toolchain this workaround is no longer required. Tested with an arc hs toolchain.

Signed-off-by Waldemar Brodkorb <[email protected]>

---

Nice catch!

Indeed since?https://github.com/foss-for-synopsys-dwc-arc-processors/gcc/commit/80a9c1591ccce130ced8ee4581efacd55ba0a81e there's no libgmon building for ARC in gcc.

But unfortunately that's one of very few patches that were not yet merged in upstream gcc. That said if anybody attempts to build toolchain for ARC right out of upstream GCC the code in question will be required.

But given the fact we're not ready to switch to upstream GCC ATM your change is very much appreciated so

Acked-by Alexey Brodkin <[email protected]>
Applied
#2 lore raw

PATCH 1/1 gcc: the special workaround for ARC is no longer required

In reply to Waldemar Brodkorb

Hello,

Quoted 7 lines · Waldemar Brodkorb

It seems with the change to gcc 6.x based toolchain this workaround is no longer required. Tested with an arc hs toolchain.

Signed-off-by Waldemar Brodkorb <[email protected]>
---
 package/gcc/gcc-initial/gcc-initial.mk | 13 -------------
 1 file changed, 13 deletions(-)

Applied to next, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com