Skip to contentSkip to conversation

align to generic ib_event logging helper

PATCH New Max Gurtovoy 3 participants 9 messages Nov 23, 2016 – Dec 2, 2016

Subsystems (2)
NVMe NVMe target
lore
Share & tools
lore

Max Gurtovoy

author
#0 lore raw

v3 cover align to generic ib_event logging helper

Changes since V2:
- keep log prints inside the default case for nvmet-rdma

Max Gurtovoy (2):
nvmet-rdma: align to generic ib_event logging helper
nvme-rdma: align to generic ib_event logging helper

 drivers/nvme/host/rdma.c   |    4 +++-
 drivers/nvme/target/rdma.c |    4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)
author
#1 lore raw

PATCH v3 1/2 nvmet-rdma: align to generic ib_event logging helper

Signed-off-by Max Gurtovoy <maxg at mellanox.com>
---
 drivers/nvme/target/rdma.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/nvme/target/rdma.c +2 -1
index 005ef5d..ddbae24 100644
@@ -1129,7 +1129,8 @@ static void nvmet_rdma_qp_event(struct ib_event *event, void *priv)
 		rdma_notify(queue->cm_id, event->event);
 		break;
 	default:
-		pr_err("received unrecognized IB QP event %d\n", event->event);
+		pr_err("received IB QP event: %s (%d)\n",
+		       ib_event_msg(event->event), event->event);
 		break;
 	}
 }
Signature · 1 line
1.7.1
#2 lore raw

PATCH v3 1/2 nvmet-rdma: align to generic ib_event logging helper

Quoted 16 lines · Max Gurtovoy
Signed-off-by Max Gurtovoy <maxg at mellanox.com>

---
?drivers/nvme/target/rdma.c |????3 ++-
?1 files changed, 2 insertions(+), 1 deletions(-)

drivers/nvme/target/rdma.c +0 -0
index 005ef5d..ddbae24 100644
@@ -1129,7 +1129,8 @@ static void nvmet_rdma_qp_event(struct ib_event
 *event, void *priv)
 ?		rdma_notify(queue->cm_id, event->event);
 ?		break;

? default:

drivers/nvme/target/rdma.c +0 -1
-		pr_err("received unrecognized IB QP event %d\n",

event->event);

drivers/nvme/target/rdma.c

Quoted 2 lines
drivers/nvme/target/rdma.c +2 -0
+		pr_err("received IB QP event: %s (%d)\n",
+		???????ib_event_msg(event->event), event->event);

I liked the original print statement mentioning something that it hit the default case ("received unrecognized IB QP event"). ?But if no one else has a problem with it, then I'm ok with it.

author
#3 lore raw

PATCH v3 1/2 nvmet-rdma: align to generic ib_event logging helper

Quoted 15 lines · J Freyensee
Quoted 14 lines · Max Gurtovoy
Signed-off-by Max Gurtovoy <maxg at mellanox.com>
---
 drivers/nvme/target/rdma.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/nvme/target/rdma.c +0 -0
index 005ef5d..ddbae24 100644
@@ -1129,7 +1129,8 @@ static void nvmet_rdma_qp_event(struct ib_event
 *event, void *priv)
 		rdma_notify(queue->cm_id, event->event);
 		break;
 	default:
Quoted 8 lines

drivers/nvme/target/rdma.c static void nvmet_rdma_qp_event(struct ib_event *event, void *priv) · line 1133

Quoted 4 lines
drivers/nvme/target/rdma.c +2 -1
-		pr_err("received unrecognized IB QP event %d\n",
 event->event);
+		pr_err("received IB QP event: %s (%d)\n",
+		       ib_event_msg(event->event), event->event);

I liked the original print statement mentioning something that it hit the default case ("received unrecognized IB QP event"). But if no one else has a problem with it, then I'm ok with it.

in that case you'll get something like:

"nvmet_rdma: received unrecognized IB QP event: last WQE reached (16)"

instead of

"nvmet_rdma: received IB QP event: last WQE reached (16)"

Sagi/Christoph, what do you think ?

#4 lore raw

PATCH v3 1/2 nvmet-rdma: align to generic ib_event logging helper

Quoted 9 lines · Max Gurtovoy

in that case you'll get something like:

"nvmet_rdma: received unrecognized IB QP event: last WQE reached (16)"

instead of

"nvmet_rdma: received IB QP event: last WQE reached (16)"

Sagi/Christoph, what do you think ?

I don't care, it's only a debug printk anyway.

author
#5 lore raw

PATCH v3 1/2 nvmet-rdma: align to generic ib_event logging helper

Quoted 5 lines · Christoph Hellwig
Quoted 4 lines · Max Gurtovoy

in that case you'll get something like:

"nvmet_rdma: received unrecognized IB QP event: last WQE reached (16)"

Quoted 8 lines
Quoted 5 lines

instead of

"nvmet_rdma: received IB QP event: last WQE reached (16)"

Sagi/Christoph, what do you think ?

I don't care, it's only a debug printk anyway.

me too :) I just want to put this 2 patches behind us.

author
#6 lore raw

PATCH v3 2/2 nvme-rdma: align to generic ib_event logging helper

In reply to Max Gurtovoy
Signed-off-by Max Gurtovoy <maxg at mellanox.com>
---
 drivers/nvme/host/rdma.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/nvme/host/rdma.c +3 -1
index 3d25add..9c34da5 100644
@@ -241,7 +241,9 @@ static void nvme_rdma_free_ring(struct ib_device *ibdev,
 
 static void nvme_rdma_qp_event(struct ib_event *event, void *context)
 {
-	pr_debug("QP event %d\n", event->event);
+	pr_debug("QP event %s (%d)\n",
+		 ib_event_msg(event->event), event->event);
+
 }
 
 static int nvme_rdma_wait_for_cm(struct nvme_rdma_queue *queue)
Signature · 1 line
1.7.1
#7 lore raw

PATCH v3 2/2 nvme-rdma: align to generic ib_event logging helper

Quoted 2 lines · Max Gurtovoy

Signed-off-by: Max Gurtovoy <maxg at mellanox.com> ?

Reviewed-by Jay Freyensee <james_p_freyensee at linux.intel.com>