scsi: ufs: fix condition in which DME command failure msg is printed out
PATCH 9/11 scsi: ufs: fix condition in which DME command failure msg is printed out
From: Yaniv Gardi <[email protected]>
The condition in which error message is printed out was incorrect and resulted error message only if retries exhausted.
But retries happens only if DME command is a peer command, and thus DME commands which are not peer commands and fail are not printed out. This change fixes this issue.
Signed-off-by Yaniv Gardi <[email protected]>
Signed-off-by Subhash Jadavani <[email protected]>
--- drivers/scsi/ufs/ufshcd.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/scsi/ufs/ufshcd.c +6 -5
@@ -2516,10 +2516,10 @@ int ufshcd_dme_set_attr(struct ufs_hba *hba, u32 attr_sel, set, UIC_GET_ATTR_ID(attr_sel), mib_val, ret); }while (ret && peer && --retries); -if (!retries) +if (ret)dev_err (hba->dev,"%s: attr-id 0x%x val 0x%x failed %d retries\n" , - set,UIC_GET_ATTR_ID (attr_sel), mib_val, - retries); + set,UIC_GET_ATTR_ID (attr_sel), mib_val, +UFS_UIC_COMMAND_RETRIES - retries);return ret; }
@@ -2583,9 +2583,10 @@ int ufshcd_dme_get_attr(struct ufs_hba *hba, u32 attr_sel, get, UIC_GET_ATTR_ID(attr_sel), ret); }while (ret && peer && --retries); -if (!retries) +if (ret)dev_err (hba->dev,"%s: attr-id 0x%x failed %d retries\n" , - get,UIC_GET_ATTR_ID (attr_sel), retries); + get,UIC_GET_ATTR_ID (attr_sel), +UFS_UIC_COMMAND_RETRIES - retries);if (mib_val && !ret) *mib_val = uic_cmd.argument3;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project