Patch "scsi: mpt3sas: Fix secure erase premature termination" has been added to the 4.4-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
scsi: mpt3sas: Fix secure erase premature termination
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
scsi-mpt3sas-fix-secure-erase-premature-termination.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
18f6084a989ba1b38702f9af37a2e4049a924be6Mon Sep 17 00:00:00 2001
From: Andrey Grodzovsky <[email protected]>
Date: Thu, 10 Nov 2016 09:35:27 -0500
Subject: scsi: mpt3sas: Fix secure erase premature termination
From: Andrey Grodzovsky <[email protected]>
commit 18f6084a989ba1b38702f9af37a2e4049a924be6 upstream.
This is a work around for a bug with LSI Fusion MPT SAS2 when perfoming secure erase. Due to the very long time the operation takes, commands issued during the erase will time out and will trigger execution of the abort hook. Even though the abort hook is called for the specific command which timed out, this leads to entire device halt (scsi_state terminated) and premature termination of the secure erase.
Set device state to busy while ATA passthrough commands are in progress.
[mkp: hand applied to 4.9/scsi-fixes, tweaked patch description]
--- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-)
drivers/scsi/mpt3sas/mpt3sas_scsih.c +14 -1
@@ -3831,7 +3831,10 @@ _scsih_eedp_error_handling(struct scsi_cSAM_STAT_CHECK_CONDITION ; } - +static inline bool ata_12_16_cmd (struct scsi_cmnd *scmd) +{ +return (scmd->cmnd[0 ] ==ATA_12 || scmd->cmnd[0 ] ==ATA_16 ); +}/** * scsih_qcmd - main scsi request entry point
@@ -3859,6 +3862,13 @@ scsih_qcmd(struct Scsi_Host *shost, struif (ioc->logging_level &MPT_DEBUG_SCSI )scsi_print_command (scmd); +/* +* Lock the device for any subsequent command until command is +* done. +*/ +if (ata_12_16_cmd (scmd)) +scsi_internal_device_block (scmd->device); + sas_device_priv_data = scmd->device->hostdata;if (!sas_device_priv_data || !sas_device_priv_data->sas_target) { scmd->result =DID_NO_CONNECT <<16 ;
@@ -4431,6 +4441,9 @@ _scsih_io_done(struct MPT3SAS_ADAPTER *iif (scmd ==NULL )return 1 ; +if (ata_12_16_cmd (scmd)) +scsi_internal_device_unblock (scmd->device,SDEV_RUNNING ); + mpi_request =mpt3sas_base_get_msg_frame (ioc, smid);if (mpi_reply ==NULL ) {
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/scsi-mpt3sas-fix-secure-erase-premature-termination.patch