drm/amd/powerplay: Fix potential NULL pointer issue
Subsystems (2)
PATCH 6/6 drm/amd/powerplay: Fix potential NULL pointer issue
If doesn't enable dpm, the powerplay will not allocate memory for hw management. So, hw_init_power_state_table function will reference NULL pointer when resetting.
--- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/powerplay/amd_powerplay.c +2 -2
@@ -1004,12 +1004,12 @@ int amd_powerplay_reset(void *handle)if (ret)return ret; -hw_init_power_state_table (instance->hwmgr); -if ((amdgpu_dpm ==0 ) ||cgs_is_virtualization_enabled (instance->smu_mgr->device))return 0 ; +hw_init_power_state_table (instance->hwmgr); +if (eventmgr ==NULL || eventmgr->pp_eventmgr_init ==NULL )return -EINVAL ;
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1480489396-29235-1-git-send-email-Xiangliang.Yu-5C7GfCeVMHo@public.gmane.org
This patch is Reviewed-by: Rex Zhu <[email protected]>
Best Regards
Rex
-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Xiangliang Yu
Sent: Wednesday, November 30, 2016 3:03 PM
To: [email protected]
Cc: Yu, Xiangliang
Subject: [PATCH 6/6] drm/amd/powerplay: Fix potential NULL pointer issue
If doesn't enable dpm, the powerplay will not allocate memory for hw management. So, hw_init_power_state_table function will reference NULL pointer when resetting.
--- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/powerplay/amd_powerplay.c +2 -2
@@ -1004,12 +1004,12 @@ int amd_powerplay_reset(void *handle)if (ret)return ret; -hw_init_power_state_table (instance->hwmgr); -if ((amdgpu_dpm ==0 ) ||cgs_is_virtualization_enabled (instance->smu_mgr->device))return 0 ; +hw_init_power_state_table (instance->hwmgr); +if (eventmgr ==NULL || eventmgr->pp_eventmgr_init ==NULL )return -EINVAL ;
--
2.7.4
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx