Skip to contentSkip to conversation

gdb: Fix QA Warning

PATCH In review Gordan Markuš 3 participants 6 messages Dec 2, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gdb: Fix QA Warning

WARNING: QA Issue: gdb: invalid PACKAGECONFIG: readline [invalid-packageconfig]

---
 recipes-devtools/gdb/gdb_%.bbappend | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-devtools/gdb/gdb_%.bbappend +1 -1
index 3e663e7..41592c4 100644
@@ -1 +1 @@
-PACKAGECONFIG ??= "readline python"
+PACKAGECONFIG ??= "python"
Signature · 1 line
2.9.3
#1 lore raw

recipes-devtools/gdb/gdb_%.bbappend line 1

Quoted 9 lines · Gordan Markuš
recipes-devtools/gdb/gdb_%.bbappend +1 -1
index 3e663e7..41592c4 100644
@@ -1 +1 @@
-PACKAGECONFIG ??= "readline python"
+PACKAGECONFIG ??= "python"

This should be PACKAGECONFIG_append = " python", surely.

Ross

#2 lore raw
In reply to Gordan Markuš
Quoted 12 lines · Gordan Markuš

WARNING: QA Issue: gdb: invalid PACKAGECONFIG: readline [invalid-packageconfig]

---
 recipes-devtools/gdb/gdb_%.bbappend | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-devtools/gdb/gdb_%.bbappend +0 -0
index 3e663e7..41592c4 100644

recipes-devtools/gdb/gdb_%.bbappend line 1

Quoted 2 lines
recipes-devtools/gdb/gdb_%.bbappend +1 -1
@@ -1 +1 @@
-PACKAGECONFIG ??= "readline python"
+PACKAGECONFIG ??= "python"

What gdb are you using? The version in oe-core has readline PACKAGECONFIG

meta/recipes-devtools/gdb/gdb-common.inc:PACKAGECONFIG ??= "readline" meta/recipes-devtools/gdb/gdb-common.inc:# Use --without-system-readline to compile with readline 5. meta/recipes-devtools/gdb/gdb-common.inc:PACKAGECONFIG[readline] = "--with-system-readline,--without-system-readline,readline"

Quoted 8 lines
Signature · 7 lines
2.9.3

-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#3 lore raw
Quoted 21 lines · Martin Jansa
Quoted 14 lines · Gordan Markuš

WARNING: QA Issue: gdb: invalid PACKAGECONFIG: readline [invalid- packageconfig]

---
 recipes-devtools/gdb/gdb_%.bbappend | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
recipes- renamed from recipes-devtools/gdb/gdb_%.bbappend +0 -0

devtools/gdb/gdb_%.bbappend
index 3e663e7..41592c4 100644

recipes-devtools/gdb/gdb_%.bbappend line 1

Quoted 2 lines
recipes-devtools/gdb/gdb_%.bbappend +1 -1
@@ -1 +1 @@
-PACKAGECONFIG ??= "readline python"
+PACKAGECONFIG ??= "python"

What gdb are you using? The version in oe-core has readline PACKAGECONFIG

Quoted 6 lines

meta/recipes-devtools/gdb/gdb-common.inc:PACKAGECONFIG ??= "readline" meta/recipes-devtools/gdb/gdb-common.inc:# Use --without-system- readline to compile with readline 5. meta/recipes-devtools/gdb/gdb-common.inc:PACKAGECONFIG[readline] = "- -with-system-readline,--without-system-readline,readline"

We are using the gdb from poky and it's a similar case there. Though, the gdb itself doesn't have the readline PACKAGECONFIG. It is enabled by default in the *.inc files.

gdb-cross-canadian.inc:PACKAGECONFIG ??= "python readline" gdb-cross-canadian.inc:PACKAGECONFIG[readline] = "--with-system- readline,--without-system-readline,nativesdk-readline" gdb-common.inc:PACKAGECONFIG ??= "readline" gdb-common.inc:PACKAGECONFIG[readline] = "--with-system-readline, --without-system-readline,readline" gdb-cross.inc:PACKAGECONFIG ??= "python readline" gdb-cross.inc:PACKAGECONFIG[readline] = "--with-system-readline, --without-system-readline,readline-native"

Quoted 10 lines
Quoted 8 lines

--
2.9.3

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#4 lore raw
Quoted 28 lines · Gordan Markuš
Quoted 21 lines · Martin Jansa
Quoted 14 lines · Gordan Markuš

WARNING: QA Issue: gdb: invalid PACKAGECONFIG: readline [invalid- packageconfig]

---
 recipes-devtools/gdb/gdb_%.bbappend | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
recipes- renamed from recipes-devtools/gdb/gdb_%.bbappend +0 -0

devtools/gdb/gdb_%.bbappend
index 3e663e7..41592c4 100644

recipes-devtools/gdb/gdb_%.bbappend line 1

Quoted 2 lines
recipes-devtools/gdb/gdb_%.bbappend +1 -1
@@ -1 +1 @@
-PACKAGECONFIG ??= "readline python"
+PACKAGECONFIG ??= "python"

What gdb are you using? The version in oe-core has readline PACKAGECONFIG

Quoted 6 lines

meta/recipes-devtools/gdb/gdb-common.inc:PACKAGECONFIG ??= "readline" meta/recipes-devtools/gdb/gdb-common.inc:# Use --without-system- readline to compile with readline 5. meta/recipes-devtools/gdb/gdb-common.inc:PACKAGECONFIG[readline] = "- -with-system-readline,--without-system-readline,readline"

Quoted 3 lines

We are using the gdb from poky and it's a similar case there. Though, the gdb itself doesn't have the readline PACKAGECONFIG. It is enabled by default in the *.inc files.

No, it isn't, read:
https://patchwork.openembedded.org/patch/116843/
discussion.

Quoted 20 lines

gdb-cross-canadian.inc:PACKAGECONFIG ??= "python readline" gdb-cross-canadian.inc:PACKAGECONFIG[readline] = "--with-system- readline,--without-system-readline,nativesdk-readline" gdb-common.inc:PACKAGECONFIG ??= "readline" gdb-common.inc:PACKAGECONFIG[readline] = "--with-system-readline, --without-system-readline,readline" gdb-cross.inc:PACKAGECONFIG ??= "python readline" gdb-cross.inc:PACKAGECONFIG[readline] = "--with-system-readline, --without-system-readline,readline-native"

Quoted 10 lines
Quoted 8 lines

--
2.9.3

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#5 lore raw
Quoted 39 lines · Martin Jansa
Quoted 32 lines · Gordan Markuš
Quoted 22 lines · Martin Jansa
Quoted 15 lines · Gordan Markuš

WARNING: QA Issue: gdb: invalid PACKAGECONFIG: readline [invalid-
packageconfig]

---
 recipes-devtools/gdb/gdb_%.bbappend | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
recipes- renamed from recipes-devtools/gdb/gdb_%.bbappend +0 -0

devtools/gdb/gdb_%.bbappend
index 3e663e7..41592c4 100644

recipes-devtools/gdb/gdb_%.bbappend line 1

Quoted 2 lines
recipes-devtools/gdb/gdb_%.bbappend +1 -1
@@ -1 +1 @@
-PACKAGECONFIG ??= "readline python"
+PACKAGECONFIG ??= "python"

What gdb are you using? The version in oe-core has readline PACKAGECONFIG

Quoted 8 lines

meta/recipes-devtools/gdb/gdb-common.inc:PACKAGECONFIG ??= "readline"
meta/recipes-devtools/gdb/gdb-common.inc:# Use --without-system- readline to compile with readline 5. meta/recipes-devtools/gdb/gdb-common.inc:PACKAGECONFIG[readline] = "- -with-system-readline,--without-system-readline,readline"

Quoted 5 lines

We are using the gdb from poky and it's a similar case there. Though,
the gdb itself doesn't have the readline PACKAGECONFIG. It is enabled
by default in the *.inc files.

Quoted 3 lines

No, it isn't, read:
https://patchwork.openembedded.org/patch/116843/
discussion.

In that case the patch can be discarded.
Thank you for sharing this Martin!

Quoted 24 lines
Quoted 22 lines

gdb-cross-canadian.inc:PACKAGECONFIG ??= "python readline" gdb-cross-canadian.inc:PACKAGECONFIG[readline] = "--with-system- readline,--without-system-readline,nativesdk-readline" gdb-common.inc:PACKAGECONFIG ??= "readline" gdb-common.inc:PACKAGECONFIG[readline] = "--with-system-readline, --without-system-readline,readline" gdb-cross.inc:PACKAGECONFIG ??= "python readline" gdb-cross.inc:PACKAGECONFIG[readline] = "--with-system-readline, --without-system-readline,readline-native"

Quoted 11 lines
Quoted 9 lines

--
2.9.3

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-dev
el