Skip to contentSkip to conversation

exo: fix build after perl update

PATCH In review Andreas Müller 2 participants 6 messages Dec 5, 2016 – Dec 6, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 exo: fix build after perl update

fixes:

| checking for perl5... no
| checking for perl... perl
| checking for perl module URI::Escape... no
| checking for perl module URI::file... no
| checking for perl module URI::URL... no
| configure: error: Atleast one of the required Perl modules (URI::Escape, URI::file and URI::URL) was not found on your system
---
 meta-xfce/recipes-xfce/exo/exo_0.11.1.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-xfce/recipes-xfce/exo/exo_0.11.1.bb +2 -0
index c145ce0..733ba24 100644
@@ -24,6 +24,8 @@ SRC_URI_append_class-native = " \
 SRC_URI[md5sum] = "866292556586facb034191aa66431697"
 SRC_URI[sha256sum] = "c70c47f690284a5cb4f507dd89088efbdd8123506f924e33a5f97aab74eb97d4"
 
+export PERL = "${bindir}/perl"
+
 PACKAGES =+ "exo-csource"
 
 # Note: python bindings did not work in oe-dev and are about to be moved to
Signature · 1 line
2.5.5
#1 lore raw

PATCH 2/2 exo: update to 0.11.2

0001-Probable-fix-for-Thunar-detailed-view-Xfce-12916.patch was applied upstream [1]

[1] https://git.xfce.org/xfce/exo/commit/?id=fea2619e6d07ac72b2eff6f408bb3daa2dbdf671

---
 ...e-fix-for-Thunar-detailed-view-Xfce-12916.patch | 36 ----------------------
 .../exo/{exo_0.11.1.bb => exo_0.11.2.bb}           |  5 ++-
 2 files changed, 2 insertions(+), 39 deletions(-)
 delete mode 100644 meta-xfce/recipes-xfce/exo/exo/0001-Probable-fix-for-Thunar-detailed-view-Xfce-12916.patch
 rename meta-xfce/recipes-xfce/exo/{exo_0.11.1.bb => exo_0.11.2.bb} (83%)
meta-xfce/recipes-xfce/exo/exo/0001-Probable-fix-for-Thunar-detailed-view-Xfce-12916.patch deleted +0 -36
deleted file mode 100644
index 16f12fe..0000000
@@ -1,36 +0,0 @@
-From fea2619e6d07ac72b2eff6f408bb3daa2dbdf671 Mon Sep 17 00:00:00 2001
-From: Sean Davis <[email protected]>
-Date: Thu, 27 Oct 2016 20:31:36 -0400
-Subject: [PATCH] Probable fix for Thunar detailed view (Xfce #12916)
-
-Upstream-Status: Pending [1-2]
-
-[1] https://git.xfce.org/xfce/exo/commit/?id=fea2619e6d07ac72b2eff6f408bb3daa2dbdf671
-[2] https://bugzilla.xfce.org/show_bug.cgi?id=12916
-
----
- exo/exo-tree-view.c | 6 +-----
- 1 file changed, 1 insertion(+), 5 deletions(-)
-
-diff --git a/exo/exo-tree-view.c b/exo/exo-tree-view.c
-index 8c8564f..2d0fc04 100644
---- a/exo/exo-tree-view.c
-+++ b/exo/exo-tree-view.c
-@@ -385,13 +385,9 @@ exo_tree_view_button_press_event (GtkWidget      *widget,
-         }
-     }
- 
--  /* see bug http://bugzilla.xfce.org/show_bug.cgi?id=6230 for more information */
-   if (G_LIKELY (gtk_tree_selection_get_select_function (selection) == (GtkTreeSelectionFunc) exo_noop_false))
-     {
--      /* just reset the select function (previously set to exo_noop_false),
--       * there's no clean way to do this, so what the heck.
--       */
--      gtk_tree_selection_set_select_function (selection, NULL, NULL, NULL);
-+      gtk_tree_selection_set_select_function (selection, (GtkTreeSelectionFunc) exo_noop_true, NULL, NULL);
-     }
- 
-   /* release the path (if any) */
--- 
-2.5.5
-
meta-xfce/recipes-xfce/exo/exo_0.11.2.bb renamed from meta-xfce/recipes-xfce/exo/exo_0.11.1.bb +2 -3
similarity index 83%
rename from meta-xfce/recipes-xfce/exo/exo_0.11.1.bb
rename to meta-xfce/recipes-xfce/exo/exo_0.11.2.bb
index 733ba24..d7c9ce2 100644
@@ -14,15 +14,14 @@ REQUIRED_DISTRO_FEATURES_class-native = ""
 SRC_URI += " \
     file://exo-no-tests-0.8.patch \
     file://configure.patch \
-    file://0001-Probable-fix-for-Thunar-detailed-view-Xfce-12916.patch \
 "
 
 SRC_URI_append_class-native = " \
     file://reduce-build-to-exo-csource-only.patch \
 "
 
-SRC_URI[md5sum] = "866292556586facb034191aa66431697"
-SRC_URI[sha256sum] = "c70c47f690284a5cb4f507dd89088efbdd8123506f924e33a5f97aab74eb97d4"
+SRC_URI[md5sum] = "0b036c8042a2ed5d3767d1177a4213a2"
+SRC_URI[sha256sum] = "76bd1c4229503ff3c301485de3a41c55dec93e98de1a9eef1be77fe502ca4f77"
 
 export PERL = "${bindir}/perl"
 
Signature · 1 line
2.5.5
#2 lore raw
In reply to Andreas Müller
Quoted 12 lines · Andreas Müller

fixes:

| checking for perl5... no
| checking for perl... perl
| checking for perl module URI::Escape... no
| checking for perl module URI::file... no
| checking for perl module URI::URL... no
| configure: error: Atleast one of the required Perl modules (URI::Escape, URI::file and URI::URL) was not found on your system

I was seeing same errors. Should this be using native perl instead ?

Quoted 26 lines

---
meta-xfce/recipes-xfce/exo/exo_0.11.1.bb | 2 ++

1 file changed, 2 insertions(+)
meta-xfce/recipes-xfce/exo/exo_0.11.1.bb +0 -0
index c145ce0..733ba24 100644
@@ -24,6 +24,8 @@ SRC_URI_append_class-native = " \

SRC_URI[md5sum] = "866292556586facb034191aa66431697"
SRC_URI[sha256sum] = "c70c47f690284a5cb4f507dd89088efbdd8123506f924e33a5f97aab74eb97d4"

meta-xfce/recipes-xfce/exo/exo_0.11.1.bb +2 -0
+export PERL = "${bindir}/perl"
+

PACKAGES =+ "exo-csource"

# Note: python bindings did not work in oe-dev and are about to be moved to

Signature · 7 lines
2.5.5

-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
#3 lore raw
Quoted 13 lines · Khem Raj
Quoted 12 lines · Andreas Müller

fixes:

| checking for perl5... no
| checking for perl... perl
| checking for perl module URI::Escape... no
| checking for perl module URI::file... no
| checking for perl module URI::URL... no
| configure: error: Atleast one of the required Perl modules (URI::Escape, URI::file and URI::URL) was not found on your system
Quoted 1 line

I was seeing same errors. Should this be using native perl instead ?

For exo case I think we already do: The only 'perlish' is liburi-perl-native in DEPENDS and perlnative in inherit

Andreas

#4 lore raw

Ok

Quoted 27 lines · Andreas Müller
Quoted 2 lines · Khem Raj
Quoted 2 lines

On Dec 5, 2016, at 3:08 PM, Andreas Müller <

Quoted 9 lines · [email protected]> wrote:
Quoted 9 lines

fixes:

| checking for perl5... no
| checking for perl... perl
| checking for perl module URI::Escape... no
| checking for perl module URI::file... no
| checking for perl module URI::URL... no
| configure: error: Atleast one of the required Perl modules

(URI::Escape, URI::file and URI::URL) was not found on your system

Quoted 3 lines
Quoted 1 line

I was seeing same errors. Should this be using native perl instead ?

For exo case I think we already do: The only 'perlish' is liburi-perl-native in DEPENDS and perlnative in inherit

Andreas
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#5 lore raw
Quoted 26 lines · Khem Raj

Ok

Quoted 21 lines · Andreas Müller
Quoted 2 lines · Khem Raj
Quoted 2 lines

On Dec 5, 2016, at 3:08 PM, Andreas Müller <

Quoted 9 lines · [email protected]> wrote:
Quoted 9 lines

fixes:

| checking for perl5... no
| checking for perl... perl
| checking for perl module URI::Escape... no
| checking for perl module URI::file... no
| checking for perl module URI::URL... no
| configure: error: Atleast one of the required Perl modules

(URI::Escape, URI::file and URI::URL) was not found on your system

Quoted 3 lines
Quoted 1 line

I was seeing same errors. Should this be using native perl instead ?

For exo case I think we already do: The only 'perlish' is liburi-perl-native in DEPENDS and perlnative in inherit

Andreas

Please forget this series. Root cause for configure failure is broken liburi-perl-native caused by perl update. I will send out an update of liburi-perl-native to oe-core and V2 here

Andreas