Skip to contentSkip to conversation

sign-file: Fix inplace signing when src and dst names are both specified

PATCH New Alex Yashchenko 1 participant 1 message Dec 6, 2016 Certificate handling

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sign-file: Fix inplace signing when src and dst names are both specified

When src and dst both are specified and they point to the same file the sign-file utility will write only signature to the dst file and the module (.ko file) body will not be written.
That happens because we open the same file with "rb" and "wb" flags, from fopen man:

w Truncate file to zero length or create text file for writing.
The stream is positioned at the beginning of the file.
...

	bm = BIO_new_file(module_name, "rb");
...
	bd = BIO_new_file(dest_name, "wb");
...
	while ((n = BIO_read(bm, buf, sizeof(buf))),
	       n > 0) {
		ERR(BIO_write(bd, buf, n) < 0, "%s", dest_name);
	}

...

---
 scripts/sign-file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/sign-file.c +1 -1
index 53af6dc..0672c0d 100755
@@ -267,7 +267,7 @@ int main(int argc, char **argv)
 	}
 	x509_name = argv[2];
 	module_name = argv[3];
-	if (argc == 5) {
+	if (argc == 5 && strcmp(argv[3], argv[4])) {
 		dest_name = argv[4];
 		replace_orig = false;
 	} else {
Signature · 1 line
1.9.1