Skip to contentSkip to conversation

Fix wrong configure.ac parsing of --enable-async-push

PATCH In review David Sommerseth 2 participants 3 messages Dec 6, 2016

lore
Share & tools
lore

David Sommerseth

author
#0 lore raw

PATCH 1/1 Fix wrong configure.ac parsing of --enable-async-push

AC_ARG_ENABLE() was used wrong, which led enable_async_push to always be set, regardless if --enable-async-push or --disable-async-push was used.

Also spotted the exact same patch when writing this commit message as GitHub PR#70.

Trac: #786

Signed-off-by David Sommerseth <[email protected]...>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure.ac +1 -1
index f4073d0..c6c5fa9 100644
@@ -267,7 +267,7 @@ AC_ARG_ENABLE(
 AC_ARG_ENABLE(
 	[async-push],
 	[AS_HELP_STRING([--enable-async-push], [enable async-push support @<:@default=no@:>@])],
-	[enable_async_push="yes"],
+        ,
 	[enable_async_push="no"]
 )
Signature · 1 line
1.8.3.1
#1 lore raw

ACK from me

Tested with --disable-async-push, #define does not appear.

2016-12-07 0:10 GMT+02:00 David Sommerseth <[email protected]...>:

Quoted 43 lines

AC_ARG_ENABLE() was used wrong, which led enable_async_push to always be set, regardless if --enable-async-push or --disable-async-push was used.

Also spotted the exact same patch when writing this commit message as GitHub PR#70.

Trac: #786

Signed-off-by David Sommerseth <[email protected]...>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure.ac +1 -2
index f4073d0..c6c5fa9 100644
@@ -267,7 +267,7 @@ AC_ARG_ENABLE(
 AC_ARG_ENABLE(
        [async-push],
        [AS_HELP_STRING([--enable-async-push], [enable async-push support
 @<:@default=no@:>@])],
-       [enable_async_push="yes"],
+        ,
        [enable_async_push="no"]
 )
 
--

1.8.3.1

------------------------------------------------------------
------------------
Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi
_______________________________________________
Openvpn-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Signature · 1 line
-Lev
author
#2 lore raw
In reply to David Sommerseth

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Your patch has been applied to the master branch

This patch was slightly modified at commit time, changed from spaces to tabs on the line being modified.

commit e62eccf025aa60ec268787d2aa4a46310ed1cd60

Author: David Sommerseth
Date:   Tue Dec 6 23:10:51 2016 +0100
     Fix wrong configure.ac parsing of --enable-async-push

     Trac: #786
     Signed-off-by: David Sommerseth <[email protected]...>
     Acked-by: Lev Stipakov <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg13411.html

- --
kind regards,

David Sommerseth

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJYR0D1AAoJEIbPlEyWcf3ym5EP/iURkTasby0UMLpy7MgwKCHD YU8f7Kp5wPkWWiqKiOD9299DeSN/2CBBwUk7eUFZnx2FLnmU0pwUeTJpyMxuRLNj Od2nEXetvUo3QDDDefrqNY5qkKKlYyzIO1YKCTroVCeuPlAj4ESCSH4KbytjBDIw jm/hz8xyymCip/A/hM7/r8ioBGB+Oxp9i5dH5fDuxjWOCe0PzarXGAtOLNtIz47p 5LDuKzgxvieo1dzzSeCFNOgCOuTZrPGj6ZLbjced3lyRMMY7JbTbQBNCL9IcAjEp n2x4hMyM884gRtgxp+lx3e4KWU0kufVW3Llf4Xj5kXmiimlgmwQ1svNyTCt6MI5M rvoa0h9m/3/ryHUtUohVvBKjANqH+t01ePfDw9/fvHv8vcdALmA4kURpsmu0N5W4 SKx/dF6O8PW3YPTWhoW/sO7W60QGIpBUjwkxGwb2GEsehKoB0cHo1a+M26ZxD5T2 qJfS5cAGsFNLxneVNVCyHdHVN7demiwSxUqCkAIgpBhq5EIeEUtpl3V1MEzJ0Ldr 2jWOjbTMl25Znw1qfTxSblSTje5WiK5vLrdgjTGX2MUEDkHMtbd/DHWvazl0dt7G 2soxwViKwTPY+0wdC1UKnr4LIR9xyzOS1EoUJvsz9PmVVN2wljuN0twdOQ63JM9b xRUIcWrHe0qFKH1M0J/a
=22On
-----END PGP SIGNATURE-----