drm/amd/powerplay: use pr_debug to print function not implemented message
Subsystems (2)
PATCH 1/1 drm/amd/powerplay: use pr_debug to print function not implemented message
From: Arindam Nath <[email protected]>
For CZ, some function pointers like display_configuration_changed are not set. So when HW manager tries to configure display, we end up with messages like
"[ powerplay ] this function not implement!"
in the logs. This message is informational, but lacks details on which function is not implemented and why.
Rather than using KERN_INFO to print the message everytime the system boots, we rather use pr_debug so that it is only printed when debug prints are enabled at runtime.
--- drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c +1 -1
@@ -35,7 +35,7 @@ static int phm_run_table(struct pp_hwmgr *hwmgr,phm_table_function *function;if (rt_table->function_list ==NULL ) { -printk (KERN_INFO "[ powerplay ] this function not implement!\n" ); +pr_debug ("[ powerplay ] this function not implement!\n" );return 0 ; }
Signature · 6 lines
2.5.5 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1481138889-10312-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org
Edward O'Callaghan
Reviewed-byQuoted 28 lines · Alex Deucher
From: Arindam Nath <[email protected]>
For CZ, some function pointers like
display_configuration_changedare not set. So when HW manager tries to configure display, we end up with messages like"[ powerplay ] this function not implement!"
in the logs. This message is informational, but lacks details on which function is not implemented and why.
Rather than using
KERN_INFOto print the message everytime the system boots, we rather usepr_debugso that it is only printed when debug prints are enabled at runtime.Reviewed-by Huang Rui <[email protected]>Signed-off-by Arindam Nath <[email protected]>Signed-off-by Alex Deucher <[email protected]>--- drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c +0
-0
drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c static int phm_run_table(struct pp_hwmgr *hwmgr, · line 41
Quoted 8 lines
drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c +1
-1@@ -35,7 +35,7 @@ static int phm_run_table(struct pp_hwmgr *hwmgr,phm_table_function *function;if (rt_table->function_list ==NULL ) { -printk (KERN_INFO "[ powerplay ] this function not implement!\n" ); +pr_debug ("[ powerplay ] this function not implement!\n" );return 0 ; }
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx