Skip to contentSkip to conversation

Patch "GSO: Reload iph after pskb_may_pull" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Dec 8, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

GSO: Reload iph after pskb_may_pull

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
gso-reload-iph-after-pskb_may_pull.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Thu Dec 8 07:19:12 CET 2016

From: Arnaldo Carvalho de Melo <[email protected]>
Date: Mon, 28 Nov 2016 12:36:58 -0300
Subject: GSO: Reload iph after pskb_may_pull

From: Arnaldo Carvalho de Melo <[email protected]>

[ Upstream commit a510887824171ad260cc4a2603396c6247fdd091 ]

As it may get stale and lead to use after free.

Cc Alexander Duyck <[email protected]>
Cc Andrey Konovalov <[email protected]>
Fixes cbc53e08a793 ("GSO: Add GSO type for fixed IPv4 ID")
---
 net/ipv4/af_inet.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv4/af_inet.c +1 -1
@@ -1237,7 +1237,7 @@ struct sk_buff *inet_gso_segment(struct
 		fixedid = !!(skb_shinfo(skb)->gso_type & SKB_GSO_TCP_FIXEDID);
 
 		/* fixed ID is invalid if DF bit is not set */
-		if (fixedid && !(iph->frag_off & htons(IP_DF)))
+		if (fixedid && !(ip_hdr(skb)->frag_off & htons(IP_DF)))
 			goto out;
 	}
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/gso-reload-iph-after-pskb_may_pull.patch