Skip to contentSkip to conversation

Patch "rtnl: fix the loop index update error in rtnl_dump_ifinfo()" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 2 messages Dec 8, 2016 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

rtnl: fix the loop index update error in rtnl_dump_ifinfo()

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
rtnl-fix-the-loop-index-update-error-in-rtnl_dump_ifinfo.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Thu Dec 8 07:19:12 CET 2016

From: Zhang Shengju <[email protected]>
Date: Sat, 19 Nov 2016 23:28:32 +0800
Subject: rtnl: fix the loop index update error in rtnl_dump_ifinfo()

From: Zhang Shengju <[email protected]>

[ Upstream commit 3f0ae05d6fea0ed5b19efdbc9c9f8e02685a3af3 ]

If the link is filtered out, loop index should also be updated. If not, loop index will not be correct.

Fixes dc599f76c22b0 ("net: Add support for filtering link dump by master device and kind")
---
 net/core/rtnetlink.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/core/rtnetlink.c +1 -1
@@ -1578,7 +1578,7 @@ static int rtnl_dump_ifinfo(struct sk_bu
 		head = &net->dev_index_head[h];
 		hlist_for_each_entry(dev, head, index_hlist) {
 			if (link_dump_filtered(dev, master_idx, kind_ops))
-				continue;
+				goto cont;
 			if (idx < s_idx)
 				goto cont;
 			err = rtnl_fill_ifinfo(skb, dev, RTM_NEWLINK,

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/rtnl-fix-the-loop-index-update-error-in-rtnl_dump_ifinfo.patch

A message that is not in the archive (sent off-list or not yet received): [email protected]

author maintainer
#2 lore raw
Quoted 9 lines · David Ahern
Quoted 8 lines · On 12/7/16 10:21 PM, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

rtnl: fix the loop index update error in rtnl_dump_ifinfo()

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 8 lines
Quoted 6 lines

The filename of the patch is:
rtnl-fix-the-loop-index-update-error-in-rtnl_dump_ifinfo.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

please drop this patch for 4.8 and all other stable backports. It is a no-op patch.

If it is a no-op, why is it in Linus's tree now too? Should it be reverted there?

confused,

greg k-h