Skip to contentSkip to conversation

oepydevshell-internal.py: standardize usage output

PATCH New Ed Bartosh 1 participant 1 message Dec 9, 2016

lore
Share & tools
lore

Ed Bartosh

author
#0 lore raw

PATCH 1/1 oepydevshell-internal.py: standardize usage output

Made usage output of oepydevshell-internal.py to look similar to the output of other oe scripts.

[YOCTO #10751]

---
 scripts/oepydevshell-internal.py | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)
scripts/oepydevshell-internal.py +11 -4
index a22bec3..04621ae 100755
@@ -22,9 +22,16 @@ def cbreaknoecho(fd):
     old[3] = old[3] &~ termios.ECHO &~ termios.ICANON
     termios.tcsetattr(fd, termios.TCSADRAIN, old)
 
-if len(sys.argv) != 3:
-    print("Incorrect parameters")
-    sys.exit(1)
+if len(sys.argv) != 3 or sys.argv[1] in ('-h', '--help'):
+    print('oepydevshell-internal.py: error: the following arguments are required: pty, pid\n'
+          'Usage: oepydevshell-internal.py pty pid\n\n'
+          'OpenEmbedded oepydevshell-internal.py - internal script called from meta/classes/devshell.bbclass\n\n'
+          'arguments:\n'
+          '  pty                   pty device name\n'
+          '  pid                   parent process id\n\n'
+          'options:\n'
+          '  -h, --help            show this help message and exit\n')
+    sys.exit(2)
 
 pty = open(sys.argv[1], "w+b", 0)
 parent = int(sys.argv[2])
@@ -38,7 +45,7 @@ readline.parse_and_bind("tab: complete")
 try:
     readline.read_history_file(histfile)
 except IOError:
-    pass 
+    pass
 
 try:
 
Signature · 1 line
2.1.4