Skip to contentSkip to conversation

Patch "ipv4: Set skb->protocol properly for local output" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Dec 9, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

    ipv4: Set skb->protocol properly for local output

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ipv4-set-skb-protocol-properly-for-local-output.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From f4180439109aa720774baafdd798b3234ab1a0d2 Mon Sep 17 00:00:00 2001

From: Eli Cooper <[email protected]>
Date: Thu, 1 Dec 2016 10:05:10 +0800
Subject: ipv4: Set skb->protocol properly for local output

From: Eli Cooper <[email protected]>

commit f4180439109aa720774baafdd798b3234ab1a0d2 upstream.

When xfrm is applied to TSO/GSO packets, it follows this path:

    xfrm_output() -> xfrm_output_gso() -> skb_gso_segment()

where skb_gso_segment() relies on skb->protocol to function properly.

This patch sets skb->protocol to ETH_P_IP before dst_output() is called, fixing a bug where GSO packets sent through a sit tunnel are dropped when xfrm is involved.

---
 net/ipv4/ip_output.c |    3 +++
 1 file changed, 3 insertions(+)
net/ipv4/ip_output.c +3 -0
@@ -98,6 +98,9 @@ int __ip_local_out(struct net *net, stru
 
 	iph->tot_len = htons(skb->len);
 	ip_send_check(iph);
+
+	skb->protocol = htons(ETH_P_IP);
+
 	return nf_hook(NFPROTO_IPV4, NF_INET_LOCAL_OUT,
 		       net, sk, skb, NULL, skb_dst(skb)->dev,
 		       dst_output);

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/ipv6-set-skb-protocol-properly-for-local-output.patch queue-4.8/ipv4-set-skb-protocol-properly-for-local-output.patch queue-4.8/revert-ip6_tunnel-update-skb-protocol-to-eth_p_ipv6-in-ip6_tnl_xmit.patch